[jira] [Commented] (CASSANDRA-12660) NIODataInputStreamTest - Function with an infinite loop
[ https://issues.apache.org/jira/browse/CASSANDRA-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598180#comment-15598180 ] Arunkumar M commented on CASSANDRA-12660: - Done, added an entry in CHANGES.txt and commit message. > NIODataInputStreamTest - Function with an infinite loop > --- > > Key: CASSANDRA-12660 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12660 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Marianne Linhares Monteiro >Assignee: Arunkumar M >Priority: Trivial > Labels: easyfix, low-hanging-fruit > Fix For: 2.2.x, 3.0.x, 3.x, 4.x > > Attachments: 12660-3.9.txt, 12660-3.9.txt > > Original Estimate: 5m > Remaining Estimate: 5m > > Function with an infinite loop and not needed. > https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/io/util/NIODataInputStreamTest.java > - lines 97-101 > isOpen() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12660) NIODataInputStreamTest - Function with an infinite loop
[ https://issues.apache.org/jira/browse/CASSANDRA-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508720#comment-15508720 ] Arunkumar M commented on CASSANDRA-12660: - Sure, attached another patch. > NIODataInputStreamTest - Function with an infinite loop > --- > > Key: CASSANDRA-12660 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12660 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Marianne Linhares Monteiro >Assignee: Arunkumar M >Priority: Trivial > Labels: easyfix, low-hanging-fruit > Fix For: 3.9 > > Attachments: 12660-3.9.txt > > Original Estimate: 5m > Remaining Estimate: 5m > > Function with an infinite loop and not needed. > https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/io/util/NIODataInputStreamTest.java > - lines 97-101 > isOpen() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12660) NIODataInputStreamTest - Function with an infinite loop
[ https://issues.apache.org/jira/browse/CASSANDRA-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499009#comment-15499009 ] Marianne Linhares Monteiro commented on CASSANDRA-12660: Arunkumar M, actually, the method is needed, sorry. Just make the method return isOpen instead of calling itself, and it seems okay. Thanks! > NIODataInputStreamTest - Function with an infinite loop > --- > > Key: CASSANDRA-12660 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12660 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Marianne Linhares Monteiro >Assignee: Arunkumar M >Priority: Trivial > Labels: easyfix, low-hanging-fruit > Fix For: 3.9 > > Attachments: 12660-3.9.txt > > Original Estimate: 5m > Remaining Estimate: 5m > > Function with an infinite loop and not needed. > https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/io/util/NIODataInputStreamTest.java > - lines 97-101 > isOpen() -- This message was sent by Atlassian JIRA (v6.3.4#6332)