[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901538#comment-16901538
]
DeepakVohra commented on CASSANDRA-13728:
-
With latest 4.0 build the output is still the same as before.
{code:java}
nodetool statushandoff
Hinted handoff is running
{code}
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Low
> Labels: lhf
> Fix For: 4.0
>
> Attachments: Add-nodetool-cmd-to-print-hinted-handoff-window.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148893#comment-16148893
]
Jason Brown commented on CASSANDRA-13728:
-
I'm with [~iamaleksey] here. Let's just add new stuff to trunk at this point.
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: Add-nodetool-cmd-to-print-hinted-handoff-window.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148803#comment-16148803
]
Aleksey Yeschenko commented on CASSANDRA-13728:
---
[~jjirsa] Isn't 3.11.x bug fix only as well at this stage?
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: Add-nodetool-cmd-to-print-hinted-handoff-window.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148478#comment-16148478
]
Varun Gupta commented on CASSANDRA-13728:
-
I am good with skipping 3.0.
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: Add-nodetool-cmd-to-print-hinted-handoff-window.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148435#comment-16148435
]
Jeff Jirsa commented on CASSANDRA-13728:
[~varung] - patch looks like 3.11 + trunk. Fixver here is set to
3.0/3.11/trunk. Are you OK if I only commit to 3.11 and trunk, or do you have a
strong opinion that this belongs in 3.0 (3.0 is technically bugfix only, so I'm
OK with skipping it if you are).
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: Add-nodetool-cmd-to-print-hinted-handoff-window.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133307#comment-16133307
]
Varun Gupta commented on CASSANDRA-13728:
-
[~jjirsa] Please find the updated patch!
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
> Attachments: Add-nodetool-cmd-to-print-hinted-handoff-window.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131479#comment-16131479
]
Jeff Jirsa commented on CASSANDRA-13728:
If you change that, and you undo the changes to imports that your IDE probably
did on your behalf, I'll be happy to +1 it for you (talked to Jason and he says
he doesnt mind)
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.15, 3.11.1
>
> Attachments: display-max-hint-handoff-period.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131474#comment-16131474
]
Jeff Jirsa commented on CASSANDRA-13728:
I'm not [~jasobrown] , but I do have an opinion that we shouldn't change output
of existing JMX endpoints in minor versions, as people may be parsing it with
tools and relying on its output not changing. We should treat it as a public
API, and not break it on a minor.
Would be better (in my opinion) to use {{spProxy.getMaxHintWindow()}} to add a
new nodetool command (such as {{nodetool handoffwindow}} or similar) instead.
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Assignee: Varun Gupta
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.15, 3.11.1
>
> Attachments: display-max-hint-handoff-period.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131358#comment-16131358
]
Varun Gupta commented on CASSANDRA-13728:
-
[~jasobrown] can you please review the patch?
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.15, 3.11.1
>
> Attachments: display-max-hint-handoff-period.patch
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111486#comment-16111486
]
Bharath Kumar Uppala commented on CASSANDRA-13728:
--
Hi,
I would like to work on this.
I am new to open source development. Please provide me the steps to setup my
workspace and other info that get me started.
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Priority: Minor
> Labels: lhf
> Fix For: 3.0.15, 3.11.1
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13728) Provide max hint window as part of nodetool
[
https://issues.apache.org/jira/browse/CASSANDRA-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099956#comment-16099956
]
Jason Brown commented on CASSANDRA-13728:
-
[~milansm] that sounds like a reasonable output. If you can knock this out,
that would be great!
> Provide max hint window as part of nodetool
> ---
>
> Key: CASSANDRA-13728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13728
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Milan Milosevic
>Priority: Minor
> Fix For: 3.0.15, 3.11.1
>
>
> Currently it is not possible to get max_hint_window over nodetool. The
> information is available through StorageProxyMBean, though. Since max hint
> window information is needed in order to asses what kind of failure recovery
> should be performed for a node that goes down (bootstrap or just restart), it
> would be handy if max hint window is easily accessible using nodetool.
> Currently nodetool statushandoff output is:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running
> {code}
> The output could be improved to look like this:
> {code}
> [centos@cassandra-node]$ nodetool statushandoff
> Hinted handoff is running with max hint window (ms): 1080
> {code}
> Implementation is quite trivial (fetch the info from the StorageProxyMBean
> from the StatusHandoff class). I can provide the patch for this, if it is
> agreed that this it right approach.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
