[jira] [Commented] (CASSANDRA-14094) Avoid pointless calls to ThreadLocalRandom
[ https://issues.apache.org/jira/browse/CASSANDRA-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278314#comment-16278314 ] Jason Brown commented on CASSANDRA-14094: - +1 > Avoid pointless calls to ThreadLocalRandom > -- > > Key: CASSANDRA-14094 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14094 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jeff Jirsa >Assignee: Jeff Jirsa >Priority: Minor > Fix For: 3.0.x, 3.11.x, 4.x > > > In the compression paths, we probabilistically validate the checksum. In > cases where the chance is 100%, we don’t need to call {{ThreadLocalRandom}} . -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14094) Avoid pointless calls to ThreadLocalRandom
[ https://issues.apache.org/jira/browse/CASSANDRA-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277879#comment-16277879 ] Jeff Jirsa commented on CASSANDRA-14094: Trivial fixes for just the compression paths: || 3.0 || 3.11 || trunk|| | [branch|https://github.com/jeffjirsa/cassandra/commits/cassandra-3.0-14094] | [branch|https://github.com/jeffjirsa/cassandra/commits/cassandra-3.11-14094] | [branch|https://github.com/jeffjirsa/cassandra/commits/cassandra-14094] | | [utests & dtests|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-14094] | [branch|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-14094] | [branch|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-14094] | > Avoid pointless calls to ThreadLocalRandom > -- > > Key: CASSANDRA-14094 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14094 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Jeff Jirsa >Assignee: Jeff Jirsa >Priority: Minor > Fix For: 3.0.x, 3.11.x, 4.x > > > In the compression paths, we probabilistically validate the checksum. In > cases where the chance is 100%, we don’t need to call {{ThreadLocalRandom}} . -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org