[jira] [Commented] (CASSANDRA-14233) nodetool tablestats/cfstats output has inconsistent formatting for latency

2018-03-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399609#comment-16399609
 ] 

ASF GitHub Bot commented on CASSANDRA-14233:


Github user sproberts92 closed the pull request at:

https://github.com/apache/cassandra/pull/195


> nodetool tablestats/cfstats output has inconsistent formatting for latency
> --
>
> Key: CASSANDRA-14233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14233
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Samuel Roberts
>Assignee: Samuel Roberts
>Priority: Trivial
> Fix For: 3.11.2, 4.0
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Latencies are reported at keyspace level with `ms.` and at table level with 
> `ms`.
> There should be no trailing `.` as it is not a sentence and `.` is not part 
> of the abbreviation.
> This is also present in 2.x with `nodetool cfstats`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14233) nodetool tablestats/cfstats output has inconsistent formatting for latency

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387529#comment-16387529
 ] 

ASF GitHub Bot commented on CASSANDRA-14233:


Github user spodkowinski commented on the issue:

https://github.com/apache/cassandra/pull/195
  
Please close the PR as the patch already has been merged in 
d10e6ac606c6b484c75bb850de7a754b75ad5eca


> nodetool tablestats/cfstats output has inconsistent formatting for latency
> --
>
> Key: CASSANDRA-14233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14233
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Samuel Roberts
>Assignee: Samuel Roberts
>Priority: Trivial
> Fix For: 3.11.2, 4.0
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Latencies are reported at keyspace level with `ms.` and at table level with 
> `ms`.
> There should be no trailing `.` as it is not a sentence and `.` is not part 
> of the abbreviation.
> This is also present in 2.x with `nodetool cfstats`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14233) nodetool tablestats/cfstats output has inconsistent formatting for latency

2018-02-14 Thread Samuel Roberts (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363607#comment-16363607
 ] 

Samuel Roberts commented on CASSANDRA-14233:


Ok, I've done it against trunk.

Also, Gary Stewart from NL wants the world to know that he was the one who 
noticed the inconstancy, so let that be recorded here for posterity.

> nodetool tablestats/cfstats output has inconsistent formatting for latency
> --
>
> Key: CASSANDRA-14233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14233
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Samuel Roberts
>Assignee: Samuel Roberts
>Priority: Trivial
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Latencies are reported at keyspace level with `ms.` and at table level with 
> `ms`.
> There should be no trailing `.` as it is not a sentence and `.` is not part 
> of the abbreviation.
> This is also present in 2.x with `nodetool cfstats`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14233) nodetool tablestats/cfstats output has inconsistent formatting for latency

2018-02-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363560#comment-16363560
 ] 

ASF GitHub Bot commented on CASSANDRA-14233:


GitHub user sproberts92 opened a pull request:

https://github.com/apache/cassandra/pull/195

Resolve nodetool formatting in CASSANDRA-14233

Remove trailing "." from latency reports at keyspace level.

For 
[CASSANDRA-14233](https://issues.apache.org/jira/browse/CASSANDRA-14233).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sproberts92/cassandra CASSANDRA-14233

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cassandra/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit ae6e74ac0f31161be10481f2f4c76cebfe45d7b0
Author: Samuel Roberts 
Date:   2018-02-14T06:44:50Z

Resolve nodetool formatting in CASSANDRA-14233

Remove trailing "." from latency reports at keyspace level.




> nodetool tablestats/cfstats output has inconsistent formatting for latency
> --
>
> Key: CASSANDRA-14233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14233
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Samuel Roberts
>Assignee: Samuel Roberts
>Priority: Trivial
> Attachments: Resolve-nodetool-formatting-in-CASSANDRA-14233.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Latencies are reported at keyspace level with `ms.` and at table level with 
> `ms`.
> There should be no trailing `.` as it is not a sentence and `.` is not part 
> of the abbreviation.
> This is also present in 2.x with `nodetool cfstats`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14233) nodetool tablestats/cfstats output has inconsistent formatting for latency

2018-02-13 Thread Chris Lohfink (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363257#comment-16363257
 ] 

Chris Lohfink commented on CASSANDRA-14233:
---

Can you just make it for trunk? 2.0 isnt taking changes anymore and 2.1 is 
pretty much reserved to data loss bugs.

> nodetool tablestats/cfstats output has inconsistent formatting for latency
> --
>
> Key: CASSANDRA-14233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14233
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Samuel Roberts
>Priority: Trivial
> Attachments: Resolve-nodetool-formatting-in-CASSANDRA-14233.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Latencies are reported at keyspace level with `ms.` and at table level with 
> `ms`.
> There should be no trailing `.` as it is not a sentence and `.` is not part 
> of the abbreviation.
> This is also present in 2.x with `nodetool cfstats`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14233) nodetool tablestats/cfstats output has inconsistent formatting for latency

2018-02-13 Thread Samuel Roberts (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363198#comment-16363198
 ] 

Samuel Roberts commented on CASSANDRA-14233:


Very simple to fix:

[https://github.com/sproberts92/cassandra/commit/05ccb4851bf2ab1f35237ec901e1426a9bda]

but I am confused about which branch to commit to - docs state start with the 
oldest branch? As the file has been moved around a lot and names changed I'm 
not sure if this will propagate to 3.x cleanly.

> nodetool tablestats/cfstats output has inconsistent formatting for latency
> --
>
> Key: CASSANDRA-14233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14233
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Samuel Roberts
>Priority: Trivial
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Latencies are reported at keyspace level with `ms.` and at table level with 
> `ms`.
> There should be no trailing "." as it is not a sentence and "." is not part 
> of the abbreviation.
> This is also present in 2.x with `nodetool cfstats`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org