[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431173#comment-16431173
]
Dinesh Joshi commented on CASSANDRA-14260:
--
[~jjirsa] do you think it would be worthwhile
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430882#comment-16430882
]
Jeff Jirsa commented on CASSANDRA-14260:
Sorry, pushed to a different branch (
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430880#comment-16430880
]
Dinesh Joshi commented on CASSANDRA-14260:
--
[~jjirsa] could you please retrigger circleci?
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430648#comment-16430648
]
Jeff Jirsa commented on CASSANDRA-14260:
Well before I merged it, some other work (storage
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407223#comment-16407223
]
Nate McCall commented on CASSANDRA-14260:
-
Nit on the {{equals()}} and {{hashCode()}} impls -
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405824#comment-16405824
]
Dinesh Joshi commented on CASSANDRA-14260:
--
+1
The changes look good. You did not swap left
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383762#comment-16383762
]
Sylvain Lebresne commented on CASSANDRA-14260:
--
Had a look and this lgtm in general. I'm
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383318#comment-16383318
]
Dinesh Joshi commented on CASSANDRA-14260:
--
[~jjirsa] your PR is a great step in the right
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383234#comment-16383234
]
Jeff Jirsa commented on CASSANDRA-14260:
Force pushed, refactored to have specialized inner
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377629#comment-16377629
]
Blake Eggleston commented on CASSANDRA-14260:
-
{quote} I would prefer moving out of using
[
https://issues.apache.org/jira/browse/CASSANDRA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376627#comment-16376627
]
Sylvain Lebresne commented on CASSANDRA-14260:
--
For what it's worth, I would prefer
11 matches
Mail list logo