[jira] [Commented] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
[
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432181#comment-16432181
]
Marcus Eriksson commented on CASSANDRA-14371:
-
lets wait for the ccm fix
ping [~philipthompson]
> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
>
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Patrick Bannister
>Priority: Major
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> > failure = stderr.find("java.lang.AssertionError: Data component
> > is missing")
> E TypeError: a bytes-like object is required, not 'str'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
[
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431651#comment-16431651
]
Patrick Bannister commented on CASSANDRA-14371:
---
Opened Issue #670 and submitted Pull Request #671 to ccm to address this issue.
Please advise if you'd like me to reopen CASSANDRA-14334 and submit a stopgap
patch to conditionally decode if we get a bytes object for stdout or stderr - I
could submit it tomorrow night if needed.
> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
>
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Major
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> > failure = stderr.find("java.lang.AssertionError: Data component
> > is missing")
> E TypeError: a bytes-like object is required, not 'str'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
[
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431620#comment-16431620
]
Patrick Bannister commented on CASSANDRA-14371:
---
OK, the root cause of this test failure is that CASSANDRA-14334 did not fix the
problem completely. Details below, but short version is that ccm returns stdout
and stderr for nodetool commands as a string if there's anything on the stream,
or as a bytes if they're empty.
In the event that a process returns no errors, it returns an empty bytes object
for stderr. ccm's ccmlib/node.py only decodes stderr if it evaluates to True
and it's a bytes object. (The same is true for stdout.) An empty bytes object
evaluates as False, so most likely, what happened is that nodetool sstablesplit
returned no errors, hence ccm returned it as an empty bytes (b''), then
cassandra-dtest's sstablesplit_test.py::test_single_file_split calls the empty
bytes object's .find() method with a string argument, resulting in the
TypeError in the test run.
The best solution here is to get ccm to consistently return a string from
handle_external_tool_process in ccmlib/node.py. I'll look into that.
As an intermediate solution, I could reopen CASSANDRA-14334 and we could
conditionally decode stdout and stderr if they're bytes instances, in all the
affected places.
> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
>
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Major
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> > failure = stderr.find("java.lang.AssertionError: Data component
> > is missing")
> E TypeError: a bytes-like object is required, not 'str'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
[
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431595#comment-16431595
]
Patrick Bannister commented on CASSANDRA-14371:
---
Markus Eriksson, I'm still studying the Jenkins build to confirm this, but my
working theory is that this Jenkins build is using ccm on the master branch
instead of on the cassandra-test branch. Right now, on the master branch,
handle_external_tool_process in ccmlib/node.py doesn't decode stdout or stderr
before returning it - that behavior is only on the cassandra-test branch.
What is our preferred ccm build for testing? I've been using its cassandra-test
branch for my tests, since that's what the cassandra-dtest requirements.txt
specifies right now.
> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
>
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Major
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> > failure = stderr.find("java.lang.AssertionError: Data component
> > is missing")
> E TypeError: a bytes-like object is required, not 'str'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
[
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431565#comment-16431565
]
Patrick Bannister commented on CASSANDRA-14371:
---
We've seen a few of these recently :) I'll check it out.
> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
>
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Major
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> > failure = stderr.find("java.lang.AssertionError: Data component
> > is missing")
> E TypeError: a bytes-like object is required, not 'str'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14371) dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
[
https://issues.apache.org/jira/browse/CASSANDRA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430578#comment-16430578
]
Marcus Eriksson commented on CASSANDRA-14371:
-
[~ptbannister] could you have a look? Otherwise I'll get to it soon
> dtest failure: sstablesplit_test.TestSSTableSplit.test_single_file_split
>
>
> Key: CASSANDRA-14371
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14371
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Priority: Major
>
> https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-trunk-dtest/489/testReport/sstablesplit_test/TestSSTableSplit/test_single_file_split/
> {code}
> for (stdout, stderr, rc) in result:
> logger.debug(stderr)
> > failure = stderr.find("java.lang.AssertionError: Data component
> > is missing")
> E TypeError: a bytes-like object is required, not 'str'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
