[jira] [Commented] (CASSANDRA-14675) Log the actual (if server-generated) timestamp and nowInSeconds used by queries in FQL
[ https://issues.apache.org/jira/browse/CASSANDRA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599139#comment-16599139 ] Aleksey Yeschenko commented on CASSANDRA-14675: --- Thanks, committed as [5b645de13f8bea775d5a979712b3bea910960255|https://github.com/apache/cassandra/commit/5b645de13f8bea775d5a979712b3bea910960255] to trunk. FQL/AuditLog code needs more cleanup. I did as much as I could as part of this patch. > Log the actual (if server-generated) timestamp and nowInSeconds used by > queries in FQL > -- > > Key: CASSANDRA-14675 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14675 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Major > Labels: fqltool > Fix For: 4.0 > > > FQL doesn't currently log the actual timestamp - in microseconds - if it's > been server generated, nor the nowInSeconds value. It needs to, to allow for > - in conjunction with CASSANDRA-14664 and CASSANDRA-14671 - deterministic > playback tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14675) Log the actual (if server-generated) timestamp and nowInSeconds used by queries in FQL
[ https://issues.apache.org/jira/browse/CASSANDRA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599051#comment-16599051 ] Marcus Eriksson commented on CASSANDRA-14675: - and just realised that Dump.java needs update as well > Log the actual (if server-generated) timestamp and nowInSeconds used by > queries in FQL > -- > > Key: CASSANDRA-14675 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14675 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Major > Labels: fqltool > Fix For: 4.0.x > > > FQL doesn't currently log the actual timestamp - in microseconds - if it's > been server generated, nor the nowInSeconds value. It needs to, to allow for > - in conjunction with CASSANDRA-14664 and CASSANDRA-14671 - deterministic > playback tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14675) Log the actual (if server-generated) timestamp and nowInSeconds used by queries in FQL
[ https://issues.apache.org/jira/browse/CASSANDRA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599042#comment-16599042 ] Marcus Eriksson commented on CASSANDRA-14675: - oh and https://github.com/krummas/cassandra/commit/f22ea233de6886b7beae7ef57d50d4b5dd9bad4f - don't know how well chronicle works with repeated fields > Log the actual (if server-generated) timestamp and nowInSeconds used by > queries in FQL > -- > > Key: CASSANDRA-14675 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14675 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Major > Labels: fqltool > Fix For: 4.0.x > > > FQL doesn't currently log the actual timestamp - in microseconds - if it's > been server generated, nor the nowInSeconds value. It needs to, to allow for > - in conjunction with CASSANDRA-14664 and CASSANDRA-14671 - deterministic > playback tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14675) Log the actual (if server-generated) timestamp and nowInSeconds used by queries in FQL
[ https://issues.apache.org/jira/browse/CASSANDRA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598949#comment-16598949 ] Aleksey Yeschenko commented on CASSANDRA-14675: --- [~krummas] Oh, good catch. Will do once CASSANDRA-14671 is in. > Log the actual (if server-generated) timestamp and nowInSeconds used by > queries in FQL > -- > > Key: CASSANDRA-14675 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14675 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Major > Labels: fqltool > Fix For: 4.0.x > > > FQL doesn't currently log the actual timestamp - in microseconds - if it's > been server generated, nor the nowInSeconds value. It needs to, to allow for > - in conjunction with CASSANDRA-14664 and CASSANDRA-14671 - deterministic > playback tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14675) Log the actual (if server-generated) timestamp and nowInSeconds used by queries in FQL
[ https://issues.apache.org/jira/browse/CASSANDRA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598926#comment-16598926 ] Marcus Eriksson commented on CASSANDRA-14675: - fixed weight calculation in Batch and renamed the "type" field to batchType to not confuse it with the type of the entry in the full query log: https://github.com/krummas/cassandra/commit/7d5425ee4a8dd3392be1c7276b34d107b510d731 feel free to include on commit, +1 > Log the actual (if server-generated) timestamp and nowInSeconds used by > queries in FQL > -- > > Key: CASSANDRA-14675 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14675 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Major > Labels: fqltool > Fix For: 4.0.x > > > FQL doesn't currently log the actual timestamp - in microseconds - if it's > been server generated, nor the nowInSeconds value. It needs to, to allow for > - in conjunction with CASSANDRA-14664 and CASSANDRA-14671 - deterministic > playback tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14675) Log the actual (if server-generated) timestamp and nowInSeconds used by queries in FQL
[ https://issues.apache.org/jira/browse/CASSANDRA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598805#comment-16598805 ] Aleksey Yeschenko commented on CASSANDRA-14675: --- Code [here|https://github.com/iamaleksey/cassandra/commits/14675-4.0], CI [here|https://circleci.com/workflow-run/9fd7e270-5388-44ae-bd53-569da98eb03c]. > Log the actual (if server-generated) timestamp and nowInSeconds used by > queries in FQL > -- > > Key: CASSANDRA-14675 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14675 > Project: Cassandra > Issue Type: Improvement >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Major > Labels: fqltool > Fix For: 4.0.x > > > FQL doesn't currently log the actual timestamp - in microseconds - if it's > been server generated, nor the nowInSeconds value. It needs to, to allow for > - in conjunction with CASSANDRA-14664 and CASSANDRA-14671 - deterministic > playback tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
