[jira] [Commented] (CASSANDRA-14716) Protocol frame checksumming options should not be case sensitive
[
https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700436#comment-16700436
]
Aleksey Yeschenko commented on CASSANDRA-14716:
---
[~djoshi3] yeah, that would also work.
[~beobal] +1
> Protocol frame checksumming options should not be case sensitive
>
>
> Key: CASSANDRA-14716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14716
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Protocol v5 adds support for checksumming of native protocol frame bodies.
> The checksum type is negotiated per-connection via the \{{STARTUP}} message,
> with two types currently supported, Adler32 and CRC32. The mapping of the
> startup option value requested by the client to a \{{ChecksumType}} should
> not be case sensitive, but currently it is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14716) Protocol frame checksumming options should not be case sensitive
[
https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700372#comment-16700372
]
Sam Tunnicliffe commented on CASSANDRA-14716:
-
Rebased and updated branch to uppercase the enum value.
||branch||CI||
|[14716-trunk|https://github.com/beobal/cassandra/tree/14716-trunk]|[circle|https://circleci.com/gh/beobal/workflows/cassandra/tree/cci%2F14716-trunk]|
> Protocol frame checksumming options should not be case sensitive
>
>
> Key: CASSANDRA-14716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14716
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Protocol v5 adds support for checksumming of native protocol frame bodies.
> The checksum type is negotiated per-connection via the \{{STARTUP}} message,
> with two types currently supported, Adler32 and CRC32. The mapping of the
> startup option value requested by the client to a \{{ChecksumType}} should
> not be case sensitive, but currently it is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14716) Protocol frame checksumming options should not be case sensitive
[
https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700148#comment-16700148
]
Sam Tunnicliffe commented on CASSANDRA-14716:
-
{quote}Is it too late to change {{Adler32}} to {{ADLER32}} at this point? Would
it be desirable?{quote}
No, I think that's acceptable and desirable, if only for consistency. This is
the only usage of {{ChecksumType}} where the algo is configurable, every other
usage is hardcoded to {{CRC32}}. We included support for {{Adler32}} in
CASSANDRA-13304, rather than just removing that {{ChecksumType}} to enable
future potential perf improvements to be taken advantage of
(https://issues.apache.org/jira/browse/CASSANDRA-13304?focusedCommentId=15923191=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15923191).
Before committing I'll rename the enum value, re-run CI and post a message to
dev list to be sure nobody objects to this post-freeze change. Thanks.
> Protocol frame checksumming options should not be case sensitive
>
>
> Key: CASSANDRA-14716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14716
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Protocol v5 adds support for checksumming of native protocol frame bodies.
> The checksum type is negotiated per-connection via the \{{STARTUP}} message,
> with two types currently supported, Adler32 and CRC32. The mapping of the
> startup option value requested by the client to a \{{ChecksumType}} should
> not be case sensitive, but currently it is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14716) Protocol frame checksumming options should not be case sensitive
[
https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1661#comment-1661
]
Dinesh Joshi commented on CASSANDRA-14716:
--
Another option would be to use a static, immutable map of upper cased values to
{{ChecksumType}} and use that.
> Protocol frame checksumming options should not be case sensitive
>
>
> Key: CASSANDRA-14716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14716
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Protocol v5 adds support for checksumming of native protocol frame bodies.
> The checksum type is negotiated per-connection via the \{{STARTUP}} message,
> with two types currently supported, Adler32 and CRC32. The mapping of the
> startup option value requested by the client to a \{{ChecksumType}} should
> not be case sensitive, but currently it is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14716) Protocol frame checksumming options should not be case sensitive
[
https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699543#comment-16699543
]
Aleksey Yeschenko commented on CASSANDRA-14716:
---
That said, +1 either way.
> Protocol frame checksumming options should not be case sensitive
>
>
> Key: CASSANDRA-14716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14716
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Protocol v5 adds support for checksumming of native protocol frame bodies.
> The checksum type is negotiated per-connection via the \{{STARTUP}} message,
> with two types currently supported, Adler32 and CRC32. The mapping of the
> startup option value requested by the client to a \{{ChecksumType}} should
> not be case sensitive, but currently it is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14716) Protocol frame checksumming options should not be case sensitive
[
https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699533#comment-16699533
]
Aleksey Yeschenko commented on CASSANDRA-14716:
---
I might be missing it, and probably am, but what is the reason for not simply
doing {{ChecksumType.valueOf(name.toUpperCase)}}, and rethrowing
{{IllegalArgumentException}} as {{ProtocolException}}?
> Protocol frame checksumming options should not be case sensitive
>
>
> Key: CASSANDRA-14716
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14716
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Major
> Fix For: 4.0
>
>
> Protocol v5 adds support for checksumming of native protocol frame bodies.
> The checksum type is negotiated per-connection via the \{{STARTUP}} message,
> with two types currently supported, Adler32 and CRC32. The mapping of the
> startup option value requested by the client to a \{{ChecksumType}} should
> not be case sensitive, but currently it is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
