[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-30 Thread Yifan Cai (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071104#comment-17071104 ] Yifan Cai commented on CASSANDRA-15630: --- [~blerer], would you like to take another look and

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-26 Thread Yifan Cai (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067789#comment-17067789 ] Yifan Cai commented on CASSANDRA-15630: --- CI passed. Link:

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-26 Thread Benjamin Lerer (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067685#comment-17067685 ] Benjamin Lerer commented on CASSANDRA-15630: [~yifanc] Nice work :-). Thanks a lot. I

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-25 Thread Yifan Cai (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067185#comment-17067185 ] Yifan Cai commented on CASSANDRA-15630: --- [~blerer], the PR was just updated. The

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-25 Thread Yifan Cai (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066993#comment-17066993 ] Yifan Cai commented on CASSANDRA-15630: --- Hi [~blerer], I was not aware of the

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-25 Thread Benjamin Lerer (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066885#comment-17066885 ] Benjamin Lerer commented on CASSANDRA-15630: Based on what I can see, we have some race

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-24 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066044#comment-17066044 ] David Capwell commented on CASSANDRA-15630: --- I believe we do require a committer to review

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-24 Thread Ekaterina Dimitrova (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065963#comment-17065963 ] Ekaterina Dimitrova commented on CASSANDRA-15630: - [~dcapwell] [~jasonstack]

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-19 Thread ZhaoYang (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062522#comment-17062522 ] ZhaoYang commented on CASSANDRA-15630: -- linked both CASSANDRA-15628 and CASSANDRA-15629.. >

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-17 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061191#comment-17061191 ] David Capwell commented on CASSANDRA-15630: --- only minor/nit comments remain; main one is

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-17 Thread Yifan Cai (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061181#comment-17061181 ] Yifan Cai commented on CASSANDRA-15630: --- Thanks [~dcapwell]. I have updated the PR to address

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-17 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061153#comment-17061153 ] David Capwell commented on CASSANDRA-15630: --- Code mostly LGTM; left my comments in GitHub.

[jira] [Commented] (CASSANDRA-15630) Fix flakey testSerializeError - org.apache.cassandra.net.ConnectionTest

2020-03-13 Thread Yifan Cai (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058987#comment-17058987 ] Yifan Cai commented on CASSANDRA-15630: --- After going through the source, the test failure