[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420705#comment-13420705 ] T Jake Luciani commented on CASSANDRA-4240: --- Patch 4 is missing the unit test and overall the patch has tab-space issues. please re-submit once more. Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa Attachments: CASSANDRA-4240.patch, CASSANDRA-4240.patch1, cassandra-1.0.8-CASSANDRA-4240-patch2.txt, cassandra-1.0.8-CASSANDRA-4240-patch3.txt, cassandra-1.0.8-CASSANDRA-4240-patch4.txt, cassandra-1.0.8-CASSANDRA-4240.txt https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417646#comment-13417646 ] Jeremy Hanna commented on CASSANDRA-4240: - I tested patch 4 on a three node cluster that was using DSE's alternate secondary index implementation that allows for larger values for indexed column values. Worked fine. Jake would you mind reviewing the later patch? Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa Attachments: CASSANDRA-4240.patch, CASSANDRA-4240.patch1, cassandra-1.0.8-CASSANDRA-4240-patch2.txt, cassandra-1.0.8-CASSANDRA-4240-patch3.txt, cassandra-1.0.8-CASSANDRA-4240-patch4.txt, cassandra-1.0.8-CASSANDRA-4240.txt https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416239#comment-13416239 ] T Jake Luciani commented on CASSANDRA-4240: --- I think you just need a null check incase the column isn't indexed that you are checking (in the IndexManager) Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa Attachments: CASSANDRA-4240.patch, CASSANDRA-4240.patch1 https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416348#comment-13416348 ] T Jake Luciani commented on CASSANDRA-4240: --- Sorry one more thing. You should add validate to SecondaryIndex class as abstract. Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa Attachments: CASSANDRA-4240.patch, CASSANDRA-4240.patch1, cassandra-1.0.8-CASSANDRA-4240.txt https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416544#comment-13416544 ] T Jake Luciani commented on CASSANDRA-4240: --- +1 Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa Attachments: CASSANDRA-4240.patch, CASSANDRA-4240.patch1, cassandra-1.0.8-CASSANDRA-4240-patch2.txt, cassandra-1.0.8-CASSANDRA-4240-patch3.txt, cassandra-1.0.8-CASSANDRA-4240.txt https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295120#comment-13295120 ] T Jake Luciani commented on CASSANDRA-4240: --- I think you should keep the validation check where it is and add a new call to the secondary index api to validate the length. If you validate just before the index happens, you have a copy in the main CF but the secondary index fails. Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa Attachments: CASSANDRA-4240.patch https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292861#comment-13292861 ] Matt Stump commented on CASSANDRA-4240: --- The problem is that this check is implemented in a manner such that it prevents blobs larger than 64k to be written to the DB when SOLR is enabled. This is also true for SOLR values that are just stored and not indexed. This severely limits the usefulness of the SOLR support in DSE. See DSE support request #1982 for details. Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Bug Affects Versions: 1.0.8 Reporter: Joaquin Casares Labels: datastax_qa https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292879#comment-13292879 ] T Jake Luciani commented on CASSANDRA-4240: --- I agree this validation only makes sense for keys. In general the limit should be the limit of the column value (for example solr can index a megabyte of text in a column value) Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Bug Affects Versions: 1.0.8 Reporter: Joaquin Casares Labels: datastax_qa https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13292945#comment-13292945 ] Matt Stump commented on CASSANDRA-4240: --- Not to be a pain, but this is a major issue for those of us that encounter it. The thrift interface is unusable when SOLR is enabled. To work around you need to serialize data to JSON or XML and submit via SOLR in order to write data to Cassandra. Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Improvement Affects Versions: 1.0.0 Reporter: Joaquin Casares Priority: Minor Labels: datastax_qa https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4240) Only check the size of indexed column values when they are of type KEYS
[ https://issues.apache.org/jira/browse/CASSANDRA-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272982#comment-13272982 ] Jonathan Ellis commented on CASSANDRA-4240: --- Note that relational databases have similar limitations. Indexes are for ordinary values, not blob or clob. Only check the size of indexed column values when they are of type KEYS --- Key: CASSANDRA-4240 URL: https://issues.apache.org/jira/browse/CASSANDRA-4240 Project: Cassandra Issue Type: Bug Affects Versions: 1.0.8 Reporter: Joaquin Casares Labels: datastax_qa https://github.com/apache/cassandra/blob/cassandra-1.0.8/src/java/org/apache/cassandra/thrift/ThriftValidation.java#L431 That line states that: Indexed column values cannot be larger than 64K. But in some cases we would want the column values to be able to be larger than 64k, specifically if the index_type is not of type KEYS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
