[jira] [Updated] (CASSANDRA-12605) Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen collections correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tyler Hobbs updated CASSANDRA-12605: Component/s: Local Write-Read Paths > Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen > collections correctly > --- > > Key: CASSANDRA-12605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12605 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Fix For: 3.0.10, 3.10 > > > {{SinglePartitionReadCommand.queryNeitherCountersNorCollections()}} is used > to determine whether we can search sstables in timestamp order. We cannot > use this optimization when there are multicell values (such as unfrozen > collections or UDTs). However, this method only checks > {{column.type.isCollection() || column.type.isCounter()}}. Instead, it > should check {{column.type.isMulticell() || column.type.isCounter()}}. > This has two implications: > * We are using timestamp-order searching when querying non-frozen UDTs, which > can lead to incorrect/stale results being returned. > * We are not taking advantage of this optimization when querying frozen > collections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12605) Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen collections correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tyler Hobbs updated CASSANDRA-12605: Resolution: Fixed Fix Version/s: 3.0.10 3.10 Status: Resolved (was: Ready to Commit) Thanks, committed as {{21d8a7d3bd5b9ec49f486c3c7a816939c4040686}} to 3.0 and merged up to trunk. > Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen > collections correctly > --- > > Key: CASSANDRA-12605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12605 > Project: Cassandra > Issue Type: Bug >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > Fix For: 3.10, 3.0.10 > > > {{SinglePartitionReadCommand.queryNeitherCountersNorCollections()}} is used > to determine whether we can search sstables in timestamp order. We cannot > use this optimization when there are multicell values (such as unfrozen > collections or UDTs). However, this method only checks > {{column.type.isCollection() || column.type.isCounter()}}. Instead, it > should check {{column.type.isMulticell() || column.type.isCounter()}}. > This has two implications: > * We are using timestamp-order searching when querying non-frozen UDTs, which > can lead to incorrect/stale results being returned. > * We are not taking advantage of this optimization when querying frozen > collections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12605) Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen collections correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-12605: --- Status: Ready to Commit (was: Patch Available) > Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen > collections correctly > --- > > Key: CASSANDRA-12605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12605 > Project: Cassandra > Issue Type: Bug >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > > {{SinglePartitionReadCommand.queryNeitherCountersNorCollections()}} is used > to determine whether we can search sstables in timestamp order. We cannot > use this optimization when there are multicell values (such as unfrozen > collections or UDTs). However, this method only checks > {{column.type.isCollection() || column.type.isCounter()}}. Instead, it > should check {{column.type.isMulticell() || column.type.isCounter()}}. > This has two implications: > * We are using timestamp-order searching when querying non-frozen UDTs, which > can lead to incorrect/stale results being returned. > * We are not taking advantage of this optimization when querying frozen > collections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-12605) Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen collections correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tyler Hobbs updated CASSANDRA-12605: Reviewer: Benjamin Lerer Status: Patch Available (was: In Progress) > Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen > collections correctly > --- > > Key: CASSANDRA-12605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12605 > Project: Cassandra > Issue Type: Bug >Reporter: Tyler Hobbs >Assignee: Tyler Hobbs > > {{SinglePartitionReadCommand.queryNeitherCountersNorCollections()}} is used > to determine whether we can search sstables in timestamp order. We cannot > use this optimization when there are multicell values (such as unfrozen > collections or UDTs). However, this method only checks > {{column.type.isCollection() || column.type.isCounter()}}. Instead, it > should check {{column.type.isMulticell() || column.type.isCounter()}}. > This has two implications: > * We are using timestamp-order searching when querying non-frozen UDTs, which > can lead to incorrect/stale results being returned. > * We are not taking advantage of this optimization when querying frozen > collections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)