[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-18 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
Resolution: Fixed
Status: Resolved  (was: Awaiting Feedback)

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Assignee: Kurt Greaves
>Priority: Trivial
>  Labels: lhf
> Fix For: 3.0.10, 3.10
>
> Attachments: 12776.patch
>
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-18 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
 Assignee: Kurt Greaves
Fix Version/s: 3.10
   3.0.10

Thanks for the report and the patch. 

Committed as {{7d3062f2d5386ef3a98fa268a41b1b293f55e43b}}

 

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Assignee: Kurt Greaves
>Priority: Trivial
>  Labels: lhf
> Fix For: 3.0.10, 3.10
>
> Attachments: 12776.patch
>
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-18 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
Assignee: Kurt Greaves

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Assignee: Kurt Greaves
>Priority: Trivial
>  Labels: lhf
> Attachments: 12776.patch
>
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-18 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
Assignee: (was: Kurt Greaves)
Reviewer: Jeff Jirsa

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Priority: Trivial
>  Labels: lhf
> Attachments: 12776.patch
>
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-17 Thread Kurt Greaves (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kurt Greaves updated CASSANDRA-12776:
-
Status: Awaiting Feedback  (was: Open)

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Priority: Trivial
>  Labels: lhf
> Attachments: 12776.patch
>
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-17 Thread Kurt Greaves (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kurt Greaves updated CASSANDRA-12776:
-
Attachment: 12776.patch

Looks like this was just a typo in the patch for #9681. It only affects the 
debug log message so only a minor issue. Attached a patch (against 3.0) with 
the suggested change. [~benedict] seeing as you made the change can you 
confirm/deny? Thanks.

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Priority: Trivial
>  Labels: lhf
> Attachments: 12776.patch
>
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-11 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
Component/s: (was: Tools)

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Priority: Trivial
>  Labels: lhf
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-11 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
Labels: lhf  (was: )

> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>Reporter: 翟玉勇
>Priority: Trivial
>  Labels: lhf
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12776) when memtable flush Statistics thisOffHeap error

2016-10-11 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-12776:
---
Description: 
{code}
if (largest != null)
{
float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
float flushingOnHeap = 
Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
float flushingOffHeap = 
Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
float thisOnHeap = 
largest.getAllocator().onHeap().ownershipRatio();
float thisOffHeap = 
largest.getAllocator().onHeap().ownershipRatio();
logger.info("Flushing largest {} to free up room. Used total: 
{}, live: {}, flushing: {}, this: {}",
largest.cfs, ratio(usedOnHeap, usedOffHeap), 
ratio(liveOnHeap, liveOffHeap),
ratio(flushingOnHeap, flushingOffHeap), 
ratio(thisOnHeap, thisOffHeap));
largest.cfs.switchMemtableIfCurrent(largest);
}
{code}

Should:

{code}
float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
{code}

Be:

{{offHeap().ownershipRatio();}}

  was:
if (largest != null)
{
float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
float flushingOnHeap = 
Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
float flushingOffHeap = 
Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
float thisOnHeap = 
largest.getAllocator().onHeap().ownershipRatio();
float thisOffHeap = 
largest.getAllocator().onHeap().ownershipRatio();
logger.info("Flushing largest {} to free up room. Used total: 
{}, live: {}, flushing: {}, this: {}",
largest.cfs, ratio(usedOnHeap, usedOffHeap), 
ratio(liveOnHeap, liveOffHeap),
ratio(flushingOnHeap, flushingOffHeap), 
ratio(thisOnHeap, thisOffHeap));
largest.cfs.switchMemtableIfCurrent(largest);
}


 float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
should offHeap().ownershipRatio();


> when memtable flush Statistics thisOffHeap error
> 
>
> Key: CASSANDRA-12776
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12776
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: 翟玉勇
>Priority: Trivial
>
> {code}
> if (largest != null)
> {
> float usedOnHeap = Memtable.MEMORY_POOL.onHeap.usedRatio();
> float usedOffHeap = Memtable.MEMORY_POOL.offHeap.usedRatio();
> float flushingOnHeap = 
> Memtable.MEMORY_POOL.onHeap.reclaimingRatio();
> float flushingOffHeap = 
> Memtable.MEMORY_POOL.offHeap.reclaimingRatio();
> float thisOnHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> float thisOffHeap = 
> largest.getAllocator().onHeap().ownershipRatio();
> logger.info("Flushing largest {} to free up room. Used total: 
> {}, live: {}, flushing: {}, this: {}",
> largest.cfs, ratio(usedOnHeap, usedOffHeap), 
> ratio(liveOnHeap, liveOffHeap),
> ratio(flushingOnHeap, flushingOffHeap), 
> ratio(thisOnHeap, thisOffHeap));
> largest.cfs.switchMemtableIfCurrent(largest);
> }
> {code}
> Should:
> {code}
> float thisOffHeap = largest.getAllocator().onHeap().ownershipRatio();
> {code}
> Be:
> {{offHeap().ownershipRatio();}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)