[GitHub] blueorangutan commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-440056910 Trillian test result (tid-3189) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 23823 seconds Marvin logs:

[GitHub] blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-440175621 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] DaanHoogland commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
DaanHoogland commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-440175408 @blueorangutan test This is an

[GitHub] rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-440170263 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-440170408 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] ustcweizhou commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
ustcweizhou commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439970708 LGTM build 4.11.2-RC successfully on centos7, ubuntu 16.04 and ubuntu 18.04 with this change

[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234765904 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234766361 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

[GitHub] svenvogel commented on issue #3026: Enhance bypass vlan overlap check

2018-11-19 Thread GitBox
svenvogel commented on issue #3026: Enhance bypass vlan overlap check URL: https://github.com/apache/cloudstack/pull/3026#issuecomment-440012160 @rhtyd @GabrielBrascher can you check please? thx This is an automated message

[cloudstack] branch master updated: Display mac address in nic detail view (#3034)

2018-11-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new a216d0d Display mac address in nic detail

[GitHub] DaanHoogland closed pull request #3034: Display mac address in nic detail view

2018-11-19 Thread GitBox
DaanHoogland closed pull request #3034: Display mac address in nic detail view URL: https://github.com/apache/cloudstack/pull/3034 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] DaanHoogland closed pull request #3028: Adding zone disablement during deletion of the range plus one more tr…

2018-11-19 Thread GitBox
DaanHoogland closed pull request #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[cloudstack] branch master updated: Adding zone disablement during deletion of the range plus one more tr… (#3028)

2018-11-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 5291529 Adding zone disablement during

[GitHub] DaanHoogland commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…

2018-11-19 Thread GitBox
DaanHoogland commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-439809763 @borisstoyanov can you keep any @-mentions out of the description and put them in a first comment

[GitHub] DaanHoogland commented on issue #3033: ERROR when edit Project

2018-11-19 Thread GitBox
DaanHoogland commented on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439810338 Ilia, for UI issues can you add screenshots, please? This is an automated message

[GitHub] wido commented on issue #3037: kvm: when untagged vxlan is used, use the default guest/public bridge

2018-11-19 Thread GitBox
wido commented on issue #3037: kvm: when untagged vxlan is used, use the default guest/public bridge URL: https://github.com/apache/cloudstack/pull/3037#issuecomment-439812985 As far as I know VXLAN always requires a VNI, so how could you use this untagged?

[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234529165 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234529665 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234529885 ## File path:

[GitHub] DaanHoogland commented on issue #3035: Add snapshots-related limits returned in capabilties

2018-11-19 Thread GitBox
DaanHoogland commented on issue #3035: Add snapshots-related limits returned in capabilties URL: https://github.com/apache/cloudstack/issues/3035#issuecomment-439813693 added comments in the PR. I'd like to see how this is useful in the UI or in a script.

[GitHub] DaanHoogland commented on a change in pull request #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#discussion_r234531916 ## File path: packaging/systemd/cloudstack-management.service ## @@

[GitHub] izenk commented on issue #3033: ERROR when edit Project

2018-11-19 Thread GitBox
izenk commented on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439814526 @DaanHoogland sure ![screen shot 2018-11-19 at 11 47

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-19 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439816552 @rafaelweingartner , can you enter something of a PoC PR so we can discuss further? Or sugest changes to this one?

[GitHub] DaanHoogland commented on a change in pull request #2660: Macaddresses

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r234535369 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +51,4 @@ public final void

[GitHub] rhtyd commented on issue #3037: kvm: when untagged vxlan is used, use the default guest/public bridge

2018-11-19 Thread GitBox
rhtyd commented on issue #3037: kvm: when untagged vxlan is used, use the default guest/public bridge URL: https://github.com/apache/cloudstack/pull/3037#issuecomment-439822734 @wido same goes with VLAN, the issue is how we handle any `vxlan|vlan://untagged` for example for a public IP

[GitHub] GabrielBrascher commented on a change in pull request #2660: Macaddresses

2018-11-19 Thread GitBox
GabrielBrascher commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r234562291 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +51,4 @@ public final void

[GitHub] rhtyd opened a new pull request #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
rhtyd opened a new pull request #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038 Due to issue described in Surefix bug: https://issues.apache.org/jira/browse/SUREFIRE-1588 Debian-based users/developers can no longer

[GitHub] gmueller-ewerk commented on a change in pull request #3026: Enhance bypass vlan overlap check

2018-11-19 Thread GitBox
gmueller-ewerk commented on a change in pull request #3026: Enhance bypass vlan overlap check URL: https://github.com/apache/cloudstack/pull/3026#discussion_r234570827 ## File path:

[GitHub] rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439852134 @blueorangutan package This is an automated message from the

[GitHub] blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439852236 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439857103 Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2445

[GitHub] rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439857211 @blueorangutan package This is an automated message

[GitHub] blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439857482 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-19 Thread GitBox
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439860129 Sure I will This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439862808 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2446

[GitHub] rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
rhtyd commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439874050 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
blueorangutan commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439874237 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] svenvogel commented on a change in pull request #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
svenvogel commented on a change in pull request #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#discussion_r234601179 ## File path: packaging/systemd/cloudstack-management.service ## @@

[GitHub] DaanHoogland commented on a change in pull request #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
DaanHoogland commented on a change in pull request #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#discussion_r234603576 ## File path: packaging/systemd/cloudstack-management.service ## @@

[GitHub] DaanHoogland commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
DaanHoogland commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439880375 @rhtyd not sure if we need full testing but I'll package to get at least that part covered.

[GitHub] blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439880597 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439880578 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439880861 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439889322 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2447

[GitHub] blueorangutan commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439889488 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2448 This is an automated message from the

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439920856 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #2660: Macaddresses

2018-11-19 Thread GitBox
blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-439920917 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
DaanHoogland commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439921392 better not sorry @blueorangutan test

[GitHub] blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
blueorangutan commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439921622 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] svenvogel commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-19 Thread GitBox
svenvogel commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439934146 @DaanHoogland ca we merge it? what do you think?

[GitHub] andrijapanic commented on issue #3038: surefire: ignore system classloader to make tests run

2018-11-19 Thread GitBox
andrijapanic commented on issue #3038: surefire: ignore system classloader to make tests run URL: https://github.com/apache/cloudstack/pull/3038#issuecomment-439934683 LGTM tested by manually changing POM file and successfully built packages (4.11.2-RC5) on Ubuntu 18.04, OpenJDK

[GitHub] bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234734175 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java ##

[GitHub] bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234737322 ## File path: engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java

[GitHub] bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234734562 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java ##

[GitHub] bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-19 Thread GitBox
bwsw commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234736058 ## File path: engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java