[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-02-11 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-462337097 framework/managed-context uses slf4j and is not dependend on utils. This needs to be solved by 1. isolating logging in its own

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-02-08 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461787365 @blueorangutan test This is an automated message from the Apache

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-02-08 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461781633 @blueorangutan package This is an automated message from the

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-02-07 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461505256 used a addepted version of @rafaelweingartner's script above : ``` #!/bin/bash CLOUDSTACK_FOLDER="."

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-01-29 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458615431 @rafaelweingartner I saw you IM comment and will look into what a spring suit would mean for logging. more later

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-01-29 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458525484 ok, then let me urge to give this priority. We are using antiquated libraries, as in out of service -, out of support libraries

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-01-29 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458521892 > @rafaelweingartner I would like to merge this and build on it. > @DaanHoogland I have not had free time to work on these

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-01-29 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458521354 > I also do not see the benefits of this PR. It makes no sense not isolating dependencies and reducing surface area and this is

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-01-29 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458520776 > But, besides that, master is on freeze, and we are working to release 4.12. Therefore, this PR has to wait in one way or the

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-01-29 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-458476655 @rafaelweingartner I would like to merge this and build on it. I have not seen any follow up. can you expand or comply? /cc

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-19 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439816552 @rafaelweingartner , can you enter something of a PoC PR so we can discuss further? Or sugest changes to this one?

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439386896 so basically you are re-doing my work from #2276 but without reducing the surface area. I do not like it much so far.

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439378952 > Anyways, to upgrade the log4j is not as a Dantesc task as you are portraiting. I am almost done, and I have almost had no time

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439316964 Also, @rafaelweingartner, I will -1 a PR that 'just' upgrades a structurally changed dependency, if it fails to makes efforts to

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439316167 tl;dr you are not giving any argument to not use this strategy, you are only saying why this PoC is just a PoC. What you

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-15 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439025126 the travis build is successful but still reports an error here. I will extend this PoC somewhat to see what happened there.

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-15 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439024747 @rafaelweingartner, I have no idea why someone would not want to do this. It is a best practice and in my opinion a blocker to

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-14 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438705975 ok, you will fail, but I will be patient for another day. This is

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-14 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438702885 This is not a feature, @rafaelweingartner . It is a way to make the system a bit more maintainable and deal with technical debt.

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-14 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438613228 ok, apart from @rhtyd 's request for the indentation correction I will merge this as is and spend part of my live on following up

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-12 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438155012 hm, there where packages for the latest commit already. test had been run as well.

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-06 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-436326092 happy to work with you on what you need, @csquire . We do want to implement a large enough subset so all are served. ATM we have a

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-06 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-436303885 @csquire hearsay admittedly but apache logging folk say that log4j2 is better faster neater than slf4j and when we consolidated

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-02 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435416639 @rhtyd @rafaelweingartner @wido @swill @mike-tutkowski any comments?

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-02 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435304562 @blueorangutan test This is an automated message from the Apache

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-01 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435025739 @blueorangutan package This is an automated message from the