[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-12 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462753217 > still getting failures, but in a new place. I've attached logs @nathanejohnson that is good. At least

[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-12 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462749877 @blueorangutan test This is an automated

[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-12 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462738664 @blueorangutan package This is an automated

[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462429480 Updated the code with a _setup_ method and removed a variable that I left without mocking. Thanks for testing

[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462420138 Ping for review @kiwiflyer @nathanejohnson @DaanHoogland and others.