[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362555052 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362616782 Trillian test result (tid-2217) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 15361

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362554954 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362630952 Trillian test result (tid-2220) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362626521 Trillian test result (tid-2218) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 17253 seconds

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362547966 Packaging result: ?centos6 ?centos7 ?debian. JID-1688 This is an

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362550533 Packaging result: ?centos6 ?centos7 ?debian. JID-1689

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362550943 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run

[GitHub] rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362550910 @blueorangutan test matrix This is an automated message from the Apache Git

[GitHub] houthuis closed pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

2018-02-02 Thread GitBox
houthuis closed pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] houthuis opened a new pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

2018-02-02 Thread GitBox
houthuis opened a new pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382 added a check for network state when determining whether a new IP should be source NAT. this prevents

[GitHub] houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-02 Thread GitBox
houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-02 Thread GitBox
houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 ENVIRONMENT = XenServer Version : 6.2 , 7 ISSUE == Disabled Xenserver

[GitHub] houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-02 Thread GitBox
houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-02 Thread GitBox
houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 ENVIRONMENT = XenServer Version : 6.2 , 7 ISSUE == Disabled Xenserver

[GitHub] houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-02 Thread GitBox
houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's

2018-02-02 Thread GitBox
houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 ENVIRONMENT = XenServer Version : 6.2 , 7 ISSUE == Disabled Xenserver

[GitHub] DaanHoogland commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2018-02-02 Thread GitBox
DaanHoogland commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds URL: https://github.com/apache/cloudstack/pull/2244#discussion_r165599968 ## File path: core/src/main/java/com/cloud/storage/template/QCOW2Processor.java ##

[GitHub] rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362539915 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] DaanHoogland commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

2018-02-02 Thread GitBox
DaanHoogland commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-362529970 As @bwsw (wow a company involved) says, accounting is important and needs a lot

[GitHub] DaanHoogland commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2018-02-02 Thread GitBox
DaanHoogland commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds URL: https://github.com/apache/cloudstack/pull/2244#discussion_r165599968 ## File path: core/src/main/java/com/cloud/storage/template/QCOW2Processor.java ##

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

2018-02-02 Thread GitBox
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362540147 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd opened a new pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
rhtyd opened a new pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444 During deletion of role, set name to null. This fixes concurrent exception issue where previously it would rename the deleted role with a

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362544043 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

2018-02-02 Thread GitBox
rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362544096 Roles related tests pass: ``` Test to ensure 4 default roles cannot be deleted ... === TestName: