[GitHub] khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363510322 @rhtyd @rafaelweingartner @wido @DaanHoogland Since 4.11 is out can we get these PR going again?

[GitHub] khos2ow commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?

khos2ow commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ? URL: https://github.com/apache/cloudstack/pull/2398#issuecomment-363510373 @rhtyd @rafaelweingartner @wido @DaanHoogland Since 4.11 is out can we get these PR going again?

[GitHub] rafaelweingartner commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?

rafaelweingartner commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ? URL: https://github.com/apache/cloudstack/pull/2398#issuecomment-36351 All tests passed. I already reviewed and approved the proposed changes. I believe we need someone

[GitHub] DaanHoogland commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?

DaanHoogland commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ? URL: https://github.com/apache/cloudstack/pull/2398#issuecomment-363531208 hm, i gues it already had. merging This

[GitHub] DaanHoogland closed pull request #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?

DaanHoogland closed pull request #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ? URL: https://github.com/apache/cloudstack/pull/2398 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[cloudstack] branch 4.11 updated: CLOUDSTACK-10222: Clean snaphosts from primary storage when taking new (#2398)

This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 94776fb CLOUDSTACK-10222: Clean snaphosts from

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363124875 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362550533 Packaging result: ?centos6 ?centos7 ?debian. JID-1689

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363187630 Trillian test result (tid-2230) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363078786 @blueorangutan test This is an automated message from

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363078973 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362544043 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363383072 @blueorangutan package This is an automated message

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363519607 Well I already approved this PR. For me it is everything ok. It is even nicer that you provided more features and

[GitHub] rafaelweingartner commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?

rafaelweingartner commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ? URL: https://github.com/apache/cloudstack/pull/2398#issuecomment-36351 All tests passed. I already reviewed and approved the proposed changes. However, I believe we need

[GitHub] DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring

DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#discussion_r166404453 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring

DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#discussion_r166404068 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring

DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#discussion_r166403867 ## File path:

[GitHub] DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring

DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#discussion_r166377557 ## File path:

[GitHub] khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363510322 @rhtyd @rafaelweingartner @wido @DaanHoogland Since 4.11 is out can we get this PR going again?

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363510674 @rhtyd @rafaelweingartner Can we proceed with this PR if no other change required?

[GitHub] khos2ow commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ?

khos2ow commented on issue #2398: CLOUDSTACK-10222: Clean previous snaphosts from primary storage when ? URL: https://github.com/apache/cloudstack/pull/2398#issuecomment-363510373 @rhtyd @rafaelweingartner @wido @DaanHoogland Since 4.11 is out can we get this PR going again?

[GitHub] khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363526152 @rafaelweingartner oh yes. In the meantime I'm gonna do the package until someone runs the test.

[GitHub] khos2ow opened a new pull request #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

khos2ow opened a new pull request #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412 ? storage This is to bring PR #1830 back to life (since it was lost in time). We already have this fix in our prod

[GitHub] DaanHoogland commented on issue #2435: CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs ?

DaanHoogland commented on issue #2435: CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs ? URL: https://github.com/apache/cloudstack/pull/2435#issuecomment-363446096 @blueorangutan package This is an

[GitHub] nvazquez opened a new pull request #2447: Add retry logic to direct download and checksum, also refactoring

nvazquez opened a new pull request #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447 Add retrying logic on direct download and checksum validation. - Retry logic on hosts: Send download command on few hosts

[GitHub] blueorangutan commented on issue #2435: CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs ?

blueorangutan commented on issue #2435: CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs ? URL: https://github.com/apache/cloudstack/pull/2435#issuecomment-363446165 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363520439 I believe this one is still missing the automated testes to be executed.

[GitHub] DaanHoogland closed pull request #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

DaanHoogland closed pull request #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363531865 unfortunatlelily blueorangutanisn't human and kan'd ried throe spelletjes @blueorangutan package

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363383279 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-363385418 @DaanHoogland, @bwsw I have been trying to understand how to do this test

[GitHub] borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

borisstoyanov commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363383072 @blueorangutan package This is an automated message

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-363385418 @DaanHoogland, @bwsw I have been trying to understand how to do this test

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363545109 I'm -1 on it, we need a round of testing to confirm changes which I'll kick @blueorangutan package

[GitHub] blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

blueorangutan commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363553653 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363553859 what is your -1 based on @rhtyd ? This is an automated

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-363596780 @DaanHoogland, and @bwsw Finally I managed to understand how to create and

[GitHub] DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

DaanHoogland commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363553405 not sure why mine didn't work, retrying @blueorangutan package

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363552300 @rhtyd sure, go for it. I'm pretty sure it would be fine. This is

[GitHub] DaanHoogland closed pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

DaanHoogland closed pull request #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363554774 jenkins failed This is an automated message from the Apache

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363554843 rekicking jenkins This is an automated message from the

[GitHub] khos2ow opened a new pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow opened a new pull request #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433 - if there's a "branding" string in the POM version (e.g. `x.y.z.a-NAME[-SNAPSHOT]`), the branding name will be used in the final generated

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363545289 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

khos2ow commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-363535283 damn! typo!! This is an automated message

[GitHub] DaanHoogland closed pull request #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

DaanHoogland closed pull request #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2380 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring

DaanHoogland commented on a change in pull request #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#discussion_r166377235 ## File path:

[GitHub] ustcweizhou commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

ustcweizhou commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-363442962 you can use UserVmJoinDao instead of SQL.

[GitHub] DaanHoogland commented on issue #2436: Enable restart of redundant VPCs implementing Rolling Restart

DaanHoogland commented on issue #2436: Enable restart of redundant VPCs implementing Rolling Restart URL: https://github.com/apache/cloudstack/pull/2436#issuecomment-363445216 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2436: Enable restart of redundant VPCs implementing Rolling Restart

blueorangutan commented on issue #2436: Enable restart of redundant VPCs implementing Rolling Restart URL: https://github.com/apache/cloudstack/pull/2436#issuecomment-363445493 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland opened a new pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

DaanHoogland opened a new pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446 This is an automated message from the Apache Git Service. To

[GitHub] SowjanyaPatha commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del?

SowjanyaPatha commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del? URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-363673058 tag:MergeReady This is an automated

[GitHub] jayakarteek commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del?

jayakarteek commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del? URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-363673008 code LGTM This is an automated message

[GitHub] jahnaviboddu commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del?

jahnaviboddu commented on issue #2399: CLOUDSTACK-10223 Snapshots are not getting deleted when domain is del? URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-363670253 Test LGTM This is an automated message

[GitHub] marcaurele commented on a change in pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added

marcaurele commented on a change in pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446#discussion_r166526547 ## File path: pom.xml ## @@ -569,6 +569,22 @@ install + +

[GitHub] DaanHoogland closed pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null

DaanHoogland closed pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rhtyd opened a new pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null

rhtyd opened a new pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444 During deletion of role, set name to null. This fixes concurrent exception issue where previously it would rename the deleted role with a

[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null

blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-363430844 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

DaanHoogland commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-363431580 well, there is a lot of integration test code that could be done with a bunch

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-363436025 Well, here is a case that I have not solved with my self yet. The logic is