[GitHub] rhtyd commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

2018-02-15 Thread GitBox
rhtyd commented on issue #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab? URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-365865641 LGTM, merging. This is an automated message

[GitHub] rhtyd closed pull request #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab?

2018-02-15 Thread GitBox
rhtyd closed pull request #2450: CLOUDSTACK-10282: firewall rules operation should be done with ip6tab? URL: https://github.com/apache/cloudstack/pull/2450 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

2018-02-15 Thread GitBox
rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary? URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-365866150 Regression test LGTM, can you share your test results with swift @khos2ow and @pdube ?

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365860720 Packaging result: ?centos6 ?centos7 ?debian. JID-1716 This is

[GitHub] ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365868622 @DaanHoogland @rhtyd @fmaximus new changes pushed. will you please review?

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365857363 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
borisstoyanov commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365860772 @blueorangutan package This is an automated message from

[cloudstack] branch 4.11 updated: CLOUDSTACK-10282: ipv6 firewall rules operation should be done with ip6tables (#2450)

2018-02-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 97441a8 CLOUDSTACK-10282: ipv6 firewall rules

[GitHub] borisstoyanov commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
borisstoyanov commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365857200 Thanks @ernjvr, @blueorangutan package This is an

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365860973 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
borisstoyanov commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-366163752 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-366163877 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365880601 Packaging result: ?centos6 ?centos7 ?debian. JID-1717 This is

[GitHub] rhtyd closed pull request #2432: CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py

2018-02-15 Thread GitBox
rhtyd closed pull request #2432: CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py URL: https://github.com/apache/cloudstack/pull/2432 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rhtyd commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

2018-02-15 Thread GitBox
rhtyd commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365927051 Screenshots? This is an automated message from the Apache

[GitHub] DaanHoogland commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
DaanHoogland commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-365874056 @blueorangutan package This is an automated

[GitHub] borisstoyanov commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
borisstoyanov commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365881363 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-365898296 Packaging result: ?centos6 ?centos7 ?debian. JID-1718

[cloudstack] 01/01: Merge branch '4.11'

2018-02-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 39415b704448a1adc7127327f1a70814645924a3 Merge: f96398c 97441a8 Author: Rohit Yadav

[GitHub] mrunalinikankariya opened a new pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

2018-02-15 Thread GitBox
mrunalinikankariya opened a new pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455 In the current implementation, both the local-hostname and instance-id in the metadata are pointing to same thing

[cloudstack] branch master updated: CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py (#2432)

2018-02-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 6233a77 CLOUDSTACK-10294: PEP-8 fixes and

[GitHub] nvazquez commented on issue #2411: CLOUDSTACK-10238: Fix for metalink support on SSVM agents

2018-02-15 Thread GitBox
nvazquez commented on issue #2411: CLOUDSTACK-10238: Fix for metalink support on SSVM agents URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-365891078 It is @borisstoyanov, it is then replaced for both Direct Download and SSVM on #2447

[GitHub] blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-365898637 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
borisstoyanov commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-365898613 @blueorangutan package This is an automated

[GitHub] rafaelweingartner opened a new pull request #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

2018-02-15 Thread GitBox
rafaelweingartner opened a new pull request #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456 The ACL rules editing/addition page is not user-friendly. Users are not able to see in a single view all of the detail of the ACL

[GitHub] blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

2018-02-15 Thread GitBox
blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-365904032 Packaging result: ?centos6 ?centos7 ?debian. JID-1719

[GitHub] rhtyd commented on issue #2432: KVM: PEP-8 fixes and enhancements to security_group.py

2018-02-15 Thread GitBox
rhtyd commented on issue #2432: KVM: PEP-8 fixes and enhancements to security_group.py URL: https://github.com/apache/cloudstack/pull/2432#issuecomment-365873189 @wido can you add a JIRA id for this? This is an automated

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-365881625 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] nvazquez commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

2018-02-15 Thread GitBox
nvazquez commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-365919017 @blueorangutan test This is an automated

[GitHub] blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

2018-02-15 Thread GitBox
blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-365919109 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] nvazquez commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template

2018-02-15 Thread GitBox
nvazquez commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed registered template URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-365892520 Thanks @borisstoyanov @DaanHoogland for reviewing, should we re run tests?

[GitHub] wido commented on issue #2432: CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py

2018-02-15 Thread GitBox
wido commented on issue #2432: CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py URL: https://github.com/apache/cloudstack/pull/2432#issuecomment-365922921 Done @rhtyd , updated the title with the issue: https://issues.apache.org/jira/browse/CLOUDSTACK-10294

[cloudstack] branch master updated (f96398c -> 39415b7)

2018-02-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from f96398c Merge branch '4.11' add 97441a8 CLOUDSTACK-10282: ipv6 firewall rules operation should be done

[GitHub] blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-365874209 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] nvazquez commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

2018-02-15 Thread GitBox
nvazquez commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-365892193 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

2018-02-15 Thread GitBox
blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-365892333 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put it to show people how the page will become.

[GitHub] rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put there it to show people how the page will become.

[GitHub] mrunalinikankariya commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

2018-02-15 Thread GitBox
mrunalinikankariya commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds URL: https://github.com/apache/cloudstack/pull/2244#issuecomment-365966078 ping @DaanHoogland This is an automated

[GitHub] mrunalinikankariya commented on issue #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

2018-02-15 Thread GitBox
mrunalinikankariya commented on issue #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco? URL: https://github.com/apache/cloudstack/pull/2455#issuecomment-365942177 travis build failure doesn't seem to be related to changes. Getting timeout error

[GitHub] DaanHoogland commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

2018-02-15 Thread GitBox
DaanHoogland commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-365976445 this closes #2411 this closes #2423 this closes #2447

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-366023509 After this script is merged, we will have to make sure that everyone creating new scripts to alter tables must use the so

[GitHub] rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put it there to show people how the page will look like..

[GitHub] dmytro-shevchenko opened a new pull request #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates

2018-02-15 Thread GitBox
dmytro-shevchenko opened a new pull request #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates URL: https://github.com/apache/cloudstack/pull/2457 Currently when new VM created, password property always set to 'password' even if it was auto-generated. Because of

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-366009336 @DaanHoogland I separated the code changes from formatting one as your suggestion. I think it is

[GitHub] rhtyd commented on a change in pull request #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
rhtyd commented on a change in pull request #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#discussion_r168577563 ## File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql ## @@ -19,8 +19,54 @@ --

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-366021803 Trillian test result (tid-2262) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-365949680 Yes, it is a screen shot. I just put it there to show people how the page will become.

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-366023509 After this script is merger, we will have to enforce that everyone creating scripts to alter tables to use the so called

[GitHub] rafaelweingartner commented on a change in pull request #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-02-15 Thread GitBox
rafaelweingartner commented on a change in pull request #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#discussion_r168579126 ## File path: engine/schema/resources/META-INF/db/schema-41000to41100.sql ## @@ -19,8

[GitHub] blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring

2018-02-15 Thread GitBox
blueorangutan commented on issue #2447: Add retry logic to direct download and checksum, also refactoring URL: https://github.com/apache/cloudstack/pull/2447#issuecomment-366116431 Packaging result: ?centos6 ?centos7 ?debian. JID-1720