[cloudstack] branch master updated: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage (#2425)

2018-03-07 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new f2efbce [CLOUDSTACK-10240] ACS cannot

[GitHub] rafaelweingartner closed pull request #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-07 Thread GitBox
rafaelweingartner closed pull request #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

2018-03-07 Thread GitBox
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-371247759 Trillian test result (tid-2329) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37940 seconds

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371276965 @DaanHoogland @rafaelweingartner can you take a look at the cleanup commit? I think I leave it as this and don't squash them,

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371280867 Everything seems to be ok. I would leave the commits separated to facilitate reviews.

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371244156 If we have no objections I will be merging this one latter today.

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371281372 Trillian test result (tid-2335) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26447

[GitHub] rafaelweingartner commented on issue #2470: [CLOUDSTACK-10197] Update DisplayText of XenServer tools ISO entry in the database when it already exists

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2470: [CLOUDSTACK-10197] Update DisplayText of XenServer tools ISO entry in the database when it already exists URL: https://github.com/apache/cloudstack/pull/2470#issuecomment-371271287 @DaanHoogland this one seems to be ready. Would you like to wait

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-371314898 @pdion891 do you have a feedback regarding the result of tests conducted by you guys? I have used this in

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371320260 Trillian test result (tid-2334) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34262

[GitHub] rafaelweingartner commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-371314345 @Slair1 can you take a look into travis failures?

[GitHub] rafaelweingartner commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics URL: https://github.com/apache/cloudstack/pull/2476#issuecomment-371314177 It seems that everything is ok here, can we proceed with the merge?

[GitHub] ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-07 Thread GitBox
ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371399237 Thanks for the tip @DaanHoogland. Understood @rafaelweingartner. Yes @ustcweizhou, I tested with both mysql and java. In my java test

[GitHub] borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371407405 [system-vm.log](https://github.com/apache/cloudstack/files/1792215/system-vm.log) Trillian id: pr2477-t2339-xenserver-71

[GitHub] borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371407405 [system-vm.log](https://github.com/apache/cloudstack/files/1792215/system-vm.log)

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371086993 Packaging result: ?centos6 ?centos7 ?debian. JID-1763 This

[GitHub] borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371076646 @blueorangutan test matrix This is an automated message from the

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371069607 yes @khos2ow , please replace either one or the other or vice versa. don't forget the test class as well, if you will.

[GitHub] borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371076646 @blueorangutan test matrix This is an automated message from the

[GitHub] blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks.

2018-03-07 Thread GitBox
blueorangutan commented on issue #2477: Smaller systemvm images using sparse disks. URL: https://github.com/apache/cloudstack/pull/2477#issuecomment-371076827 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371077396 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371089577 Thanks @DaanHoogland! This is an

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

2018-03-07 Thread GitBox
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-371056494 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-371056368 @blueorangutan test centos7 xenserver-71 This is an automated message from the

[GitHub] DaanHoogland commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues

2018-03-07 Thread GitBox
DaanHoogland commented on issue #2474: CLOUDSTACK-10246 Fix Host HA and VM HA issues URL: https://github.com/apache/cloudstack/pull/2474#issuecomment-371067952 @Slair1 are you going to modularise the handleDisconnectWithInvestigation method?

[GitHub] DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-07 Thread GitBox
DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371068913 @rafaelweingartner , yes you can. It seems to be a timing issue. the host does not have a state needed

[GitHub] borisstoyanov commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371077099 @blueorangutan package This is an automated message from the

[GitHub] ustcweizhou commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-07 Thread GitBox
ustcweizhou commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371149120 @ernjvr have you tested it ? If you import this sql file into mysql or mariadb, it might work. However, In my experience,

[GitHub] ustcweizhou opened a new pull request #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database

2018-03-07 Thread GitBox
ustcweizhou opened a new pull request #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database URL: https://github.com/apache/cloudstack/pull/2479 @rhtyd @DaanHoogland @rafaelweingartner @blueorangutan This

[GitHub] ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-07 Thread GitBox
ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371106986 Hi Rafael, guys. Any resolution regarding this PR? Perhaps this PR as an interim solution until someone has an opportunity to do a

[GitHub] rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-371117317 @borisroman are those errors/failures ok?

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-07 Thread GitBox
DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371131289 @ernjvr I think you want to address @rafaelweingartner instead of Rafael. Better change on reaction.

[GitHub] borisstoyanov commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-07 Thread GitBox
borisstoyanov commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-371118121 Let me run smoke tests again, but I think we've seen them quite frequently on random PRs.

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-07 Thread GitBox
blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-371118309 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to

[GitHub] rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-371118779 ok, thanks. @DaanHoogland have you approaved this PR?

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-371132517 @ernjvr I would go with this one. It does not mean that I like this type of solution. It is a palliative one, and we

[GitHub] rhtyd commented on a change in pull request #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database

2018-03-07 Thread GitBox
rhtyd commented on a change in pull request #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database URL: https://github.com/apache/cloudstack/pull/2479#discussion_r172878095 ## File path: engine/schema/pom.xml ## @@ -48,5 +48,10 @@

[GitHub] rhtyd commented on a change in pull request #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database

2018-03-07 Thread GitBox
rhtyd commented on a change in pull request #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database URL: https://github.com/apache/cloudstack/pull/2479#discussion_r172878721 ## File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java