[GitHub] blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

2018-04-05 Thread GitBox
blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type” URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-379077062 Trillian test result (tid-2463) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt

[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378879184 @DaanHoogland just a hint, if you use the keyword "closes issue" github will close the issue after merge of the PR.

[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378879184 @DaanHoogland just a hint, if you use the keyword "closes " github will close the issue after merge of the PR.

[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-37384 target (branch) should be changed to 4.11 before merge This is an automated

[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-37384 target (branch) should be changed to 4.11 This is an automated message from

[GitHub] rafaelweingartner commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378901994 @borisstoyanov here we also have that same `test_04_restart_network_wo_cleanup` failure.

[GitHub] blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage

2018-04-05 Thread GitBox
blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-378910671 Trillian test result (tid-2452) Environment: vmware-65 (x2),

[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378869034 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1873 This is an

[GitHub] blueorangutan commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
blueorangutan commented on issue #2535: Create an easy way to enable Java remote Debug for ACS URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378910170 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner opened a new pull request #2535: Create an easy way to enable the Java remote Debug for ACS

2018-04-05 Thread GitBox
rafaelweingartner opened a new pull request #2535: Create an easy way to enable the Java remote Debug for ACS URL: https://github.com/apache/cloudstack/pull/2535 ## Description The idea is to create a property in /etc/defaults/cloudstack-management that can be enabled/disabled

[GitHub] blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found

2018-04-05 Thread GitBox
blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378900724 Trillian test result (tid-2456) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt

[GitHub] rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop) URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-378890282 I looked into it. The test failed because the uptime of the VR is less than 3 minutes?

[GitHub] blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

2018-04-05 Thread GitBox
blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378851349 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke

[GitHub] borisstoyanov commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

2018-04-05 Thread GitBox
borisstoyanov commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378851222 @blueorangutan test centos7 xenserver-71

[GitHub] DaanHoogland opened a new pull request #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland opened a new pull request #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534 see #2533 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing

[GitHub] borisstoyanov commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

2018-04-05 Thread GitBox
borisstoyanov commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop) URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-378851971 @rafaelweingartner I think this one is suspicious: ```

[GitHub] DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24 URL: https://github.com/apache/cloudstack/issues/2533#issuecomment-378861480 @sgoeminn I fixed the c error but @PaulAngus still has a point about documentation. see #2534

[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378861363 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378928297 simple github rebase won't work This is an automated message from the

[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378928583 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland closed pull request #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland closed pull request #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378930603 Yeah thanks @rafaelweingartner . I just recreated copying those few lines. Won't mess the end result any way. see #2536

[GitHub] blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

2018-04-05 Thread GitBox
blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-378933821 Trillian test result (tid-2461) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt

[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378927806 @rhtyd Changes break or may break? I have tested this. At least all of the functions I used are

[GitHub] rafaelweingartner commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2535: Create an easy way to enable Java remote Debug for ACS URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378929239 Do you guys think that we need to document this somewhere? Or is it ok to leave it as is?

[GitHub] DaanHoogland commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2535: Create an easy way to enable Java remote Debug for ACS URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378936551 nice, I would say put it on the wiki in th dev 1o1 tree. We don't have dev docs, persé

[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378943642 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1875 This is an

[GitHub] blueorangutan commented on issue #2536: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2536: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2536#issuecomment-378943644 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1876 This is an

[GitHub] DaanHoogland opened a new pull request #2536: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland opened a new pull request #2536: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2536 closes issue #2533 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause

[GitHub] blueorangutan commented on issue #2536: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2536: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2536#issuecomment-378930297 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-378937724 @borisstoyanov these errors do not seem to be caused by changes introduced here.

[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378927806 @rhtyd Changes break or may break? I have tested this. At least all of the functions I used are

[GitHub] DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24 URL: https://github.com/apache/cloudstack/issues/2533#issuecomment-378861480 @sgoeminn I fixed the c error but @PaulAngus still has a point about documentation. see #2534 reapplied for

[GitHub] rafaelweingartner commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2535: Create an easy way to enable Java remote Debug for ACS URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378944292 Done. Shall we execute tests before merging?

[GitHub] blueorangutan commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
blueorangutan commented on issue #2535: Create an easy way to enable Java remote Debug for ACS URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378917314 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1874

[GitHub] rafaelweingartner commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2534: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378930041 @DaanHoogland did this before. You will need to do the following: * get the branch `DaanHoogland-patch-1` * `reset --hard

[GitHub] rafaelweingartner commented on a change in pull request #2499: Updates to capacity management

2018-04-05 Thread GitBox
rafaelweingartner commented on a change in pull request #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#discussion_r179507086 ## File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java ## @@ -1833,67 +1839,88 @@

[GitHub] ernjvr opened a new issue #2537: Fix configuration file copying bugs during Upgrade from 4.x to 4.11

2018-04-05 Thread GitBox
ernjvr opened a new issue #2537: Fix configuration file copying bugs during Upgrade from 4.x to 4.11 URL: https://github.com/apache/cloudstack/issues/2537 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ packaging ~~~ # CLOUDSTACK

[GitHub] rafaelweingartner commented on a change in pull request #2499: Updates to capacity management

2018-04-05 Thread GitBox
rafaelweingartner commented on a change in pull request #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#discussion_r179507086 ## File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java ## @@ -1833,67 +1839,88 @@

[GitHub] rhtyd commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

2018-04-05 Thread GitBox
rhtyd commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-379009668 Looks like there is an outstanding/related issue to CA management, I'll have a look next week (on holidays now).

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

2018-04-05 Thread GitBox
blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-379007673 Trillian test result (tid-2459) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] mike-tutkowski commented on a change in pull request #2499: Updates to capacity management

2018-04-05 Thread GitBox
mike-tutkowski commented on a change in pull request #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#discussion_r179547128 ## File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java ## @@ -1833,67 +1839,88 @@

[GitHub] blueorangutan commented on issue #2501: Only perform certain actions with managed storage if the VM is s…

2018-04-05 Thread GitBox
blueorangutan commented on issue #2501: Only perform certain actions with managed storage if the VM is s… URL: https://github.com/apache/cloudstack/pull/2501#issuecomment-37900 Trillian test result (tid-2457) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7