[GitHub] mike-tutkowski closed pull request #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…

2018-08-10 Thread GitBox
mike-tutkowski closed pull request #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to… URL: https://github.com/apache/cloudstack/pull/2776 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[cloudstack] 01/01: Merge pull request #2776 from mike-tutkowski/vol-on-managed-storage

2018-08-10 Thread mtutkowski
This is an automated email from the ASF dual-hosted git repository. mtutkowski pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit e4ec123f62408856a9138ed3677385aceaff168f Merge: 461c4ad ab83c19 Author: Mike Tutkowski AuthorDate: Fri Aug 10

[cloudstack] branch 4.11 updated (461c4ad -> e4ec123)

2018-08-10 Thread mtutkowski
This is an automated email from the ASF dual-hosted git repository. mtutkowski pushed a change to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 461c4ad vmware: reboot VR after mac updates (#2794) add ab83c19 Changed the implementation of

[GitHub] mike-tutkowski commented on issue #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…

2018-08-10 Thread GitBox
mike-tutkowski commented on issue #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to… URL: https://github.com/apache/cloudstack/pull/2776#issuecomment-412206657 Two LGTMs and tests look good. Merging this into 4.11.

[GitHub] mike-tutkowski commented on issue #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…

2018-08-10 Thread GitBox
mike-tutkowski commented on issue #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to… URL: https://github.com/apache/cloudstack/pull/2776#issuecomment-412206882 @DaanHoogland Do you know what process I should follow to merge this forward into master?

[GitHub] rafaelweingartner commented on issue #2787: Fix wizards (new instance and new zone) div width problem in Chrome

2018-08-10 Thread GitBox
rafaelweingartner commented on issue #2787: Fix wizards (new instance and new zone) div width problem in Chrome URL: https://github.com/apache/cloudstack/pull/2787#issuecomment-412111647 @GabrielBrascher thanks! I will close this one then. I think we need more debugging to find and fix

[GitHub] rafaelweingartner closed pull request #2787: Fix wizards (new instance and new zone) div width problem in Chrome

2018-08-10 Thread GitBox
rafaelweingartner closed pull request #2787: Fix wizards (new instance and new zone) div width problem in Chrome URL: https://github.com/apache/cloudstack/pull/2787 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rafaelweingartner opened a new pull request #2798: Fix Div overlay problem when PopUp modal with error message is closed

2018-08-10 Thread GitBox
rafaelweingartner opened a new pull request #2798: Fix Div overlay problem when PopUp modal with error message is closed URL: https://github.com/apache/cloudstack/pull/2798 ## Description The error fixed by this PR happens when we have a Pop-up modal with an error message in the

[GitHub] mike-tutkowski commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method

2018-08-10 Thread GitBox
mike-tutkowski commented on issue #2761: Add managed storage pool constraints to MigrateWithVolume API method URL: https://github.com/apache/cloudstack/pull/2761#issuecomment-412125942 @rafaelweingartner How are we doing here? It looks like the code is in a good state. Do we need to kick

[GitHub] rhtyd commented on issue #2794: vmware: reboot VR after mac updates

2018-08-10 Thread GitBox
rhtyd commented on issue #2794: vmware: reboot VR after mac updates URL: https://github.com/apache/cloudstack/pull/2794#issuecomment-412001870 The fix was tested on a vmware 5.5u3 prod env which fixed the issue. Merging this based on reviews and tests, @resmo if you do test it please keep

[GitHub] rhtyd closed pull request #2794: vmware: reboot VR after mac updates

2018-08-10 Thread GitBox
rhtyd closed pull request #2794: vmware: reboot VR after mac updates URL: https://github.com/apache/cloudstack/pull/2794 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[cloudstack] branch 4.11 updated (ecb44a5 -> 461c4ad)

2018-08-10 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ecb44a5 ui: add height sizing to detail view so that it renders all detail items in the list (#2790) add

[GitHub] resmo commented on issue #2794: vmware: reboot VR after mac updates

2018-08-10 Thread GitBox
resmo commented on issue #2794: vmware: reboot VR after mac updates URL: https://github.com/apache/cloudstack/pull/2794#issuecomment-412016531 @rhtyd ok :+1: This is an automated message from the Apache Git Service. To

[GitHub] rhtyd commented on issue #2794: vmware: reboot VR after mac updates

2018-08-10 Thread GitBox
rhtyd commented on issue #2794: vmware: reboot VR after mac updates URL: https://github.com/apache/cloudstack/pull/2794#issuecomment-411995480 Code as in 4.11.1 does not reboot the VR @resmo. Can you help it? Results from vmware 6.5 lgtm.

[GitHub] rhtyd edited a comment on issue #2794: vmware: reboot VR after mac updates

2018-08-10 Thread GitBox
rhtyd edited a comment on issue #2794: vmware: reboot VR after mac updates URL: https://github.com/apache/cloudstack/pull/2794#issuecomment-411995480 Code as in 4.11.1 does not reboot the VR @resmo. Can you help test it? Results from vmware 6.5 lgtm.

[GitHub] rafaelweingartner closed pull request #2786: Fix alert message in VM creation wizard

2018-08-10 Thread GitBox
rafaelweingartner closed pull request #2786: Fix alert message in VM creation wizard URL: https://github.com/apache/cloudstack/pull/2786 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[cloudstack] branch master updated: Fix alert message in VM creation wizard (#2786)

2018-08-10 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 96d80b1 Fix alert message in VM creation

[GitHub] resmo opened a new issue #2797: updatePod does not update start/end IPs

2018-08-10 Thread GitBox
resmo opened a new issue #2797: updatePod does not update start/end IPs URL: https://github.com/apache/cloudstack/issues/2797 I noticed an API break in 4.11 in which updatePod does not update the start and end IPs. Also see #2735 # ISSUE TYPE * Bug Report

[GitHub] GabrielBrascher commented on issue #2787: Fix wizards (new instance and new zone) div width problem in Chrome

2018-08-10 Thread GitBox
GabrielBrascher commented on issue #2787: Fix wizards (new instance and new zone) div width problem in Chrome URL: https://github.com/apache/cloudstack/pull/2787#issuecomment-412090150 @rafaelweingartner when it worked I was with a different master (my mistake). Now, with the current

[GitHub] GabrielBrascher edited a comment on issue #2787: Fix wizards (new instance and new zone) div width problem in Chrome

2018-08-10 Thread GitBox
GabrielBrascher edited a comment on issue #2787: Fix wizards (new instance and new zone) div width problem in Chrome URL: https://github.com/apache/cloudstack/pull/2787#issuecomment-412090150 @rafaelweingartner when it worked I was with a different master (my mistake). Now, with the