[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439316167 tl;dr you are not giving any argument to not use this strategy, you are only saying why this PoC is just a PoC. What you are

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439316964 Also, @rafaelweingartner, I will -1 a PR that 'just' upgrades a structurally changed dependency, if it fails to makes efforts to is

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439358005 @blueorangutan package This is an automated message from the Apache Git Service. To respond

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439358150 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439359447 > Also, @rafaelweingartner, I will -1 a PR that 'just' upgrades a structurally changed dependency, if it fails to makes effort

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439362882 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2442 This is an automated message fro

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439363337 @blueorangutan test matrix This is an automated message from the Apache Git Service. To res

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439363496 @dhlaluku a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -

[GitHub] rhtyd commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…

2018-11-16 Thread GitBox
rhtyd commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-439364518 @PaulAngus are you lgtm on this? This is an aut

[GitHub] rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable

2018-11-16 Thread GitBox
rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439364967 @svenvogel please rebase against 4.11, or if it's difficult you can try this: - note down the shas of the two

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439375014 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439374864 @blueorangutan package This is an automated message from the Apache Git Service. To respond

[GitHub] DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439378952 > Anyways, to upgrade the log4j is not as a Dantesc task as you are portraiting. I am almost done, and I have almost had no

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439378952 > Anyways, to upgrade the log4j is not as a Dantesc task as you are portraiting. I am almost done, and I have almost had no time to

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439379349 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2443 This is an automated message fro

[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439380086 > If you unify the log framework usage as well, I am open to your solution. That is actually what I am doing. That is why it

[GitHub] rafaelweingartner edited a comment on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
rafaelweingartner edited a comment on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439380086 > If you unify the log framework usage as well, I am open to your solution. That is actually what I am doing. Tha

[GitHub] izenk commented on issue #3033: ERROR when edit Project

2018-11-16 Thread GitBox
izenk commented on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385112 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. ---

[GitHub] izenk commented on issue #3033: ERROR when edit Project

2018-11-16 Thread GitBox
izenk commented on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385531 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. ---

[GitHub] PaulAngus commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…

2018-11-16 Thread GitBox
PaulAngus commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-439385476 Yes LGTM This is an automated message from

[GitHub] izenk removed a comment on issue #3033: ERROR when edit Project

2018-11-16 Thread GitBox
izenk removed a comment on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385112 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. ---

[GitHub] izenk removed a comment on issue #3033: ERROR when edit Project

2018-11-16 Thread GitBox
izenk removed a comment on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385531 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. ---

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-16 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439386896 so basically you are re-doing my work from #2276 but without reducing the surface area. I do not like it much so far.

[GitHub] dhlaluku commented on a change in pull request #2848: Vmware offline migration

2018-11-16 Thread GitBox
dhlaluku commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r234222170 ## File path: core/src/main/java/com/cloud/agent/api/UnregisterVMCommand.java ## @@ -22,14 +22,19 @@ public class Unregi

[GitHub] DaanHoogland closed pull request #1662: Fix bug juniper srx

2018-11-16 Thread GitBox
DaanHoogland closed pull request #1662: Fix bug juniper srx URL: https://github.com/apache/cloudstack/pull/1662 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] DaanHoogland commented on issue #1662: Fix bug juniper srx

2018-11-16 Thread GitBox
DaanHoogland commented on issue #1662: Fix bug juniper srx URL: https://github.com/apache/cloudstack/pull/1662#issuecomment-439442481 code in here seems to be applied through other means on master, closing This is an automated

[GitHub] DaanHoogland closed pull request #1148: Update JuniperSrxResource.java

2018-11-16 Thread GitBox
DaanHoogland closed pull request #1148: Update JuniperSrxResource.java URL: https://github.com/apache/cloudstack/pull/1148 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] DaanHoogland commented on issue #1148: Update JuniperSrxResource.java

2018-11-16 Thread GitBox
DaanHoogland commented on issue #1148: Update JuniperSrxResource.java URL: https://github.com/apache/cloudstack/pull/1148#issuecomment-439442981 this fix was added to master by means of another commit, closing This is an aut

[GitHub] bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two more device name patterns to valid bridge slaves (lo* and dummy*)

2018-11-16 Thread GitBox
bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two more device name patterns to valid bridge slaves (lo* and dummy*) URL: https://github.com/apache/cloudstack/pull/3000#discussion_r234264619 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hyp

[GitHub] bwsw opened a new issue #3035: Add snapshots-related limits returned in capabilties

2018-11-16 Thread GitBox
bwsw opened a new issue #3035: Add snapshots-related limits returned in capabilties URL: https://github.com/apache/cloudstack/issues/3035 # ISSUE TYPE * Feature Idea # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.

[GitHub] giorgiomassar8 opened a new issue #2611: Ceph RBD primary storage fails connection and renders node unusable

2018-11-16 Thread GitBox
giorgiomassar8 opened a new issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611 # ISSUE TYPE * Bug Report # COMPONENT NAME Cloudstack agent # CLOUDSTACK VERSIO

[GitHub] kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

2018-11-16 Thread GitBox
kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-439511872 So working with a user, it does appear that the original issue outlined by @giorgiomassar8 is different from

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439516719 Trillian test result (tid-3185) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31331 seconds Marvin logs

[GitHub] kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

2018-11-16 Thread GitBox
kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-439517015 ![rbd](https://user-images.githubusercontent.com/17278194/48645544-97c8d180-e9ab-11e8-846b-0d52191583d1.p

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439525637 Trillian test result (tid-3183) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33465 seconds Marvin l

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439526508 @blueorangutan centos7 vmware-65 This is an automated message from the Apache Git Service.

[GitHub] bwsw opened a new pull request #3036: Implemented capabilities for snapshots and vm snapshots.

2018-11-16 Thread GitBox
bwsw opened a new pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036 ## Description Implemented additional capabilities: ``` disksnapshotsmaxdaily = 6 disksnapshotsmaxhourly = 1 disksnap

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439591627 @blueorangutan test centos7 vmware-65 This is an automated message from the Apache Git Serv

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-16 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439591656 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests --