[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499050230 @ustcweizhou , I am not sure. Would it make sense to ever set it to true? usually the source nat address is the one automatically added. Not sure if the use-case where the next one is specifically for source nat as well is really useful. I have been thinking about this kind of solution as well. Of course we then need to handle the value as well; This is somewhat I meant with "refactoring the way IpAddressManager works". Another solution I was thinking of is to check whether there already is an address on the interface and first add an extra one if there is non yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-499041866 Yes, @svanharmelen. I agree a real live environment behaves different, but the premise is that adding a static NAT address to an unimplemented network would not work anyway as the IP would be used for source-NAT. Hence the solution in #3125 containing the line https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java#L1433 . It may be that this fix would have only be needed on some hypervisors/network configurations in which case it is only half a fix. Updating offerings is a porr solution as you say, unless we do it in an automated way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-498583398 @svanharmelen I had a discussion about the problem. there are two possible fixes but the underlying problem will remain in both cases. 1. start the network with a persistent offering and make sure you wait till it started before configuring further. as this is an automated test in a simulator there might be issues with timing which also might have caused the test to pass earlier while no real network traffic was possible, before (in theory, not confirmed!). 2. implement a global configuration item that disables the check for 'allocated' vs. 'implemented' state, which will allow the old behaviour. This will fix your automarted test in simulator but most probably won't work in real hypervisors. Can you test solution 1? I think it is more viable in production environments than solution 2. of course there is a third solution, refactoring the way IpAddressManager works, but this will require the most time. I cannot even start planning that. /cc @rhtyd @PaulAngus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-496243317 @svanharmelen, /me discussing a solution. will keep you informed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-495195228 np, I hope we get to a solution that serves both use cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-495175338 @svanharmelen did you try that workaround? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-492582818 ok, if this workaround doesn't work, we'll have to tag ipadresses with their intended usage somehow in order to know which are for static and which for (one) for source NATting. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-492150325 @svanharmelen i had a look at several solution paths and came across the old persistent flag. Is it feasible for you to use a network offering with the persistent flag on? It will be implemented even without instances. I realise this may come down to terraform's requirements, but if it is only a test-bed requirement you have, this may work around the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491200103 https://github.com/apache/cloudstack/pull/3125 is a fix which has this (for undesired) result. Not sure which way to go with this, yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491189134 found https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java#L1433 that is the root of your regression. /cc @rhtyd @DagSonsteboSB This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491185836 i assumed ```associate ipaddress networkid=5edca120-c785-441c-88c3-bad2565f5ebb``` and get the same result indeed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491178175 @svanharmelen can you add the API you use here (if you don't use the UI), please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491174229 tnx @svanharmelen I will try to reproduce on master to have a look see @GabrielBrascher @wido I know there has been some networking stuff going into 4.12. Would that explain this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-491082200 tnx @svanharmelen I will try to reproduce on master to have a look see This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services