[GitHub] [cloudstack] weizhouapache commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint

2020-03-25 Thread GitBox
weizhouapache commented on issue #3986: Change listVpcOfferings endpoint and 
createVpcOffering endpoint
URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-603755062
 
 
   > @weizhouapache i agree that offerings should not be editable as they can 
be in use, but what is the harm in adding the offering to the create API?
   
   @DaanHoogland  I am ok with adding router offering to createVpcOffering, 
similar as createNetworkOffering.
   
   However, the network/vpc will be shutdown if we change a network/vpc to 
another offering. It would be nice to create a new VR before we destroy current 
running VR, like @rhtyd did when restart Network/vpc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint

2020-03-24 Thread GitBox
weizhouapache commented on issue #3986: Change listVpcOfferings endpoint and 
createVpcOffering endpoint
URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-603529965
 
 
   @radu-stefanache all service/disk/network/vpc offerings are not editable 
(except name and display text). maybe you can research on other solutions. for 
example, add "router offering" to vpc as a new field, or update vpc to another 
offering (similar as update network offering).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services