[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

2018-02-09 Thread GitBox 
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r167214312
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -468,11 +468,10 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
+boolean VRAddedToNuage = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   ok, now i hate myself but this one should be called 'vrAddedToNuage'...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

2018-02-07 Thread GitBox 
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166688501
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   How about when more then one provider type is used in an install? Can we 
guarantee this call is only called when? either the name 
isUpgradeNetworkOffering is deceiving or the test is incomplete. Is this meant 
to be a 'only if migrating from VR to nuage implementation' check?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

2018-02-07 Thread GitBox 
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166639544
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   @sgoeminn how about this question?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update in a nuage network

2018-02-05 Thread GitBox 
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166047276
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   isn't it possible that the old offering had a virtual router as well? it 
seems to me that only oldOffering.equals(newOffering) is a proper test here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update to a nuage network of?

2018-02-05 Thread GitBox 
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update to a nuage network of?
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166015553
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
 ##
 @@ -470,14 +468,14 @@ public void reserve(NicProfile nic, Network network, 
VirtualMachineProfile vm, D
 HostVO nuageVspHost = 
_nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
 VspNetwork vspNetwork = 
_nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(), 
network);
 
-if (vm.getType() == VirtualMachine.Type.DomainRouter && 
vspNetwork.getVirtualRouterIp().equals("null")) {
+boolean isUpgradeNetworkOffering = vm.getType() == 
VirtualMachine.Type.DomainRouter && vspNetwork.getVirtualRouterIp()
 
 Review comment:
   please explain; if the vm is a router and the network has no ip, then we are 
upgrading a network offering? I am missing the logic.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix for forced network update to a nuage network of?

2018-02-05 Thread GitBox 
DaanHoogland commented on a change in pull request #2445: CLOUDSTACK-10218: fix 
for forced network update to a nuage network of?
URL: https://github.com/apache/cloudstack/pull/2445#discussion_r166013816
 
 

 ##
 File path: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java
 ##
 @@ -119,8 +121,8 @@
 
 /**
  * Associates a Nuage Vsp domain template with a
- * @param cmd
- * @return
+ * @param cmd Associate cmd which contains all the data
+ * @return true on success otherwise exception is thrown
 
 Review comment:
   if only true can be returned why return? it is then pass or exception, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services