[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372852585 @blueorangutan test This is an automated message from the

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372790077 I'm afraid this is not public and the error is a git clone/fetch problem in this case; ERROR: Timeout after 10 minutes

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-13 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372742295 @khos2ow you can do packaging, only test is restricted to us due to resource scheduling/limitations @blueorangutan package

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-08 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371453438 @blueorangutan test This is an automated message from the

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-08 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371423375 The code in itself looks good @khos2ow, except that i am missing a link to the db. How and where is the connection between

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-07 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371069607 yes @khos2ow , please replace either one or the other or vice versa. don't forget the test class as well, if you will.

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-06 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370715104 good point @rafaelweingartner! @khos2ow can you add unit tests for the class. Please both note that there is a 'new' class

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-03-05 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370571231 No, I don't think production code has been touched. maybe test installs?

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-02-07 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363748414 I am neutral on this as i don't oversee the consequences, i think

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-02-06 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363554774 jenkins failed This is an automated message from the Apache

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-02-06 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363554843 rekicking jenkins This is an automated message from the

[GitHub] DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

2018-02-06 Thread GitBox
DaanHoogland commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363553859 what is your -1 based on @rhtyd ? This is an automated