[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389959183 Created PR [#2653](https://github.com/apache/cloudstack/pull/2653) to address the discussion raised here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389959183 Created PR [#2653](https://github.com/apache/cloudstack/pull/2653) to address the discussion raised here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389522200 @DaanHoogland I agree with you. Let's keep your approach (`getNextAvailableMacAddressInNetwork`) to this issue and then open a new issue/PR in future with mac generation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-389201257 I would like to avoid the solution that just removes the conditional. What do you think of that solution @rhtyd? I am evaluating some alternatives yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC
to VM "A NIC with this MAC address exits for network:"
URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388445385
@covalle1428 if you intend to do an urgent fix, you can follow a few steps.
Bear in mind that this can be tricky and it would be risky to launch on a
production environment before testing it on a test environment.
1. get the 4.11 [source code](https://cloudstack.apache.org/downloads.html)
2. remove/comment
```
if(_nicDao.findByNetworkIdAndMacAddress(networkId, macAddress) != null) {
throw new CloudRuntimeException("A NIC with this MAC address exists for
network: " + network.getUuid());
}
```
That code is in method `addNicToVirtualMachine(AddNicToVMCmd cmd)` from
class `UserVmManagerImpl.java`
3. [build CloudStack from source
code](http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.11/building_from_source.html#building-from-source)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-388131599 @covalle1428, removing the conditional as @mdesaive showed is an emergency fix; however, I am analyzing other approaches. I will cite the PR here when created. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:"
GabrielBrascher commented on issue #2540: problem adding new shared network NIC to VM "A NIC with this MAC address exits for network:" URL: https://github.com/apache/cloudstack/issues/2540#issuecomment-387850759 Yes @rhtyd, I will take a look to fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
