[GitHub] khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script
khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171880742
##
File path: utils/src/main/java/com/cloud/maint/Version.java
##
@@ -19,59 +19,82 @@
package com.cloud.maint;
+import java.util.regex.Pattern;
+
+import org.apache.commons.lang.StringUtils;
+
public class Version {
/**
* Compares two version strings and see which one is higher version.
- * @param ver1
- * @param ver2
- * @return positive if ver1 is higher. negative if ver1 is lower; zero if
the same.
+ *
+ * @param version1
+ * @param version2
+ *
+ * @return positive if version1 is higher. negative if version2 is lower;
zero if the same.
Review comment:
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script
khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171869086
##
File path: utils/src/main/java/com/cloud/maint/Version.java
##
@@ -19,59 +19,82 @@
package com.cloud.maint;
+import java.util.regex.Pattern;
+
+import org.apache.commons.lang.StringUtils;
+
public class Version {
/**
* Compares two version strings and see which one is higher version.
- * @param ver1
- * @param ver2
- * @return positive if ver1 is higher. negative if ver1 is lower; zero if
the same.
+ *
+ * @param version1
+ * @param version2
+ *
+ * @return positive if version1 is higher. negative if version2 is lower;
zero if the same.
Review comment:
sure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script
khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171869059
##
File path: utils/src/main/java/com/cloud/maint/Version.java
##
@@ -19,59 +19,82 @@
package com.cloud.maint;
+import java.util.regex.Pattern;
+
+import org.apache.commons.lang.StringUtils;
+
public class Version {
/**
* Compares two version strings and see which one is higher version.
- * @param ver1
- * @param ver2
- * @return positive if ver1 is higher. negative if ver1 is lower; zero if
the same.
+ *
+ * @param version1
+ * @param version2
+ *
+ * @return positive if version1 is higher. negative if version2 is lower;
zero if the same.
Review comment:
Nice finding!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script
khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171329386
##
File path: tools/build/setnextversion.sh
##
@@ -16,60 +16,125 @@
# specific language governing permissions and limitations
# under the License.
-version='TESTBUILD'
-sourcedir=~/cloudstack/
-branch='master'
+set -e
-usage(){
-echo "usage: $0 -v version [-b branch] [-s source dir] [-h]"
-echo " -v sets the version"
-echo " -b sets the branch (defaults to 'master')"
-echo " -s sets the source directory (defaults to $sourcedir)"
-echo " -h"
+usage() {
+cat << USAGE
+Usage: setnextversion.sh --version string [OPTIONS]...
+Set the next version of CloudStack in the POMs.
+
+Mandatory arguments:
+ -v, --version stringSet the next version to be applied
+
+Optional arguments:
+ -b, --branch string Set the branch to update the
version into (default "master")
+ -s, --sourcedir string Set the source directory to clone
repo into (default "$sourcedir")
+ -n, --no-commit Apply only the version change and
don't git commit them (default "false")
Review comment:
Where in wiki? The only place I could find that references
`setnextversion.sh` is
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Procedure .
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
