[GitHub] khos2ow commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues
khos2ow commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues URL: https://github.com/apache/cloudstack/pull/2557#discussion_r180791250 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -12,6 +12,12 @@ - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) + + + Review comment: That's true! Although the correct syntax would be `Fixes #..., Fixes #..., ...`. The keyword needs to be specified before number everytime ([reference](https://help.github.com/articles/closing-issues-using-keywords/#closing-multiple-issues)). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues
khos2ow commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues URL: https://github.com/apache/cloudstack/pull/2557#discussion_r18017 ## File path: PULL_REQUEST_TEMPLATE.md ## @@ -12,6 +12,12 @@ - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) + + + Review comment: That's true, it can (and should) even be in the commit description as well. I only added another section since we already have some other sections for different purposes, and make it more unified (in terms of placement of `Fixes: #`) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
