[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372766474 @DaanHoogland is there a way to see the error of packaging? I believe this is related to #2485

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372748378 @DaanHoogland I see, good to know! This is an automated message

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-372734572 @borisstoyanov it might be failing because the last packaging happened long time ago and some part of the PR has been changed since

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371522716 @DaanHoogland there's no relation between `VersionVO` and `CloudStackVersion`. The latter is just a java representation of a

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371522716 @DaanHoogland there's no relation between `VersionVo` and `CloudStackVersion`. The latter is just a java representation of a

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-371276965 @DaanHoogland @rafaelweingartner can you take a look at the cleanup commit? I think I leave it as this and don't squash them,

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370843827 @rafaelweingartner @DaanHoogland I did consider using `CloudstackVersion.java` but wanted to be less disruptive and keep

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370598448 I'm +1 on testing (may be individually on different environments). I don't think automated test would give us much needed

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-370572358 @rafaelweingartner yes, that's correct. This is an automated

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369966282 @rhtyd @rafaelweingartner my goal in this PR was to be able to support - custom branding in POM version or provide it on the

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369966282 @rhtyd @rafaelweingartner my goal in this PR was to be able to support - custom branding in POM version or provide it on the

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369966282 @rhtyd @rafaelweingartner my goal in this PR was to be able to support - custom branding in POM version or provide it on the

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-366770781 @rafaelweingartner @DaanHoogland @rhtyd I updated the scripts and description of the PR again. Now when `--use-timestamp` is

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363834818 @rhtyd can you paste the command you ran that produced the screenshot you attached? If you don't do any _hacking_ around it and

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363552300 @rhtyd sure, go for it. I'm pretty sure it would be fine. This is

[GitHub] khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

khos2ow commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-363510674 @rhtyd @rafaelweingartner Can we proceed with this PR if no other change required?