[GitHub] marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

2018-02-23 Thread GitBox
marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package 
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-368022960
 
 
   @rafaelweingartner CI is green, so it should be all good to merge now since 
there is no code change in term of functionality.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

2018-02-22 Thread GitBox
marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package 
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-367614531
 
 
   @rafaelweingartner I'd rather push all together since it does not disturb 
the build. I had a hard time finding the solution for the generated classes. 
I'm down to the apidoc project, which requires a fix and it should all be good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

2018-01-24 Thread GitBox
marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package 
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-360086212
 
 
   Having a hard time try to make checkstyle to skip `generated-sources` 
directories (first encounter is in `plugins/network-elements/brocade-vcs` 
project). If anyone has a clue on what is the correct syntax, I'll appreciate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services