niteshsarda opened a new pull request #2188: CLOUDSTACK-10004 : On deletion, Vmware volume snapshots are left behind with message 'the snapshot has child, can't delete it on the storage' URL: https://github.com/apache/cloudstack/pull/2188 Snapshots are not deleted resulting unexpected storage consumption in case of VMware. **Steps to reproduce this issue :** 1. In VMware setup, create a snapshot of volume say Snap1. 2. After successful creation of snapshot Snap1, create new snapshot of same volume say Snap2.snapshots 3. While Snap2 is in BackingUp state, delete Snap1. 4. Snap1 will disappear from Web UI, but when we check secondary storage, files associated with Snap1 still persists even after cleanup job is performed. 5. In snapshot_store_ref table in DB, Snap1 will be in ready state instead of Destroyed. 6. Also, in snapshots table, status of Snap1 will be Destroyed but removed column will be null and will never change to the date of snapshot removal. **Fix for this issue :** 1. In VMware, snapshot chain is not maintained, instead full snapshot is taken every time. 2. So, it makes sense not to assign parent snapshot id for the snapshot. In this way, every snapshot will be individual and can be deleted successfully whenever required. **Screenshot of DB before applying fix :**  **Screenshot of DB after applying fix :**  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
