[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366800251 Since everything is ok, I will merge this one. Let's see if I still know how to do it :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366798899 @mike-tutkowski thanks! I am getting used to look directly to the "reviweres" section on Github and checking the approved ones. I did not seen any for this PR, that is why I asked again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366796206 reviewers (@DaanHoogland, @mike-tutkowski, @rhtyd ) what is your positions here? It seems that the tests passed and we have a consensus. If you are ok with this one, I would like to proceed and merge this to 4.11 and then forward to 4.12 (master branch) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359613929 @rhtyd I noticed that you changed the base branch for this PR, from master to 4.11. Do you want me to open a new PR against master? Given that you might run into trouble when merging forward. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357555819 Hmm..I am inclined to follow Daan's opinion on this one. It is a bug for sure, but it is a very specific one that we can easily fix later (if someone reports it). Anyways, it is going into 4.12... :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357195152 @rhtyd the build issues were already fixed. You started your packing with my first commit here, and there was a build issue at that time, but not anymore This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357004830 @mike-tutkowski Welcome! I should thank you for the help ;) Travis is failing, but I have not yet figured out why. It looks like a timeout thing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-356922299 Ah ok. Thanks for the feedback. I will leave the PR open, so we can work on it after 4.11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-356919058 Hmm, that is a good question. This affects only XenServers and the case that is broken is the following. > If you have a snapshot from a storage pool that has been deleted, you will not be able to create a volume or template from it. It feels like a critical problem, but I am not sure now if it is a blocker or not. Do we have a place where the concept of blocker is described? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command
rafaelweingartner commented on issue #2402: [CLOUDSTACK-10128] Simplify the search for host to execute command URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-356916761 @DaanHoogland, @rhtyd, and @mike-tutkowski can you review these changes? I believe that the problem described by Mike in #2298 can be considered a blocker, and this PR is fixing that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
