[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371244156
 
 
   If we have no objections I will be merging this one latter today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-07 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-371089577
 
 
   Thanks @DaanHoogland!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-06 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370865982
 
 
   @khos2ow would you mind reviewing this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-06 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370853345
 
 
   @DaanHoogland this test `test_hostha_enable_ha_when_host_in_maintenance` 
error seems to be persistent in other PRs as well. Can I consider that the 
tests finished successfully?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-02 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-370051762
 
 
   Now the failures increased... :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-03-02 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369898631
 
 
   That is a good question. For me, it is always best to start solving a 
bug/issue/new feature by unit tests because they cost less to run than these 
integration/smoke tests (this is what I have been doing so far). However, this 
requires a level of commitment (code has to be designed to be unit tested).
   
   Regarding revisiting tests, I would check them every-time they fail. 
Otherwise, there is too much for too few hands.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-02-28 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369288296
 
 
   @DaanHoogland thanks for the explanations.  Yes I was considering false 
positive/negative differently, but as long as we are able to explain them 
further as you did, we can understand each other.
   
   So, it seems that most of these failures are due to runtime issues, normally 
from timeouts. Moreover, as far as we know it is not possible for the tests to 
return with a "success" message, when there is a problem. Unless, of course, if 
there is a problem/case that the current tests do not cover.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-02-28 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369214377
 
 
   The one I remember right now is the HA test, which I have seen failing in 
PRs 2438 and 2469. 
   My doubt is the following, as long as we have false negatives (showing that 
there is a problem, when there isn't), can't we have false positive (showing 
that everything is ok, when it is not) as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-02-27 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369015380
 
 
   These failures are the same that appeared in other PR that is changing 
different things. How much can we trust these errors? Or an even better 
question, can we trust in a successful execution?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-02-15 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-366009336
 
 
   @DaanHoogland I separated the code changes from formatting one as your 
suggestion. I think it is way better now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-01-27 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-361006831
 
 
   ok @DaanHoogland.
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-01-27 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360979844
 
 
   I would say that there is only one formatting style for ACS. However, I have 
seen so many PRs like this one where we see a lot of formatting changes that I 
am starting to doubt if we are all using the same. 
   
   I agree with you. My intention here was never to do code formatting. My 
eclipse is configured to format only edit lines, but for some reason it 
formatted all of the Java files I touched (maybe I pressed a ctrl+shift+f 
without noticing). Would you like me to remove the formatting and leave only 
the real changes I am introducing here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

2018-01-27 Thread GitBox
rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360971535
 
 
   @Daan, thanks for the feedback here!
   I am starting to doubt that we are all using the same code formatter (I am 
using this one [1]). I can remove the code formatting changes and leave only 
the methods that I created if you prefer.
   
   [1] 
https://cwiki.apache.org/confluence/download/attachments/29687985/ApacheCloudStack.xml?version=1=1382960469000=v2
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services