[GitHub] rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-05-02 Thread GitBox 
rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if 
to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385934377
 
 
   I do believe it needs code extraction and unit tests, but you want to merge 
it. Let's proceed and merge.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox 
rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if 
to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372797423
 
 
   I actually meant unit tests. I think they would fit better the method 
extraction. They would also be easier to develop. Once you get to create them, 
if you are unsure how to proceed, just ping me. I can help you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

2018-03-13 Thread GitBox 
rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if 
to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372734014
 
 
   It is ok the code as is. However, it might have been interesting to see the 
feedback of the author.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services