[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-07-20 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-406605714 Unless I am mistaken, this feature is not in 4.11

[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-07-19 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-406259935 @DaanHoogland I applied your suggestion here regarding

[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-07-18 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-405968549 This new method that I implemented is the consolidation of the logic of tag matching in

[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-07-15 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-405124764 @DaanHoogland can you please run tests here?

[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-05-17 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-389877654 @blueorangutan package

[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-05-11 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-388334921 Ops, now I see what you meant. I selected 4.11.2, instead of 4.12. Problem fixed now.

[GitHub] rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement

2018-05-11 Thread GitBox
rafaelweingartner commented on issue #2636: Fix limitation on tag matching in 'migrateVolume' with disk offering replacement URL: https://github.com/apache/cloudstack/pull/2636#issuecomment-388334756 @rhtyd the feature I am enhancing is only in 4.12. That is why this PR is targeting 4.12.