[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320685545 Thanks @marcaurele please collaborate on #2226 , feel free to directly push changes. I'll use your suggestions and incorporate them in the systemd scripts now, currently trying to fix centos packaging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320680234 @marcaurele thanks, I started working on this PR based on your branch to fix the centos7 issues: https://github.com/apache/cloudstack/pull/2226 this is on ASF remote so any committer should be able to commit or send PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320651759 @marcaurele with the above fix I could get the build to work, however can you share how would you run the management server both using mvn and scripts? I'm unable to get it to work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar
URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320638183
@marcaurele I've found the fix, can you put this commit in your branch as I
cannot push changes:
```
diff --git a/tools/apidoc/build-apidoc.sh b/tools/apidoc/build-apidoc.sh
index 8ab69c8373..4e1f9a639d 100755
--- a/tools/apidoc/build-apidoc.sh
+++ b/tools/apidoc/build-apidoc.sh
@@ -47,7 +47,7 @@ fi
CP=$PATHSEP/
-java -cp $CP$PATHSEP$TARGETJARDIR/*$PATHSEP$DEPSDIR/*
com.cloud.api.doc.ApiXmlDocWriter -d "$DISTDIR" $*
+java -cp $CP$PATHSEP$TARGETJARDIR$PATHSEP$DEPSDIR
com.cloud.api.doc.ApiXmlDocWriter -d "$DISTDIR" $*
if [ $? -ne 0 ]
then
diff --git a/tools/apidoc/gen_toc.py b/tools/apidoc/gen_toc.py
index a261037d80..39e1576422 100644
--- a/tools/apidoc/gen_toc.py
+++ b/tools/apidoc/gen_toc.py
@@ -180,7 +180,8 @@ known_categories = {
'stopNetScalerVpx' : 'Load Balancer',
'deleteServicePackageOffering' : 'Load Balancer',
'destroyNsVpx' : 'Load Balancer',
-'startNsVpx' : 'Load Balancer'
+'startNsVpx' : 'Load Balancer',
+'listElastistorInterface': 'Misc'
}
diff --git a/tools/apidoc/pom.xml b/tools/apidoc/pom.xml
index e6804a0e78..61c1ccd593 100644
--- a/tools/apidoc/pom.xml
+++ b/tools/apidoc/pom.xml
@@ -21,8 +21,8 @@
../pom.xml
-
../../client/target/cloud-client-ui-${project.version}/WEB-INF/
-${client.config.base}/lib
+../../client/target/
+
${client.config.base}/cloud-client-ui-${project.version}.jar
${client.config.base}/classes
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320617540 @marcaurele thanks, I'll have a look this week. Can you fix Travis failures as well, are there any changes wrt how a developer builds, runs and tests CloudStack? I've one reservation -- if we put everything in a single jar, it might be difficult for users to apply UI changes and add custom jars, anyway to do that? Maybe add a custom path (add a classpath) for an override directory from where jars may be loaded and maybe split the UI as a separate rpm/deb? Can you also allow me to push on the exoscale:CLOUDSTACK-10012 branch? Alternatively, you may push the changes to the upstream branch so I can collaborate and make changes with you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320617812 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320617540 @marcaurele thanks, I'll have a look this week. I've one reservation -- if we put everything in a single jar, it might be difficult for users to apply UI changes and add custom jars, anyway to do that? Maybe add a custom path (add a classpath) for an override directory from where jars may be loaded and maybe split the UI as a separate rpm/deb? Can you also allow me to push on the exoscale:CLOUDSTACK-10012 branch? Alternatively, you may push the changes to the upstream branch so I can collaborate and make changes with you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2207: Embedded jetty inside shaded jar
rhtyd commented on issue #2207: Embedded jetty inside shaded jar URL: https://github.com/apache/cloudstack/pull/2207#issuecomment-320617540 @marcaurele thanks, I'll have a look this week. I've one reservation -- if we put everything in a single jar, it might be difficult for users to apply UI changes and add custom jars, anyway to do that? Maybe add a custom path (add a classpath) for an override directory from where jars may be loaded and maybe split the UI as a separate rpm/deb? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
