[GitHub] wido commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

2017-08-11 Thread git 
wido commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 
8081 port for Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#discussion_r132677378
 
 

 ##
 File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2054,7 +2054,7 @@ public ServiceOffering createServiceOffering(final 
CreateServiceOfferingCmd cmd)
 if(!allowNetworkRate) {
 throw new InvalidParameterValueException("Network rate can be 
specified only for non-System offering and system offerings having 
\"domainrouter\" systemvmtype");
 }
-if(cmd.getNetworkRate().intValue() < 1) {
+if(cmd.getNetworkRate().intValue() < 0) {
 throw new InvalidParameterValueException("Failed to create 
service offering " + name + ": specify the network rate value more than 0");
 
 Review comment:
   @SowjanyaPatha Ok! I see
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

2017-08-10 Thread git 
wido commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 
8081 port for Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#discussion_r132490211
 
 

 ##
 File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2054,7 +2054,7 @@ public ServiceOffering createServiceOffering(final 
CreateServiceOfferingCmd cmd)
 if(!allowNetworkRate) {
 throw new InvalidParameterValueException("Network rate can be 
specified only for non-System offering and system offerings having 
\"domainrouter\" systemvmtype");
 }
-if(cmd.getNetworkRate().intValue() < 1) {
+if(cmd.getNetworkRate().intValue() < 0) {
 throw new InvalidParameterValueException("Failed to create 
service offering " + name + ": specify the network rate value more than 0");
 
 Review comment:
   The error message below says something different then the if statement
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services