Re: [I] Sesitive information of request.getRequestLine() may leak [cloudstack]
DaanHoogland closed issue #8852: Sesitive information of request.getRequestLine() may leak URL: https://github.com/apache/cloudstack/issues/8852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Sesitive information of request.getRequestLine() may leak [cloudstack]
DaanHoogland commented on issue #8852: URL: https://github.com/apache/cloudstack/issues/8852#issuecomment-2042459913 I see, I will add an extra cleanString here as well, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Sesitive information of request.getRequestLine() may leak [cloudstack]
1561316811 commented on issue #8852: URL: https://github.com/apache/cloudstack/issues/8852#issuecomment-2040967009 Firstly, in the following link, we know the "request.getRequestLine()" is a sensitive variable, needed to "cleanString" after logging out. https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/server/src/main/java/com/cloud/api/ApiServer.java#L467 Then, in the following code, the data of "request.getRequestLine()" flows to "paramList" in line 472. After iterator "paramList", "param" variable data flows to "message" in line 491. At last, the "message" is logged out by "logger.warn" in line 493 https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/server/src/main/java/com/cloud/api/ApiServer.java#L472-L496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Sesitive information of request.getRequestLine() may leak [cloudstack]
DaanHoogland commented on issue #8852: URL: https://github.com/apache/cloudstack/issues/8852#issuecomment-2034054521 @1561316811 , user supplied information is logged. Please explain how this is an issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
