Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2589612703 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2589481491 @nvazquez @shwstppr , can you have another look at this? I implemented kinda the idea from https://github.com/apache/cloudstack/pull/9925#issuecomment-2579897718 , save the automatic start of retrieval. I think this would alleviate the time-out issue and should be good for use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2587732533 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
nvazquez commented on code in PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1909607390 ## plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcItems.java: ## @@ -0,0 +1,13 @@ +package org.apache.cloudstack.api.command.admin.zone; Review Comment: Missing header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
shwstppr commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2579897718 @DaanHoogland cc @nvazquez my take would be always load instances for a host. So, in UI list is retrieved for the first host in the hosts list. It may require adding a UI dropdown but will keep things simple -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2577513950 @nvazquez , I added the possibility to retrieve only the VMs from a certain host and an API to list the hosts. I am not sure on how to use this in the UI yet. One solution is to just query for 100 results and let users that want more use the API..? cc @shwstppr @sureshanaparti -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2577482466 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2575386155 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2575265983 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2575263972 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899532112
##
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcVmsCmd.java:
##
@@ -70,6 +70,14 @@ public class ListVmwareDcVmsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.PASSWORD, type = CommandType.STRING,
description = "The password for specified username.")
private String password;
+@Parameter(name = ApiConstants.BATCH_SIZE, type = CommandType.INTEGER,
description = "The maximum number of results to return.")
+private Integer batchSize;
+
+@Parameter(name = ApiConstants.TOKEN, type = CommandType.STRING,
+description = "For listVmwareDcVms, if the maximum number of
results (the `pagesize`) is exceeded, " +
+" a token is returned. This token can be used in
subsequent calls to retrieve more results")
Review Comment:
```suggestion
description = "For listVmwareDcVms, if the maximum number of
results (the `batchsize`) is exceeded, " +
" a token is returned. This token can be used in
subsequent calls to retrieve more results." +
" As long as a token is returned, more results can be
retrieved")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899534009
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -1408,11 +1408,31 @@ export default {
})
}
},
+async fetchMoreVms (obj) {
+ var params = obj.params
+ params.token = obj.response.token
+ api('listVmwareDcVms', params).then(json => {
+const obj = {
+ params: params,
+ response: json.listvmwaredcvmsresponse
+}
+this.unmanagedInstances.append(obj.response.unmanagedinstance)
+this.checkForMoreVms(obj)
Review Comment:
because if token is null and we call again we start over to the beginning of
the list of VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899534009
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -1408,11 +1408,31 @@ export default {
})
}
},
+async fetchMoreVms (obj) {
+ var params = obj.params
+ params.token = obj.response.token
+ api('listVmwareDcVms', params).then(json => {
+const obj = {
+ params: params,
+ response: json.listvmwaredcvmsresponse
+}
+this.unmanagedInstances.append(obj.response.unmanagedinstance)
+this.checkForMoreVms(obj)
Review Comment:
becasue if token is null and we call again we start over to the beginning of
the list of VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899534875
##
ui/src/views/tools/SelectVmwareVcenter.vue:
##
@@ -217,6 +217,7 @@ export default {
} else {
params.existingvcenterid = this.selectedExistingVcenterId
}
+ params.batchsize = 2
Review Comment:
debug value. will need to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899534719
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -1408,11 +1408,31 @@ export default {
})
}
},
+async fetchMoreVms (obj) {
+ var params = obj.params
+ params.token = obj.response.token
+ api('listVmwareDcVms', params).then(json => {
+const obj = {
+ params: params,
+ response: json.listvmwaredcvmsresponse
+}
+this.unmanagedInstances.append(obj.response.unmanagedinstance)
+this.checkForMoreVms(obj)
+ })
+},
onListUnmanagedInstancesFromVmware (obj) {
this.selectedVmwareVcenter = obj.params
this.unmanagedInstances = obj.response.unmanagedinstance
this.itemCount.unmanaged = obj.response.count
- this.unmanagedInstancesLoading = false
+ this.checkForMoreVms(obj)
+},
+checkForMoreVms (obj) {
Review Comment:
I am still thinking on how to make this the best user experience, so far I
just want the background loading to work while the use no longer needs to wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899532688
##
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcVmsCmd.java:
##
@@ -70,6 +70,14 @@ public class ListVmwareDcVmsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.PASSWORD, type = CommandType.STRING,
description = "The password for specified username.")
private String password;
+@Parameter(name = ApiConstants.BATCH_SIZE, type = CommandType.INTEGER,
description = "The maximum number of results to return.")
+private Integer batchSize;
+
+@Parameter(name = ApiConstants.TOKEN, type = CommandType.STRING,
+description = "For listVmwareDcVms, if the maximum number of
results (the `pagesize`) is exceeded, " +
+" a token is returned. This token can be used in
subsequent calls to retrieve more results")
Review Comment:
yes, It is the batch size. I am removing the baseListCmd from the hierarchy
as it may indeed be confusing for these purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899532112
##
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcVmsCmd.java:
##
@@ -70,6 +70,14 @@ public class ListVmwareDcVmsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.PASSWORD, type = CommandType.STRING,
description = "The password for specified username.")
private String password;
+@Parameter(name = ApiConstants.BATCH_SIZE, type = CommandType.INTEGER,
description = "The maximum number of results to return.")
+private Integer batchSize;
+
+@Parameter(name = ApiConstants.TOKEN, type = CommandType.STRING,
+description = "For listVmwareDcVms, if the maximum number of
results (the `pagesize`) is exceeded, " +
+" a token is returned. This token can be used in
subsequent calls to retrieve more results")
Review Comment:
```suggestion
description = "For listVmwareDcVms, if the maximum number of
results (the `batchsize`) is exceeded, " +
" a token is returned. This token can be used in
subsequent calls to retrieve more results")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899527154
##
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##
@@ -1106,6 +1107,7 @@ public class ApiConstants {
public static final String PARAMETER_DESCRIPTION_IS_TAG_A_RULE = "Whether
the informed tag is a JS interpretable rule or not.";
public static final String NFS_MOUNT_OPTIONS = "nfsmountopts";
+public static final String MAX_NUMBER = "maxnumber";
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
shwstppr commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1899488874
##
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcVmsCmd.java:
##
@@ -82,6 +90,14 @@ public String getPassword() {
return password;
}
+public Integer getBatchSize() {
Review Comment:
This is not used
##
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcVmsCmd.java:
##
@@ -70,6 +70,14 @@ public class ListVmwareDcVmsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.PASSWORD, type = CommandType.STRING,
description = "The password for specified username.")
private String password;
+@Parameter(name = ApiConstants.BATCH_SIZE, type = CommandType.INTEGER,
description = "The maximum number of results to return.")
+private Integer batchSize;
+
+@Parameter(name = ApiConstants.TOKEN, type = CommandType.STRING,
+description = "For listVmwareDcVms, if the maximum number of
results (the `pagesize`) is exceeded, " +
+" a token is returned. This token can be used in
subsequent calls to retrieve more results")
Review Comment:
If possible, please rephrase. Not clear to me. As far as I understand, this
is a string returned by API when the actual count is more than the pagesize (by
request)?
##
ui/src/views/tools/SelectVmwareVcenter.vue:
##
@@ -217,6 +217,7 @@ export default {
} else {
params.existingvcenterid = this.selectedExistingVcenterId
}
+ params.batchsize = 2
Review Comment:
why 2?
##
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##
@@ -1106,6 +1107,7 @@ public class ApiConstants {
public static final String PARAMETER_DESCRIPTION_IS_TAG_A_RULE = "Whether
the informed tag is a JS interpretable rule or not.";
public static final String NFS_MOUNT_OPTIONS = "nfsmountopts";
+public static final String MAX_NUMBER = "maxnumber";
Review Comment:
Not used
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -1408,11 +1408,31 @@ export default {
})
}
},
+async fetchMoreVms (obj) {
+ var params = obj.params
+ params.token = obj.response.token
+ api('listVmwareDcVms', params).then(json => {
+const obj = {
+ params: params,
+ response: json.listvmwaredcvmsresponse
+}
+this.unmanagedInstances.append(obj.response.unmanagedinstance)
+this.checkForMoreVms(obj)
Review Comment:
If we only need existing params and token, why not just set params.token
here and pass params
##
ui/src/views/tools/ManageInstances.vue:
##
@@ -1408,11 +1408,31 @@ export default {
})
}
},
+async fetchMoreVms (obj) {
+ var params = obj.params
+ params.token = obj.response.token
+ api('listVmwareDcVms', params).then(json => {
+const obj = {
+ params: params,
+ response: json.listvmwaredcvmsresponse
+}
+this.unmanagedInstances.append(obj.response.unmanagedinstance)
+this.checkForMoreVms(obj)
+ })
+},
onListUnmanagedInstancesFromVmware (obj) {
this.selectedVmwareVcenter = obj.params
this.unmanagedInstances = obj.response.unmanagedinstance
this.itemCount.unmanaged = obj.response.count
- this.unmanagedInstancesLoading = false
+ this.checkForMoreVms(obj)
+},
+checkForMoreVms (obj) {
Review Comment:
Is it better to let user control loading more objects or not? Currently, if
there are 1000 VMware VMs and user opens this view, user's intended VM is
returned in the first request itself, will it continue calling API for more
results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2563738020 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2559923038 Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2559828975 @DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2559828342 @blueorangutan LLpackage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895706244
##
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatacenterMO.java:
##
@@ -65,24 +71,7 @@ public DatacenterMO(VmwareContext context, String dcName)
throws Exception {
@Override
public String getName() throws Exception {
-return (String)_context.getVimClient().getDynamicProperty(_mor,
"name");
-}
-
-public void registerTemplate(ManagedObjectReference morHost, String
datastoreName, String templateName, String templateFileName) throws Exception {
Review Comment:
yes, planning to go through the whole vmware-base lib and remove even more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895703899
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -498,31 +505,26 @@ public List
addHostToPodCluster(VmwareContext serviceCon
throw new CloudRuntimeException("Invalid serviceContext");
}
ManagedObjectReference mor =
serviceContext.getHostMorByPath(hostInventoryPath);
-String privateTrafficLabel = null;
+String privateTrafficLabel;
privateTrafficLabel =
serviceContext.getStockObject("privateTrafficLabel");
if (privateTrafficLabel == null) {
privateTrafficLabel = _privateNetworkVSwitchName;
}
if (mor != null) {
-List returnedHostList = new
ArrayList();
+List returnedHostList = new ArrayList<>();
if (mor.getType().equals("ComputeResource")) {
List hosts =
serviceContext.getVimClient().getDynamicProperty(mor, "host");
-assert (hosts != null && hosts.size() > 0);
-
-// For ESX host, we need to enable host firewall to allow VNC
access
-HostMO hostMo = new HostMO(serviceContext, hosts.get(0));
Review Comment:
good catch, will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895701068
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -459,7 +466,7 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
AboutInfo about = hostMo.getHostAboutInfo();
if (about != null) {
String version = about.getApiVersion();
-if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)
Review Comment:
not sure if I should refactor this further, yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895700027
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -459,7 +466,7 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
AboutInfo about = hostMo.getHostAboutInfo();
if (about != null) {
String version = about.getApiVersion();
-if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)
Review Comment:
`_portsPerDvPortGroup < DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)` comes
down to the hardcoded condition `8<256`
```suggestion
if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x), which means 8 < 256
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895693662
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -459,7 +466,7 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
AboutInfo about = hostMo.getHostAboutInfo();
if (about != null) {
String version = about.getApiVersion();
-if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)
Review Comment:
I will double check, but IIRC it makes no sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895692846
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -984,40 +984,15 @@ public void processHostAdded(long hostId) {
@Override
public void processConnect(Host host, StartupCommand cmd, boolean
forRebalance) {
-if (cmd instanceof StartupCommand) {
+if (cmd != null) {
if (host.getHypervisorType() == HypervisorType.VMware) {
updateClusterNativeHAState(host, cmd);
-} else {
-return;
}
}
}
protected final static int DEFAULT_DOMR_SSHPORT = 3922;
-protected boolean shutdownRouterVM(DomainRouterVO router) {
Review Comment:
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
nvazquez commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895624907
##
plugins/hypervisors/vmware/src/main/java/org/apache/cloudstack/api/command/admin/zone/VmwarRequestReponse.java:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.zone;
+
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.response.ListResponse;
+
+public class VmwarRequestReponse extends
ListResponse {
Review Comment:
Typo on the class name
##
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatacenterMO.java:
##
@@ -65,24 +71,7 @@ public DatacenterMO(VmwareContext context, String dcName)
throws Exception {
@Override
public String getName() throws Exception {
-return (String)_context.getVimClient().getDynamicProperty(_mor,
"name");
-}
-
-public void registerTemplate(ManagedObjectReference morHost, String
datastoreName, String templateName, String templateFileName) throws Exception {
Review Comment:
Were these removed methods unused?
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -459,7 +466,7 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
AboutInfo about = hostMo.getHostAboutInfo();
if (about != null) {
String version = about.getApiVersion();
-if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)
Review Comment:
Why commenting out this condition?
##
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatacenterMO.java:
##
@@ -338,10 +341,22 @@ public List
getVmPropertiesOnDatacenterVmFolder(String[] property
PropertyFilterSpec pfSpec = new PropertyFilterSpec();
pfSpec.getPropSet().add(pSpec);
pfSpec.getObjectSet().add(oSpec);
-List pfSpecArr = new
ArrayList();
+List pfSpecArr = new ArrayList<>();
pfSpecArr.add(pfSpec);
-return
_context.getService().retrieveProperties(_context.getPropertyCollector(),
pfSpecArr);
+RetrieveOptions ro = new RetrieveOptions();
+if (maxObjects != null && maxObjects > 0) {
+ro.setMaxObjects(maxObjects);
+}
+
+RetrieveResult result =
_context.getService().retrievePropertiesEx(_context.getPropertyCollector(),
pfSpecArr, ro);
+return createReturnObjectPair(result);
+}
+
+private static Pair>
createReturnObjectPair(RetrieveResult result) {
+String tokenForRetrievingNewResults = result.getToken();
Review Comment:
Nice solution, can we also add to the javadocs the meaning of this token
regarding Vmware SDK? (maybe also a link to the SDK docs): `the token returned
in the previous RetrieveResult returned on the same session by the same
PropertyCollector.`
(https://vdc-download.vmware.com/vmwb-repository/dcr-public/4fcedce4-0e06-49cc-bb39-38732c40995d/c087e649-192b-416c-9aa1-dcbb75e74d17/vmodl.query.PropertyCollector.html
- maybe this is not the latest URL)
##
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##
@@ -984,40 +984,15 @@ public void processHostAdded(long hostId) {
@Override
public void processConnect(Host host, StartupCommand cmd, boolean
forRebalance) {
-if (cmd instanceof StartupCommand) {
+if (cmd != null) {
if (host.getHypervisorType() == HypervisorType.VMware) {
updateClusterNativeHAState(host, cmd);
-} else {
-return;
}
}
}
protected final static int DEFAULT_DOMR_SSHPORT = 3922;
-protected boolean shutdownRouterVM(DomainRouterVO router) {
Review Comment:
No need for this method anymore?
##
plugins/hypervis
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2551773551 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2541879605 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2540297569 [SF] Trillian test result (tid-11885) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51969 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9925-t11885-vmware-70u3.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2538374526 [SF] Trillian Build Failed (tid-11884) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2538250732 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2536486420 > > > @DaanHoogland is it possible to keep the results in memory for different list vmware vm calls, & provide some kind on pagination (maybe, using _pagescount, page_ params) from UI? > > > > > > yes, this would be in a map with the caller session as key and would have to return after initial results return and start an async job to get the rest in batches. not a very trivial change. > > also, is it possible to support keyword based retrieval? if one knows the vm name in vmware, they can pass as keyword and can see in the result (this way results are also less, and can show up vms in the end of the original retrieval list) I am going to leave this out of scope. It requires some extra work that I do not know of yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2536451642 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
codecov[bot] commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2536266985 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9925?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`f9b1767`)](https://app.codecov.io/gh/apache/cloudstack/commit/f9b176744e6a47837f6153b550a4117e9d453a45?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`73a2156`)](https://app.codecov.io/gh/apache/cloudstack/commit/73a21564135d1653a584b7091292c9e428422c38?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (f9b1767) and HEAD (73a2156). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (f9b1767) | HEAD (73a2156) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9925 +/- ## - Coverage 15.12% 4.30% -10.83% Files 5408 366 -5042 Lines473843 29571 -444272 Branches 577715180-52591 - Hits 716881272-70416 + Misses 394156 28155 -366001 + Partials 7999 144 -7855 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9925/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9925?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
sureshanaparti commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2511372727 > > @DaanHoogland is it possible to keep the results in memory for different list vmware vm calls, & provide some kind on pagination (maybe, using _pagescount, page_ params) from UI? > > yes, this would be in a map with the caller session as key and would have to return after initial results return and start an async job to get the rest in batches. not a very trivial change. also, is it possible to support keyword based retrieval? if one knows the vm name in vmware, they can pass as keyword and can see in the result (this way results are also less, and can show up vms in the end of the original retrieval list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2510850010 @sureshanaparti , I removed the needs-testing label as I don't think it is ready for testing yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2510848840 > @DaanHoogland is it possible to keep the results in memory for different list vmware vm calls, & provide some kind on pagination (maybe, using _pagescount, page_ params) from UI? yes, this would be in a map with the caller session as key and would have to return after initial results return and start an async job to get the rest in batches. not a very trivial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
sureshanaparti commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2507843112 @DaanHoogland is it possible to keep the results in memory for different list vmware vm calls, & provide some kind on pagination (maybe, using _pagescount, page_ params) from UI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2492442942 [SF] Trillian test result (tid-11793) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 44534 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9925-t11793-kvm-ol8.zip Smoke tests completed. 133 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2490451182 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2490456437 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2489095606 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
blueorangutan commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2488951694 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
DaanHoogland commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2488950071 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add maximum results number to retrieval of unregistered VMs on vmware [cloudstack]
github-actions[bot] commented on PR #9925: URL: https://github.com/apache/cloudstack/pull/9925#issuecomment-2474324543 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
