Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2830452082 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2830242294 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2830245790 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2830237584 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2830069840 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2830066508 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2801388491 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2801614452 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2801393795 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2784985148 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2784917551 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2784916765 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
DaanHoogland commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2753968700 @nvazquez , can you look at the lint errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2729594378 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2729304239 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2729307562 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2691560233 [SF] Trillian test result (tid-12510) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56392 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12510-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 403.59 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2689715063 @rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
rohityadavcloud commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2689712968 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2685321412 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2684954680 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2684953180 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2682260391 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2682068568 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2682062703 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969786407
##
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##
@@ -1178,16 +1177,28 @@ public boolean detachIso(long vmId, boolean forced) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_ISO_ATTACH, eventDescription =
"attaching ISO", async = true)
-public boolean attachIso(long isoId, long vmId, boolean forced) {
+public boolean attachIso(long isoId, long vmId, Boolean... extraParams) {
Account caller = CallContext.current().getCallingAccount();
Long userId = CallContext.current().getCallingUserId();
+boolean forced = extraParams != null && extraParams.length > 0 ?
extraParams[0] : false;
+boolean isVirtualRouter = extraParams != null && extraParams.length >
1 ? extraParams[1] : false;
Review Comment:
Same on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969785646
##
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##
@@ -1139,35 +1140,33 @@ public boolean templateIsDeleteable(long templateId) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_ISO_DETACH, eventDescription =
"detaching ISO", async = true)
-public boolean detachIso(long vmId, boolean forced) {
+public boolean detachIso(long vmId, Long isoParamId, Boolean...
extraParams) {
Account caller = CallContext.current().getCallingAccount();
Long userId = CallContext.current().getCallingUserId();
-// Verify input parameters
-UserVmVO vmInstanceCheck = _userVmDao.findById(vmId);
-if (vmInstanceCheck == null) {
-throw new InvalidParameterValueException("Unable to find a virtual
machine with id " + vmId);
-}
+boolean forced = extraParams != null && extraParams.length > 0 ?
extraParams[0] : false;
+boolean isVirtualRouter = extraParams != null && extraParams.length >
1 ? extraParams[1] : false;
Review Comment:
Hi @sureshanaparti this is already added on the method's javadoc at the
`TemplateApiService` interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969298302
##
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/AddNodesToKubernetesClusterCmd.java:
##
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.kubernetes.cluster;
+
+import com.cloud.kubernetes.cluster.KubernetesClusterEventTypes;
+import com.cloud.kubernetes.cluster.KubernetesClusterService;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.UserVmResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.lang3.BooleanUtils;
+
+import javax.inject.Inject;
+
+import java.util.List;
+
+@APICommand(name = "addNodesToKubernetesCluster",
+description = "Add nodes as workers to an existing CKS cluster. ",
+responseObject = KubernetesClusterResponse.class,
+since = "4.21.0",
+authorized = {RoleType.Admin, RoleType.ResourceAdmin,
RoleType.DomainAdmin, RoleType.User})
+public class AddNodesToKubernetesClusterCmd extends BaseAsyncCmd {
+
+@Inject
+public KubernetesClusterService kubernetesClusterService;
+
+@Parameter(name = ApiConstants.NODE_IDS,
+type = CommandType.LIST,
+collectionType = CommandType.UUID,
+entityType= UserVmResponse.class,
+description = "comma separated list of (external) node (physical
or virtual machines) IDs that need to be" +
+"added as worker nodes to an existing managed Kubernetes
cluster (CKS)",
+required = true,
+since = "4.21.0")
+private List nodeIds;
+
+@Parameter(name = ApiConstants.ID, type = CommandType.UUID, required =
true,
+entityType = KubernetesClusterResponse.class,
+description = "the ID of the Kubernetes cluster", since = "4.21.0")
+private Long clusterId;
+
+@Parameter(name = ApiConstants.MOUNT_CKS_ISO_ON_VR, type =
CommandType.BOOLEAN,
+description = "(optional) Vmware only, uses the CKS cluster
network VR to mount the CKS ISO",
+since = "4.21.0")
Review Comment:
I think, no need to add since for each param, when it is mentioned at
class/cmd level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969306062
##
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/ScaleKubernetesClusterCmd.java:
##
@@ -68,6 +72,11 @@ public class ScaleKubernetesClusterCmd extends BaseAsyncCmd {
description = "the ID of the service offering for the virtual machines
in the cluster.")
private Long serviceOfferingId;
+@ACL(accessType = SecurityChecker.AccessType.UseEntry)
+@Parameter(name = ApiConstants.NODE_TYPE_OFFERING_MAP, type =
CommandType.MAP,
+description = "(Optional) Node Type to Service Offering ID
mapping. If provided, it overrides the serviceofferingid parameter")
Review Comment:
add since here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969336094
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java:
##
@@ -263,11 +333,84 @@ private String
getKubernetesAdditionalControlNodeConfig(final String joinIp, fin
return k8sControlNodeConfig;
}
-private UserVm createKubernetesAdditionalControlNode(final String joinIp,
final int additionalControlNodeInstance) throws ManagementServerException,
+private String getInitialEtcdClusterDetails(List ipAddresses,
List hostnames) {
+String initialCluster = "%s=http://%s:2380";;
+StringBuilder clusterInfo = new StringBuilder();
+for (int i = 0; i < ipAddresses.size(); i++) {
+clusterInfo.append(String.format(initialCluster,
hostnames.get(i), ipAddresses.get(i)));
+if (i < ipAddresses.size()-1) {
+clusterInfo.append(",");
+}
+}
+return clusterInfo.toString();
+}
+
+/**
+ *
+ * @param ipAddresses list of etcd node guest IPs
+ * @return a formatted list of etcd endpoints adhering to YAML syntax
+ */
+private String getEtcdEndpointList(List ipAddresses) {
+StringBuilder endpoints = new StringBuilder();
+for (int i = 0; i < ipAddresses.size(); i++) {
+endpoints.append(String.format("- http://%s:2379";,
ipAddresses.get(i).getIp4Address()));
Review Comment:
use _ETCD_NODE_CLIENT_REQUEST_PORT_ const defined in
KubernetesClusterActionWorker.java (or keep them in some common kubernetes
utils)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969334109
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java:
##
@@ -263,11 +333,84 @@ private String
getKubernetesAdditionalControlNodeConfig(final String joinIp, fin
return k8sControlNodeConfig;
}
-private UserVm createKubernetesAdditionalControlNode(final String joinIp,
final int additionalControlNodeInstance) throws ManagementServerException,
+private String getInitialEtcdClusterDetails(List ipAddresses,
List hostnames) {
+String initialCluster = "%s=http://%s:2380";;
Review Comment:
use _ETCD_NODE_PEER_COMM_PORT_ const defined in
KubernetesClusterActionWorker.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969317851
##
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##
@@ -1139,35 +1140,33 @@ public boolean templateIsDeleteable(long templateId) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_ISO_DETACH, eventDescription =
"detaching ISO", async = true)
-public boolean detachIso(long vmId, boolean forced) {
+public boolean detachIso(long vmId, Long isoParamId, Boolean...
extraParams) {
Account caller = CallContext.current().getCallingAccount();
Long userId = CallContext.current().getCallingUserId();
-// Verify input parameters
-UserVmVO vmInstanceCheck = _userVmDao.findById(vmId);
-if (vmInstanceCheck == null) {
-throw new InvalidParameterValueException("Unable to find a virtual
machine with id " + vmId);
-}
+boolean forced = extraParams != null && extraParams.length > 0 ?
extraParams[0] : false;
+boolean isVirtualRouter = extraParams != null && extraParams.length >
1 ? extraParams[1] : false;
Review Comment:
add comment/javadoc to indicate the expected order of the bool extra params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969318467
##
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##
@@ -1178,16 +1177,28 @@ public boolean detachIso(long vmId, boolean forced) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_ISO_ATTACH, eventDescription =
"attaching ISO", async = true)
-public boolean attachIso(long isoId, long vmId, boolean forced) {
+public boolean attachIso(long isoId, long vmId, Boolean... extraParams) {
Account caller = CallContext.current().getCallingAccount();
Long userId = CallContext.current().getCallingUserId();
+boolean forced = extraParams != null && extraParams.length > 0 ?
extraParams[0] : false;
+boolean isVirtualRouter = extraParams != null && extraParams.length >
1 ? extraParams[1] : false;
Review Comment:
add comment/javadoc to indicate the expected order of the bool extra params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969311164
##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -5412,9 +5412,13 @@ public ASNumberResponse createASNumberResponse(ASNumber
asn) {
response.setZoneName(zone.getName());
response.setAsNumber(asn.getAsNumber());
ASNumberRangeVO range =
asNumberRangeDao.findById(asn.getAsNumberRangeId());
-response.setAsNumberRangeId(range.getUuid());
-String rangeText = String.format("%s-%s", range.getStartASNumber(),
range.getEndASNumber());
-response.setAsNumberRange(rangeText);
+if (Objects.nonNull(range)) {
+response.setAsNumberRangeId(range.getUuid());
+String rangeText = String.format("%s-%s",
range.getStartASNumber(), range.getEndASNumber());
+response.setAsNumberRange(rangeText);
+} else {
+logger.info("is null for as number: "+ asn.getAsNumber());
Review Comment:
```suggestion
logger.info("Range is null for AS number: "+ asn.getAsNumber());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969304549
##
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/RemoveNodesFromKubernetesClusterCmd.java:
##
@@ -0,0 +1,126 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.kubernetes.cluster;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.kubernetes.cluster.KubernetesClusterEventTypes;
+import com.cloud.kubernetes.cluster.KubernetesClusterService;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.UserVmResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.List;
+
+@APICommand(name = "removeNodesFromKubernetesCluster",
+description = "Removes external nodes from a CKS cluster. ",
+responseObject = KubernetesClusterResponse.class,
+since = "4.21.0",
+authorized = {RoleType.Admin, RoleType.ResourceAdmin,
RoleType.DomainAdmin, RoleType.User})
+public class RemoveNodesFromKubernetesClusterCmd extends BaseAsyncCmd {
+
+@Inject
+public KubernetesClusterService kubernetesClusterService;
+
+protected static final Logger LOGGER =
LogManager.getLogger(RemoveNodesFromKubernetesClusterCmd.class);
+
+@Parameter(name = ApiConstants.NODE_IDS,
+type = CommandType.LIST,
+collectionType = CommandType.UUID,
+entityType= UserVmResponse.class,
+description = "comma separated list of node (physical or virtual
machines) IDs that need to be" +
+"removed from the Kubernetes cluster (CKS)",
+required = true,
+since = "4.21.0")
+private List nodeIds;
+
+@Parameter(name = ApiConstants.ID, type = CommandType.UUID, required =
true,
+entityType = KubernetesClusterResponse.class,
+description = "the ID of the Kubernetes cluster", since = "4.21.0")
Review Comment:
since not required for new param here, it is already mentioned in the cmd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969301277
##
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/CreateKubernetesClusterCmd.java:
##
@@ -144,6 +191,21 @@ public class CreateKubernetesClusterCmd extends
BaseAsyncCreateCmd {
@Parameter(name = ApiConstants.CLUSTER_TYPE, type = CommandType.STRING,
description = "type of the cluster: CloudManaged, ExternalManaged. The default
value is CloudManaged.", since="4.19.0")
private String clusterType;
+@Parameter(name = ApiConstants.HYPERVISOR, type = CommandType.STRING,
description = "the hypervisor on which the CKS cluster is to be deployed. This
is required if the zone in which the CKS cluster is being deployed has clusters
with different hypervisor types.")
Review Comment:
add since attribute for all new params in the cmd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969294463
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java:
##
@@ -574,14 +863,16 @@ public boolean startKubernetesClusterOnCreate() {
return true;
}
-public boolean startStoppedKubernetesCluster() throws
CloudRuntimeException {
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969256649
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterVO.java:
##
@@ -118,6 +118,33 @@ public class KubernetesClusterVO implements
KubernetesCluster {
@Column(name = "cluster_type")
private ClusterType clusterType;
+@Column(name = "control_service_offering_id")
+private Long controlServiceOfferingId;
+
+@Column(name = "worker_service_offering_id")
+private Long workerServiceOfferingId;
+
+@Column(name = "etcd_service_offering_id")
+private Long etcdServiceOfferingId;
Review Comment:
update to _control_node_*, worker_node_*, & etcd_node_*_, for better
readability/understanding - both service offering and template id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969256649
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterVO.java:
##
@@ -118,6 +118,33 @@ public class KubernetesClusterVO implements
KubernetesCluster {
@Column(name = "cluster_type")
private ClusterType clusterType;
+@Column(name = "control_service_offering_id")
+private Long controlServiceOfferingId;
+
+@Column(name = "worker_service_offering_id")
+private Long workerServiceOfferingId;
+
+@Column(name = "etcd_service_offering_id")
+private Long etcdServiceOfferingId;
Review Comment:
update to _control_node_*, worker_node_*, & etcd_node_*_, for better
readability/understanding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969253072
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java:
##
@@ -93,16 +110,48 @@ public interface KubernetesClusterService extends
PluggableService, Configurable
true,
ConfigKey.Scope.Account,
KubernetesServiceEnabled.key());
+static final ConfigKey KubernetesControlNodeInstallAttemptWait = new
ConfigKey("Advanced", Long.class,
+"cloud.kubernetes.control.node.install.attempt.wait.duration",
+"15",
+"Time in seconds for the installation process to wait before it
re-attempts",
+true,
+KubernetesServiceEnabled.key());
+static final ConfigKey KubernetesControlNodeInstallReattempts = new
ConfigKey("Advanced", Long.class,
+"cloud.kubernetes.control.node.install.reattempt.count",
+"100",
+"Number of times the offline installation of K8S will be
re-attempted",
+true,
+KubernetesServiceEnabled.key());
+final ConfigKey KubernetesWorkerNodeInstallAttemptWait = new
ConfigKey("Advanced", Long.class,
+"cloud.kubernetes.worker.node.install.attempt.wait.duration",
+"30",
+"Time in seconds for the installation process to wait before it
re-attempts",
+true,
+KubernetesServiceEnabled.key());
+static final ConfigKey KubernetesWorkerNodeInstallReattempts = new
ConfigKey("Advanced", Long.class,
+"cloud.kubernetes.worker.node.install.reattempt.count",
+"40",
+"Number of times the offline installation of K8S will be
re-attempted",
+true,
Review Comment:
same descriptions for control and worker nodes, can tag the node type in
description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969248561
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java:
##
@@ -80,6 +85,18 @@ public interface KubernetesClusterService extends
PluggableService, Configurable
"The number of retries if fail to upgrade kubernetes cluster due
to some reasons (e.g. drain node, etcdserver leader changed)",
true,
KubernetesServiceEnabled.key());
+static final ConfigKey KubernetesClusterAddNodeTimeout = new
ConfigKey("Advanced", Long.class,
+"cloud.kubernetes.cluster.add.node.timeout",
+"3600",
+"Timeout interval (in seconds) in which an external node(VM /
baremetal host) addition to a cluster should be completed",
+true,
+KubernetesServiceEnabled.key());
+static final ConfigKey KubernetesClusterRemoveNodeTimeout = new
ConfigKey("Advanced", Long.class,
+"cloud.kubernetes.cluster.add.node.timeout",
Review Comment:
```suggestion
"cloud.kubernetes.cluster.remove.node.timeout",
```
for remove node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969226632 ## api/src/main/java/org/apache/cloudstack/api/response/TemplateResponse.java: ## @@ -208,6 +208,11 @@ public class TemplateResponse extends BaseResponseWithTagInformation implements since = "4.15") private Boolean deployAsIs; +@SerializedName(ApiConstants.FOR_CKS) +@Param(description = "If true it indicates that the template can be used for CKS cluster deployments", +since = "4.20") Review Comment: ```suggestion since = "4.21.0") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969236460 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -635,6 +804,9 @@ public KubernetesClusterResponse createKubernetesClusterResponse(long kubernetes response.setMaxSize(kubernetesCluster.getMaxSize()); response.setClusterType(kubernetesCluster.getClusterType()); response.setCreated(kubernetesCluster.getCreated()); + + + Review Comment: extra white spaces not needed here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969218973
##
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/DeleteCniConfigurationCmd.java:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.userdata;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+
+@APICommand(name = "deleteCniConfiguration", description = "Deletes a CNI
Configuration", responseObject = SuccessResponse.class, entityType =
{UserData.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.21.0",
+authorized = {RoleType.Admin, RoleType.ResourceAdmin,
RoleType.DomainAdmin, RoleType.User})
+public class DeleteCniConfigurationCmd extends DeleteUserDataCmd {
+
+public static final Logger logger =
LogManager.getLogger(DeleteUserDataCmd.class.getName());
+
+
+/
+/// API Implementation///
+/
+
+@Override
+public void execute() {
+boolean result = _mgr.deleteCniConfiguration(this);
+if (result) {
+SuccessResponse response = new SuccessResponse(getCommandName());
+response.setSuccess(result);
+setResponseObject(response);
+} else {
+throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed
to delete userdata");
Review Comment:
```suggestion
throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
"Failed to delete CNI configuration");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1969219734
##
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/DeleteCniConfigurationCmd.java:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.userdata;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+
+@APICommand(name = "deleteCniConfiguration", description = "Deletes a CNI
Configuration", responseObject = SuccessResponse.class, entityType =
{UserData.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.21.0",
+authorized = {RoleType.Admin, RoleType.ResourceAdmin,
RoleType.DomainAdmin, RoleType.User})
+public class DeleteCniConfigurationCmd extends DeleteUserDataCmd {
+
+public static final Logger logger =
LogManager.getLogger(DeleteUserDataCmd.class.getName());
Review Comment:
```suggestion
public static final Logger logger =
LogManager.getLogger(DeleteCniConfigurationCmd.class.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2678308069 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2678153175 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2678148532 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2677332354 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2677325818 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2677325032 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1966986897
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -1591,28 +1921,47 @@ public boolean
scaleKubernetesCluster(ScaleKubernetesClusterCmd cmd) throws Clou
logAndThrow(Level.ERROR, "Kubernetes Service plugin is disabled");
}
validateKubernetesClusterScaleParameters(cmd);
-
KubernetesClusterVO kubernetesCluster =
kubernetesClusterDao.findById(cmd.getId());
-final Long clusterSize = cmd.getClusterSize();
-if (clusterSize != null) {
-CallContext.current().setEventDetails(String.format("Kubernetes
cluster ID: %s scaling from size: %d to %d",
-kubernetesCluster.getUuid(),
kubernetesCluster.getNodeCount(), clusterSize));
-}
+Map nodeToOfferingMap =
createNodeTypeToServiceOfferingMap(cmd.getServiceOfferingNodeTypeMap(),
cmd.getServiceOfferingId(), kubernetesCluster);
+
String[] keys = getServiceUserKeys(kubernetesCluster);
KubernetesClusterScaleWorker scaleWorker =
new
KubernetesClusterScaleWorker(kubernetesClusterDao.findById(cmd.getId()),
-serviceOfferingDao.findById(cmd.getServiceOfferingId()),
-clusterSize,
-cmd.getNodeIds(),
-cmd.isAutoscalingEnabled(),
-cmd.getMinSize(),
-cmd.getMaxSize(),
-this);
+nodeToOfferingMap,
+cmd.getClusterSize(),
+cmd.getNodeIds(),
+cmd.isAutoscalingEnabled(),
+cmd.getMinSize(),
+cmd.getMaxSize(),
+this);
Review Comment:
Good catch, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1966985838
##
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/CreateKubernetesClusterCmd.java:
##
@@ -81,7 +111,23 @@ public class CreateKubernetesClusterCmd extends
BaseAsyncCreateCmd {
@ACL(accessType = AccessType.UseEntry)
@Parameter(name = ApiConstants.SERVICE_OFFERING_ID, type =
CommandType.UUID, entityType = ServiceOfferingResponse.class,
description = "the ID of the service offering for the virtual
machines in the cluster.")
-private Long serviceOfferingId;
+protected Long serviceOfferingId;
+
+@ACL(accessType = AccessType.UseEntry)
+@Parameter(name = ApiConstants.NODE_TYPE_OFFERING_MAP, type =
CommandType.MAP,
+description = "(Optional) Node Type to Service Offering ID
mapping. If provided, it overrides the serviceofferingid parameter")
+protected Map> serviceOfferingNodeTypeMap;
+
+@ACL(accessType = AccessType.UseEntry)
+@Parameter(name = ApiConstants.NODE_TYPE_TEMPLATE_MAP, type =
CommandType.MAP,
+description = "(Optional) Node Type to Template ID mapping. If
provided, it overrides the default template: System VM template")
+protected Map> templateNodeTypeMap;
+
+@ACL(accessType = AccessType.UseEntry)
+@Parameter(name = ApiConstants.ETCD_NODES, type = CommandType.LONG,
+description = "(Optional) Number of Kubernetes cluster etcd nodes,
default is 0." +
+"In case the number is greater than 0, etcd nodes are
separate from master nodes and are provisioned accordingly")
+protected Long etcdNodes;
Review Comment:
Thanks, fixed, no need to be protected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1966983988
##
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/ListCniConfigurationCmd.java:
##
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.user.UserData;
+import com.cloud.utils.Pair;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.List;
+
+@APICommand(name = "listCniConfiguration", description = "List userdata for
CNI plugins", responseObject = UserDataResponse.class, entityType =
{UserData.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.20",
Review Comment:
Thanks @sureshanaparti, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
github-actions[bot] commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2642619137 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
bernardodemarco commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1943484373
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java:
##
@@ -795,8 +782,27 @@ protected String getKubernetesClusterNodeNamePrefix() {
return prefix;
}
+protected String getEtcdNodeNameForCluster() {
+String prefix = kubernetesCluster.getName();
+if (!NetUtils.verifyDomainNameLabel(prefix, true)) {
+prefix = prefix.replaceAll("[^a-zA-Z0-9-]", "");
+if (prefix.isEmpty()) {
+prefix = kubernetesCluster.getUuid();
+}
+}
+prefix = prefix + "-etcd" ;
+if (prefix.length() > 40) {
+prefix = prefix.substring(0, 40);
+}
+return prefix;
+}
+
protected KubernetesClusterVO updateKubernetesClusterEntry(final Long
cores, final Long memory, final Long size,
- final Long serviceOfferingId, final Boolean autoscaleEnabled,
final Long minSize, final Long maxSize) {
+ final Long
serviceOfferingId, final Boolean autoscaleEnabled,
+ final Long
minSize, final Long maxSize,
+ final
KubernetesClusterNodeType nodeType,
+ final boolean
updateNodeOffering,
+ final boolean
updateClusterOffering) {
return Transaction.execute((TransactionCallback)
status -> {
KubernetesClusterVO updatedCluster =
kubernetesClusterDao.createForUpdate(kubernetesCluster.getId());
Review Comment:
@nvazquez, here is how I locally fixed this issue:
```java
protected KubernetesClusterVO updateKubernetesClusterEntry(...) {
return
Transaction.execute((TransactionCallback) status -> {
KubernetesClusterVO updatedCluster =
kubernetesClusterDao.createForUpdate(kubernetesCluster.getId());
// (...)
kubernetesClusterDao.persist(updatedCluster);
return kubernetesClusterDao.findById(kubernetesCluster.getId());
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
bernardodemarco commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1942940914
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java:
##
@@ -293,13 +259,35 @@ protected DeployDestination plan(final long nodesCount,
final DataCenter zone, f
throw new InsufficientServerCapacityException(msg, DataCenter.class,
zone.getId());
}
-protected DeployDestination plan() throws
InsufficientServerCapacityException {
-ServiceOffering offering =
serviceOfferingDao.findById(kubernetesCluster.getServiceOfferingId());
+/**
+ * Plan Kubernetes Cluster Deployment
+ * @return a map of DeployDestination per node type
+ */
+protected Map planKubernetesCluster(Long
domainId, Long accountId, Hypervisor.HypervisorType hypervisorType) throws
InsufficientServerCapacityException {
+Map destinationMap = new HashMap<>();
DataCenter zone =
dataCenterDao.findById(kubernetesCluster.getZoneId());
if (logger.isDebugEnabled()) {
logger.debug("Checking deployment destination for Kubernetes
cluster: {} in zone: {}", kubernetesCluster, zone);
}
-return plan(kubernetesCluster.getTotalNodeCount(), zone, offering);
+long controlNodeCount = kubernetesCluster.getControlNodeCount();
+long clusterSize = kubernetesCluster.getNodeCount();
+long etcdNodes = kubernetesCluster.getEtcdNodeCount();
+Map nodeTypeCount = Map.of(WORKER.name(), clusterSize,
+CONTROL.name(), controlNodeCount, ETCD.name(), etcdNodes);
+
+for (KubernetesClusterNodeType nodeType : CLUSTER_NODES_TYPES_LIST) {
+Long nodes = nodeTypeCount.getOrDefault(nodeType.name(),
kubernetesCluster.getServiceOfferingId());
+if (nodes == null || nodes == 0) {
+continue;
+}
+ServiceOffering nodeOffering =
getServiceOfferingForNodeTypeOnCluster(nodeType, kubernetesCluster);
+if (logger.isDebugEnabled()) {
+logger.debug(String.format("Checking deployment destination
for %s nodes on Kubernetes cluster : %s in zone : %s", nodeType.name(),
kubernetesCluster.getName(), zone.getName()));
+}
Review Comment:
```suggestion
if (logger.isDebugEnabled()) {
logger.debug("Checking deployment destination for {} nodes
on Kubernetes cluster : {} in zone : {}", nodeType.name(),
kubernetesCluster.getName(), zone.getName());
}
```
##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesServiceHelperImpl.java:
##
@@ -106,6 +120,127 @@ public void checkVmCanBeDestroyed(UserVm userVm) {
throw new CloudRuntimeException(msg);
}
+@Override
+public boolean isValidNodeType(String nodeType) {
+if (StringUtils.isBlank(nodeType)) {
+return false;
+}
+try {
+KubernetesClusterNodeType.valueOf(nodeType.toUpperCase());
+return true;
+} catch (IllegalArgumentException e) {
+return false;
+}
+}
+
+@Override
+public Map getServiceOfferingNodeTypeMap(Map> serviceOfferingNodeTypeMap) {
+Map mapping = new HashMap<>();
+if (MapUtils.isNotEmpty(serviceOfferingNodeTypeMap)) {
+for (Map entry :
serviceOfferingNodeTypeMap.values()) {
+processNodeTypeOfferingEntryAndAddToMappingIfValid(entry,
mapping);
+}
+}
+return mapping;
+}
+
+protected void checkNodeTypeOfferingEntryCompleteness(String nodeTypeStr,
String serviceOfferingUuid) {
+if (StringUtils.isAnyEmpty(nodeTypeStr, serviceOfferingUuid)) {
+String error = String.format("Incomplete Node Type to Service
Offering ID mapping: '%s' -> '%s'", nodeTypeStr, serviceOfferingUuid);
+logger.error(error);
+throw new InvalidParameterValueException(error);
+}
+}
+
+protected void checkNodeTypeOfferingEntryValues(String nodeTypeStr,
ServiceOffering serviceOffering, String serviceOfferingUuid) {
+if (!isValidNodeType(nodeTypeStr)) {
+String error = String.format("The provided value '%s' for Node
Type is invalid", nodeTypeStr);
+logger.error(error);
+throw new InvalidParameterValueException(String.format(error));
+}
+if (serviceOffering == null) {
+String error = String.format("Cannot find a service offering with
ID %s", serviceOfferingUuid);
+logger.error(error);
+throw new InvalidParameterValueException(error);
+}
+}
+
+protected void addNodeTypeOfferingEntry(String nodeTypeStr, String
serviceOfferingUuid, ServiceOffering serviceOffering, Map
mapping) {
+if (logger.isDebugEnabled
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1942785562
##
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/ListCniConfigurationCmd.java:
##
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.user.UserData;
+import com.cloud.utils.Pair;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.ArrayList;
+import java.util.List;
+
+@APICommand(name = "listCniConfiguration", description = "List userdata for
CNI plugins", responseObject = UserDataResponse.class, entityType =
{UserData.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.20",
Review Comment:
hi @nvazquez if this is targeted for 4.21.0, check & update since version to
4.21.0 wherever applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1942777923
##
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/DeleteCniConfigurationCmd.java:
##
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.userdata;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+
+@APICommand(name = "deleteCniConfiguration", description = "Deletes a CNI
Configuration", responseObject = SuccessResponse.class, entityType =
{UserData.class},
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.19",
Review Comment:
```suggestion
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.21.0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1942773865
##
api/src/main/java/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java:
##
@@ -168,6 +168,11 @@ public class RegisterTemplateCmd extends BaseCmd
implements UserCmd {
description = "(VMware only) true if VM deployments should
preserve all the configurations defined for this template", since = "4.15.1")
protected Boolean deployAsIs;
+@Parameter(name=ApiConstants.FOR_CKS,
+type = CommandType.BOOLEAN,
+description = "if true, the templates would be available for
deploying CKS clusters", since = "4.20.0")
Review Comment:
```suggestion
description = "if true, the templates would be available for
deploying CKS clusters", since = "4.21.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
sureshanaparti commented on code in PR #9102:
URL: https://github.com/apache/cloudstack/pull/9102#discussion_r1942759013
##
api/src/main/java/com/cloud/server/ManagementService.java:
##
@@ -360,17 +362,23 @@ public interface ManagementService {
*The api command class.
* @return The list of userdatas found.
*/
-Pair, Integer> listUserDatas(ListUserDataCmd cmd);
+Pair, Integer> listUserDatas(ListUserDataCmd cmd,
boolean forCks);
+
+/**
+ * Registers a cni configuration.
+ *
+ * @param cmdThe api command class.
+ * @return A VO with the registered userdata.
+ */
+UserData registerCniConfigration(RegisterCniConfigurationCmd cmd);
Review Comment:
```suggestion
UserData registerCniConfiguration(RegisterCniConfigurationCmd cmd);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2636225209 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2636067122 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
rohityadavcloud commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2636064053 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2633676624 [SF] Trillian test result (tid-12285) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 78949 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12285-xcpng82.zip Smoke tests completed. 133 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 161.44 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 185.47 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.31 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.44 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.44 | test_ipv4_routing.py test_01_prepare_and_cancel_maintenance | `Error` | 0.10 | test_ms_maintenance_and_safe_shutdown.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 10.66 | test_network.py test_01_non_strict_host_anti_affinity | `Error` | 219.41 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 113.39 | test_nonstrict_affinity_group.py test_02_create_volume | `Error` | 4.26 | test_resource_names.py test_05_scale_vm_dont_allow_disk_offering_change | `Failure` | 72.58 | test_scale_vm.py test_12_start_vm_multiple_volumes_allocated | `Error` | 19.05 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2633243428 [SF] Trillian test result (tid-12283) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 67593 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12283-vmware-70u3.zip Smoke tests completed. 132 look OK, 9 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.29 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.41 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.41 | test_ipv4_routing.py test_deploy_more_vms_than_limit_allows | `Error` | 163.26 | test_deploy_vms_in_parallel.py test_01_prepare_and_cancel_maintenance | `Error` | 0.11 | test_ms_maintenance_and_safe_shutdown.py test_01_deployVMInSharedNetwork | `Failure` | 3.42 | test_network.py ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown | `Error` | 4.49 | test_network.py test_01_restore_vm | `Error` | 7.55 | test_restore_vm.py test_02_restore_vm_with_disk_offering | `Error` | 4.50 | test_restore_vm.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 7.50 | test_restore_vm.py test_04_restore_vm_allocated_root | `Error` | 8.73 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 20.23 | test_restore_vm.py test_01_deploy_vm_on_specific_host | `Error` | 4.35 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 4.32 | test_vm_deployment_planner.py test_03_deploy_vm_on_specific_pod | `Error` | 4.37 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.38 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.29 | test_vm_deployment_planner.py test_12_start_vm_multiple_volumes_allocated | `Error` | 16.97 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 8.86 | test_vm_strict_host_tags.py test_02_migrate_vm_strict_tags_failure | `Error` | 5.74 | test_vm_strict_host_tags.py test_01_restore_vm_strict_tags_success | `Error` | 8.80 | test_vm_strict_host_tags.py test_02_restore_vm_strict_tags_failure | `Error` | 8.84 | test_vm_strict_host_tags.py test_01_scale_vm_strict_tags_success | `Error` | 8.81 | test_vm_strict_host_tags.py test_02_scale_vm_strict_tags_failure | `Error` | 5.71 | test_vm_strict_host_tags.py test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 8.85 | test_vm_strict_host_tags.py test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 11.80 | test_vm_strict_host_tags.py test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 8.85 | test_vm_strict_host_tags.py test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 8.81 | test_vm_strict_host_tags.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 29.66 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 226.28 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2633103731 [SF] Trillian test result (tid-12284) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 63530 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12284-kvm-ubuntu22.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.34 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.46 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.46 | test_ipv4_routing.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.81 | test_outofbandmanagement.py test_12_start_vm_multiple_volumes_allocated | `Error` | 20.27 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2632933869 [SF] Trillian test result (tid-12282) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56384 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12282-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.27 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.35 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.36 | test_ipv4_routing.py test_12_start_vm_multiple_volumes_allocated | `Error` | 14.93 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2630989664 @nvazquez a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2630986309 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2630979371 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2630733775 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2630735468 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
github-actions[bot] commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2620941627 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
github-actions[bot] commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2596338374 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2592095247 [SF] Trillian test result (tid-12104) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 78075 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12104-vmware-70u3.zip Smoke tests completed. 137 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.30 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.44 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.44 | test_ipv4_routing.py test_list_vms_metrics_admin | `Error` | 3621.90 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 7.78 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 3620.08 | test_metrics_api.py test_01_deployVMInSharedNetwork | `Failure` | 3609.63 | test_network.py ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown | `Error` | 3610.84 | test_network.py test_02_restore_vm_with_disk_offering | `Error` | 61.21 | test_restore_vm.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 59.22 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2591901074 [SF] Trillian test result (tid-12105) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 74447 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12105-xcpng82.zip Smoke tests completed. 135 look OK, 6 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 170.32 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 179.74 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 1.27 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.37 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.38 | test_ipv4_routing.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 7.53 | test_network.py test_01_non_strict_host_anti_affinity | `Error` | 225.89 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 111.15 | test_nonstrict_affinity_group.py test_02_create_volume | `Error` | 4.24 | test_resource_names.py test_05_scale_vm_dont_allow_disk_offering_change | `Failure` | 68.57 | test_scale_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2591549440 [SF] Trillian test result (tid-12103) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 56042 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12103-kvm-ubuntu22.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.31 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.41 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.41 | test_ipv4_routing.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.77 | test_outofbandmanagement.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2591517770 [SF] Trillian test result (tid-12102) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53466 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12102-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.33 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 4.47 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 4.47 | test_ipv4_routing.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2589615016 @nvazquez a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2589611105 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2589133154 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2589014298 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2589013358 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-258900 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-254019 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2588879879 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2588814162 [SF] Trillian test result (tid-12093) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 77570 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12093-vmware-70u3.zip Smoke tests completed. 136 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.28 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.38 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.38 | test_ipv4_routing.py ContextSuite context=TestKubernetesCluster>:setup | `Error` | 0.00 | test_kubernetes_clusters.py test_list_vms_metrics_admin | `Error` | 3625.04 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 3618.78 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 3621.72 | test_metrics_api.py test_01_deployVMInSharedNetwork | `Failure` | 3603.93 | test_network.py ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown | `Error` | 3605.18 | test_network.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 58.17 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2588482516 [SF] Trillian test result (tid-12091) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 66849 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12091-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.31 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.36 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.36 | test_ipv4_routing.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2588281544 [SF] Trillian test result (tid-12092) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 58703 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12092-kvm-ubuntu22.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 1.27 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.40 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.40 | test_ipv4_routing.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.79 | test_outofbandmanagement.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2586192334 [SF] Trillian Build Failed (tid-12094) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2586171350 @nvazquez a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2586169734 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2586156388 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2586107839 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2586107162 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
bernardodemarco commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2585384657 > Thanks for your review @bernardodemarco I've addressed all the comments except the scale cluster one which I'm currently working on. I have also included the rest of the missing functionalities and started a design document with a more detailed explanation which I'll complete in the following days: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CKS+Enhancements Nice, I'll review it again in the next days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2581424530 [SF] Trillian test result (tid-12066) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 65306 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9102-t12066-kvm-ol8.zip Smoke tests completed. 137 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_provision_certificate | `Error` | 80.92 | test_certauthority_root.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.28 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.36 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.36 | test_ipv4_routing.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 623.00 | test_kubernetes_clusters.py test_05_vmschedule_test_e2e | `Failure` | 362.20 | test_vm_schedule.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2579153348 @nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2579152929 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
