Re: [PR] Clarify KVM import template requirement [cloudstack]
sonarqubecloud[bot] commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4569691907 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13126) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13126&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13126&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=13126&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13126&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13126&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13126) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
andrijapanicsb commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4569445438 > @andrijapanicsb the text on the description looks good, IMO the API must also check the hypervisor type and the importing operation and fail in case it is not passed for KVM import unmanaged instance. In the UI for Migrating from VMware to KVM etc - there is no option to even select a template - seems we always (or UI does ot) assign the dummy template https://github.com/user-attachments/assets/932e30b9-ebf0-4051-acc2-2ec004a59b1b"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
andrijapanicsb commented on code in PR #13126:
URL: https://github.com/apache/cloudstack/pull/13126#discussion_r3321387036
##
api/src/test/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmdTest.java:
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vm;
+
+import java.lang.reflect.Field;
+
+import org.apache.cloudstack.api.Parameter;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class ImportUnmanagedInstanceCmdTest {
+
+@Test
+public void testTemplateIdDescriptionMentionsKvmRequirement() throws
NoSuchFieldException {
+Field templateIdField =
ImportUnmanagedInstanceCmd.class.getDeclaredField("templateId");
+Parameter parameter = templateIdField.getAnnotation(Parameter.class);
+
+Assert.assertNotNull(parameter);
+Assert.assertTrue(parameter.description().contains("Required when
importing an unmanaged KVM Instance."));
Review Comment:
Deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
nvazquez commented on code in PR #13126:
URL: https://github.com/apache/cloudstack/pull/13126#discussion_r3317244999
##
api/src/test/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmdTest.java:
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vm;
+
+import java.lang.reflect.Field;
+
+import org.apache.cloudstack.api.Parameter;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class ImportUnmanagedInstanceCmdTest {
+
+@Test
+public void testTemplateIdDescriptionMentionsKvmRequirement() throws
NoSuchFieldException {
+Field templateIdField =
ImportUnmanagedInstanceCmd.class.getDeclaredField("templateId");
+Parameter parameter = templateIdField.getAnnotation(Parameter.class);
+
+Assert.assertNotNull(parameter);
+Assert.assertTrue(parameter.description().contains("Required when
importing an unmanaged KVM Instance."));
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
DaanHoogland commented on code in PR #13126:
URL: https://github.com/apache/cloudstack/pull/13126#discussion_r3304210653
##
api/src/test/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmdTest.java:
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vm;
+
+import java.lang.reflect.Field;
+
+import org.apache.cloudstack.api.Parameter;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class ImportUnmanagedInstanceCmdTest {
+
+@Test
+public void testTemplateIdDescriptionMentionsKvmRequirement() throws
NoSuchFieldException {
+Field templateIdField =
ImportUnmanagedInstanceCmd.class.getDeclaredField("templateId");
+Parameter parameter = templateIdField.getAnnotation(Parameter.class);
+
+Assert.assertNotNull(parameter);
+Assert.assertTrue(parameter.description().contains("Required when
importing an unmanaged KVM Instance."));
Review Comment:
this is testing static code. not sure if we need this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4544540890 [SF] Trillian test result (tid-16173) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 50487 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13126-t16173-kvm-ol8.zip Smoke tests completed. 151 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
andrijapanicsb commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4537719549 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4537723108 @andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4467977327 [SF] Trillian test result (tid-16103) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 80792 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13126-t16103-kvm-ol8.zip Smoke tests completed. 146 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_vm_backup_create_vm_from_backup | `Failure` | 607.89 | test_backup_recovery_nas.py test_vm_backup_lifecycle | `Error` | 0.11 | test_backup_recovery_nas.py ContextSuite context=TestSharedFSLifecycle>:setup | `Error` | 0.00 | test_sharedfs_lifecycle.py test_10_attachAndDetach_iso | `Failure` | 607.19 | test_vm_life_cycle.py test_01_create_vm_snapshots | `Failure` | 606.85 | test_vm_snapshots.py test_02_revert_vm_snapshots | `Failure` | 600.71 | test_vm_snapshots.py test_03_delete_vm_snapshots | `Failure` | 0.02 | test_vm_snapshots.py test_01_create_volume | `Failure` | 611.47 | test_volumes.py test_01_root_volume_encryption | `Failure` | 696.11 | test_volumes.py test_02_data_volume_encryption | `Failure` | 637.86 | test_volumes.py test_03_root_and_data_volume_encryption | `Failure` | 659.05 | test_volumes.py test_02_attach_volume | `Failure` | 1267.43 | test_volumes.py test_02_attach_volume | `Failure` | 1267.45 | test_volumes.py test_03_download_attached_volume | `Failure` | 663.81 | test_volumes.py test_04_delete_attached_volume | `Failure` | 666.64 | test_volumes.py test_05_detach_volume | `Failure` | 751.52 | test_volumes.py test_06_download_detached_volume | `Failure` | 844.95 | test_volumes.py test_07_resize_fail | `Failure` | 658.48 | test_volumes.py test_08_resize_volume | `Failure` | 664.01 | test_volumes.py test_09_delete_detached_volume | `Failure` | 661.88 | test_volumes.py test_10_list_volumes | `Failure` | 658.37 | test_volumes.py test_11_attach_volume_with_unstarted_vm | `Failure` | 761.39 | test_volumes.py test_12_resize_volume_with_only_size_parameter | `Failure` | 663.91 | test_volumes.py test_13_migrate_volume_and_change_offering | `Failure` | 793.20 | test_volumes.py test_14_delete_volume_delete_protection | `Failure` | 666.96 | test_volumes.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4463521412 @andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
andrijapanicsb commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4463507207 @blueorangutan test ol8 kvm-ol8 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4446071198 @andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
andrijapanicsb commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4446067206 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4402240170 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
blueorangutan commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4401911391 @andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled withkvm SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
andrijapanicsb commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4401903899 @blueorangutan package kvm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
sonarqubecloud[bot] commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4399464258 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13126) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13126&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13126&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=13126&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13126&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13126&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13126) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Clarify KVM import template requirement [cloudstack]
codecov[bot] commented on PR #13126: URL: https://github.com/apache/cloudstack/pull/13126#issuecomment-4399034041 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13126?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.52%. Comparing base ([`f6efda5`](https://app.codecov.io/gh/apache/cloudstack/commit/f6efda50d2f6fd27179e6d9b105081b1a828967d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3de13b0`](https://app.codecov.io/gh/apache/cloudstack/commit/3de13b0d6464540578a85051f04714df6d6e319e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (f6efda5) and HEAD (3de13b0). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (f6efda5) | HEAD (3de13b0) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13126 +/- ## = - Coverage 18.09%3.52% -14.57% = Files 6037 464 -5573 Lines54254640151 -502395 Branches 66431 7557-58874 = - Hits 98159 1415-96744 + Misses 43336838548 -394820 + Partials 11019 188-10831 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13126/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.52% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/13126?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
