Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-29 Thread via GitHub
rohityadavcloud merged PR #8977: URL: https://github.com/apache/cloudstack/pull/8977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080335049 [SF] Trillian test result (tid-10054) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48698 seconds Marvin logs:

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080246212 [SF] Trillian test result (tid-10050) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45290 seconds Marvin logs:

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079323373 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079320521 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079221418 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9443 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079155754 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
sureshanaparti commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079153429 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079133328 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9439 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
borisstoyanov commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079104980 Thanks @vishesh92, let's wait the smoketests to come out and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079101196 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079099122 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078987029 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078986149 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078978369 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9438 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078835575 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078834393 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
sureshanaparti commented on code in PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#discussion_r1580544655 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -7909,7 +7909,7 @@ public Pair doInTransaction(final TransactionStatus status) th

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-25 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077498151 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9428 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-25 Thread via GitHub
codecov-commenter commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077347864 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-25 Thread via GitHub
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077268490 code looks good @vishesh92 Can you add 1-2 lines to one of the existing integration tests to cover this test case (restore vm twice)? -- This is an automated

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-25 Thread via GitHub
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077233309 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-25 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077234570 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.