Re: [PR] Fix snapshot chaining on Xen [cloudstack]
sureshanaparti merged PR #12597: URL: https://github.com/apache/cloudstack/pull/12597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4217357645 [SF] Trillian test result (tid-15832) Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 57258 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12597-t15832-xcpng83.zip Smoke tests completed. 142 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 151.30 | test_events_resource.py test_01_non_strict_host_anti_affinity | `Error` | 144.18 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 44.24 | test_nonstrict_affinity_group.py test_02_list_snapshots_with_removed_data_store | `Error` | 10.73 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 10.74 | test_snapshots.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py test_01_vpn_usage | `Error` | 0.04 | test_usage.py test_11_destroy_vm_and_volumes | `Error` | 13.92 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 45.05 | test_vm_strict_host_tags.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4211371068 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng83) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
sureshanaparti commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4211367168 @blueorangutan test ol8 xcpng83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4181335766 [SF] Trillian test result (tid-15807) Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 63218 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12597-t15807-xcpng83.zip Smoke tests completed. 133 look OK, 9 have errors, 7 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 166.25 | test_events_resource.py test_list_system_vms_metrics_history | `Failure` | 0.22 | test_metrics_api.py test_list_vms_metrics_history | `Failure` | 157.98 | test_metrics_api.py test_01_non_strict_host_anti_affinity | `Error` | 154.24 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 66.05 | test_nonstrict_affinity_group.py test_06_disk_offering_strictness_false | `Failure` | 629.82 | test_service_offerings.py test_02_list_snapshots_with_removed_data_store | `Error` | 12.67 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 12.67 | test_snapshots.py test_01_vpn_usage | `Error` | 1.11 | test_usage.py test_01_scale_up_verify | `Failure` | 516.62 | test_vm_autoscaling.py test_02_update_vmprofile_and_vmgroup | `Failure` | 258.07 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Failure` | 425.57 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Error` | 425.58 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Failure` | 413.02 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Error` | 413.03 | test_vm_autoscaling.py ContextSuite context=TestVmAutoScaling>:teardown | `Error` | 459.00 | test_vm_autoscaling.py test_11_destroy_vm_and_volumes | `Error` | 25.04 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 61.32 | test_vm_strict_host_tags.py all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
JoaoJandre commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4178071201 Thanks for testing @vladimirpetrov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4175246928 @vladimirpetrov a [SL] Trillian-Jenkins test job (ol9 mgmt + xcpng83) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
vladimirpetrov commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4175244527 @blueorangutan test ol9 xcpng83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4090217240 [SF] Trillian test result (tid-15689) Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 69299 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12597-t15689-xcpng83.zip Smoke tests completed. 141 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 158.17 | test_events_resource.py test_list_system_vms_metrics_history | `Failure` | 0.21 | test_metrics_api.py test_list_vms_metrics_history | `Failure` | 162.74 | test_metrics_api.py test_01_non_strict_host_anti_affinity | `Error` | 160.26 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 62.62 | test_nonstrict_affinity_group.py test_02_list_snapshots_with_removed_data_store | `Error` | 14.70 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 14.70 | test_snapshots.py test_01_vpn_usage | `Error` | 1.10 | test_usage.py test_01_scale_up_verify | `Failure` | 466.28 | test_vm_autoscaling.py test_02_update_vmprofile_and_vmgroup | `Failure` | 253.79 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Failure` | 363.09 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Error` | 363.09 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Failure` | 391.30 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Error` | 391.31 | test_vm_autoscaling.py ContextSuite context=TestVmAutoScaling>:teardown | `Error` | 429.87 | test_vm_autoscaling.py test_11_destroy_vm_and_volumes | `Error` | 20.91 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 70.20 | test_vm_strict_host_tags.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4084469438 @nvazquez a [SL] Trillian-Jenkins test job (ol9 mgmt + xcpng83) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
nvazquez commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4084115688 @blueorangutan test ol9 xcpng83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4083844751 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4060248962 [SF] Trillian test result (tid-15652) Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 62267 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12597-t15652-xcpng83.zip Smoke tests completed. 140 look OK, 9 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 135.40 | test_events_resource.py test_07_arping_in_vr | `Failure` | 5.22 | test_diagnostics.py test_list_system_vms_metrics_history | `Failure` | 0.26 | test_metrics_api.py test_list_vms_metrics_history | `Failure` | 144.37 | test_metrics_api.py test_01_non_strict_host_anti_affinity | `Error` | 162.76 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 74.30 | test_nonstrict_affinity_group.py test_02_list_snapshots_with_removed_data_store | `Error` | 9.67 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 9.68 | test_snapshots.py test_01_scale_up_verify | `Failure` | 466.41 | test_vm_autoscaling.py test_02_update_vmprofile_and_vmgroup | `Failure` | 258.03 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Failure` | 355.36 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Error` | 355.37 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Failure` | 361.94 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Error` | 361.95 | test_vm_autoscaling.py ContextSuite context=TestVmAutoScaling>:teardown | `Error` | 373.14 | test_vm_autoscaling.py test_11_destroy_vm_and_volumes | `Error` | 21.01 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 120.90 | test_vm_strict_host_tags.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 668.97 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
nvazquez commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4056437122 @blueorangutan test ol9 xcpng83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4056428864 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4056443443 @nvazquez a [SL] Trillian-Jenkins test job (ol9 mgmt + xcpng83) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4055978985 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
nvazquez commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4055967963 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
JoaoJandre commented on code in PR #12597:
URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2931252596
##
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java:
##
@@ -387,6 +400,15 @@ public SnapshotDataStoreVO
findBySnapshotIdAndDataStoreRoleAndState(long snapsho
return findOneBy(sc);
}
+@Override
+public List
findBySnapshotIdAndDataStoreRoleAndStateIn(long snapshotId, DataStoreRole role,
State... state) {
Review Comment:
You're correct, I'll refactor it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
github-actions[bot] commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4053610758 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
sureshanaparti commented on code in PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2922907447 ## engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java: ## @@ -68,6 +68,9 @@ public class SnapshotDataStoreDaoImpl extends GenericDaoBase searchFilteringStoreIdEqStateEqStoreRoleEqIdEqUpdateCountEqSnapshotIdEqVolumeIdEq; private SearchBuilder stateSearch; private SearchBuilder idStateNeqSearch; + +private SearchBuilder idStateNinSearch; Review Comment: @JoaoJandre changes here would conflict (rebase if it is merged) - https://github.com/apache/cloudstack/pull/12789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4040147361 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
nvazquez commented on code in PR #12597:
URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2918717117
##
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java:
##
@@ -387,6 +400,15 @@ public SnapshotDataStoreVO
findBySnapshotIdAndDataStoreRoleAndState(long snapsho
return findOneBy(sc);
}
+@Override
+public List
findBySnapshotIdAndDataStoreRoleAndStateIn(long snapshotId, DataStoreRole role,
State... state) {
Review Comment:
Very minor: usually with `findBy..` methods we would expect one item to be
retrieved, in this case I think `listBy..` would be more suitable for this
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
nvazquez commented on code in PR #12597:
URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2918717117
##
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java:
##
@@ -387,6 +400,15 @@ public SnapshotDataStoreVO
findBySnapshotIdAndDataStoreRoleAndState(long snapsho
return findOneBy(sc);
}
+@Override
+public List
findBySnapshotIdAndDataStoreRoleAndStateIn(long snapshotId, DataStoreRole role,
State... state) {
Review Comment:
Very minor: usually with `find` methods we would expect one item to be
retrieved, in this case I think `list` would be more suitable for this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4039568525 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
nvazquez commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-4039559085 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3929337322 [SF] Trillian Build Failed (tid-15502) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3929041667 @sureshanaparti a [SL] Trillian-Jenkins test job (ol9 mgmt + xcpng83) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
sureshanaparti commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3929031251 @blueorangutan test ol9 xcpng83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3927492549 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
JoaoJandre commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3926998738 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-392770 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
JoaoJandre commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3926997573 @DaanHoogland can we rerun the tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3859460964 [SF] Trillian test result (tid-15385) Environment: xcpng83 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 67313 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12597-t15385-xcpng83.zip Smoke tests completed. 137 look OK, 12 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 147.58 | test_events_resource.py test_list_system_vms_metrics_history | `Failure` | 0.21 | test_metrics_api.py test_list_vms_metrics_history | `Failure` | 185.20 | test_metrics_api.py test_01_non_strict_host_anti_affinity | `Error` | 187.25 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 49.96 | test_nonstrict_affinity_group.py test_01_add_primary_storage_disabled_host | `Error` | 15.41 | test_primary_storage.py test_01_primary_storage_iscsi | `Error` | 0.16 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.16 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | test_primary_storage.py test_02_list_snapshots_with_removed_data_store | `Error` | 12.59 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 12.59 | test_snapshots.py test_01_scale_up_verify | `Failure` | 436.03 | test_vm_autoscaling.py test_02_update_vmprofile_and_vmgroup | `Failure` | 253.78 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Failure` | 376.08 | test_vm_autoscaling.py test_06_autoscaling_vmgroup_on_project_network | `Error` | 376.08 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Failure` | 383.82 | test_vm_autoscaling.py test_07_autoscaling_vmgroup_on_vpc_network | `Error` | 383.84 | test_vm_autoscaling.py ContextSuite context=TestVmAutoScaling>:teardown | `Error` | 422.26 | test_vm_autoscaling.py test_01_deploy_vm_on_specific_host | `Error` | 0.09 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.13 | test_vm_deployment_planner.py test_08_migrate_vm | `Error` | 0.07 | test_vm_life_cycle.py test_11_destroy_vm_and_volumes | `Error` | 17.91 | test_vm_life_cycle.py test_12_start_vm_multiple_volumes_allocated | `Error` | 56.36 | test_vm_life_cycle.py test_13_destroy_and_expunge_vm | `Error` | 4.63 | test_vm_life_cycle.py test_01_migrate_vm_strict_tags_success | `Error` | 0.21 | test_vm_strict_host_tags.py test_02_migrate_vm_strict_tags_failure | `Error` | 0.20 | test_vm_strict_host_tags.py test_01_restore_vm_strict_tags_success | `Error` | 0.18 | test_vm_strict_host_tags.py test_02_restore_vm_strict_tags_failure | `Error` | 0.24 | test_vm_strict_host_tags.py test_01_scale_vm_strict_tags_success | `Error` | 0.25 | test_vm_strict_host_tags.py test_02_scale_vm_strict_tags_failure | `Error` | 0.30 | test_vm_strict_host_tags.py test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 0.20 | test_vm_strict_host_tags.py test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 2.51 | test_vm_strict_host_tags.py test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 0.25 | test_vm_strict_host_tags.py test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 5.78 | test_vm_strict_host_tags.py test_05_deploy_vm_on_specific_host_with_strict_tags_failure | `Failure` | 0.21 | test_vm_strict_host_tags.py test_01_verify_ipv6_vpc | `Error` | 158.66 | test_vpc_ipv6.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 357.76 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 357.79 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 232.72 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 232.74 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 238.72 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 238.74 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 236.99 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 237.01 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 187.57 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3854277469 @DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + xcpng83) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
DaanHoogland commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3854239204 @blueorangutan test ol9 xcpng83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3854005698 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853624035 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
JoaoJandre commented on code in PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2769127335 ## engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java: ## @@ -151,6 +154,16 @@ public boolean configure(String name, Map params) throws Configu idStateNeqSearch.and(STATE, idStateNeqSearch.entity().getState(), SearchCriteria.Op.NEQ); idStateNeqSearch.done(); +idStateNinSearch = createSearchBuilder(); +idStateNinSearch.and(SNAPSHOT_ID, idStateNinSearch.entity().getSnapshotId(), SearchCriteria.Op.EQ); +idStateNinSearch.and(STATE, idStateNinSearch.entity().getState(), SearchCriteria.Op.NOTIN); +idStateNinSearch.done(); + +idEqRoleEqStateInSearch = createSearchBuilder(); +idEqRoleEqStateInSearch.and(SNAPSHOT_ID, idEqRoleEqStateInSearch.entity().getSnapshotId(), SearchCriteria.Op.EQ); +idEqRoleEqStateInSearch.and(STORE_ROLE, idEqRoleEqStateInSearch.entity().getRole(), SearchCriteria.Op.EQ); +idEqRoleEqStateInSearch.and(STATE, idEqRoleEqStateInSearch.entity().getState(), SearchCriteria.Op.IN); Review Comment: the `.create()` already calls `finalize()` (which is what `done()` does). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
JoaoJandre commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853612175 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853546564 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
Copilot commented on code in PR #12597:
URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2769024944
##
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java:
##
@@ -120,7 +120,7 @@ public class DefaultSnapshotStrategy extends
SnapshotStrategyBase {
private final List snapshotStatesAbleToDeleteSnapshot =
Arrays.asList(Snapshot.State.Destroying, Snapshot.State.Destroyed,
Snapshot.State.Error, Snapshot.State.Hidden);
public SnapshotDataStoreVO getSnapshotImageStoreRef(long snapshotId, long
zoneId) {
-List snaps =
snapshotStoreDao.listReadyBySnapshot(snapshotId, DataStoreRole.Image);
+List snaps =
snapshotStoreDao.findBySnapshotIdAndDataStoreRoleAndStateIn(snapshotId,
DataStoreRole.Image, State.Ready, State.Hidden);
Review Comment:
The tests mock `listReadyBySnapshot` but the actual implementation now uses
`findBySnapshotIdAndDataStoreRoleAndStateIn`. The mocking in the tests needs to
be updated to match the new method call. This will cause test failures as the
mock won't be triggered with the current setup.
```suggestion
List snaps =
snapshotStoreDao.listReadyBySnapshot(snapshotId, DataStoreRole.Image);
if (CollectionUtils.isEmpty(snaps)) {
snaps =
snapshotStoreDao.findBySnapshotIdAndDataStoreRoleAndStateIn(snapshotId,
DataStoreRole.Image, State.Ready, State.Hidden);
}
```
##
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java:
##
@@ -151,6 +154,16 @@ public boolean configure(String name, Map
params) throws Configu
idStateNeqSearch.and(STATE, idStateNeqSearch.entity().getState(),
SearchCriteria.Op.NEQ);
idStateNeqSearch.done();
+idStateNinSearch = createSearchBuilder();
+idStateNinSearch.and(SNAPSHOT_ID,
idStateNinSearch.entity().getSnapshotId(), SearchCriteria.Op.EQ);
+idStateNinSearch.and(STATE, idStateNinSearch.entity().getState(),
SearchCriteria.Op.NOTIN);
+idStateNinSearch.done();
+
+idEqRoleEqStateInSearch = createSearchBuilder();
+idEqRoleEqStateInSearch.and(SNAPSHOT_ID,
idEqRoleEqStateInSearch.entity().getSnapshotId(), SearchCriteria.Op.EQ);
+idEqRoleEqStateInSearch.and(STORE_ROLE,
idEqRoleEqStateInSearch.entity().getRole(), SearchCriteria.Op.EQ);
+idEqRoleEqStateInSearch.and(STATE,
idEqRoleEqStateInSearch.entity().getState(), SearchCriteria.Op.IN);
Review Comment:
The search builder initialization is missing the required `.done()` call at
the end. All other search builders in this file (e.g., `idStateNinSearch`,
`stateSearch`, `idStateNeqSearch`) call `.done()` after adding their
conditions. Without this call, the search builder may not function correctly.
```suggestion
idEqRoleEqStateInSearch.and(STATE,
idEqRoleEqStateInSearch.entity().getState(), SearchCriteria.Op.IN);
idEqRoleEqStateInSearch.done();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
blueorangutan commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853433515 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
sureshanaparti commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853428009 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
codecov[bot] commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853416931 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12597?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.71%. Comparing base ([`b869913`](https://app.codecov.io/gh/apache/cloudstack/commit/b869913529ec8e230abcb5d6b0924a36a7cdc7e3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5db5dd9`](https://app.codecov.io/gh/apache/cloudstack/commit/5db5dd9bacc587746a8db1ddbc5e60e2dd6f735f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (b869913) and HEAD (5db5dd9). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (b869913) | HEAD (5db5dd9) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.22 #12597 +/- ## = - Coverage 17.62%3.71% -13.91% = Files 5915 447 -5468 Lines53117137961 -493210 Branches 64938 7025-57913 = - Hits 93601 1409-92192 + Misses 42703136365 -390666 + Partials 10539 187-10352 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12597/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.71% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12597?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix snapshot chaining on Xen [cloudstack]
sureshanaparti commented on PR #12597: URL: https://github.com/apache/cloudstack/pull/12597#issuecomment-3853408009 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
