Re: [PR] Guest OS rules [cloudstack]
winterhazel merged PR #10098: URL: https://github.com/apache/cloudstack/pull/10098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4697120406 [SF] Trillian test result (tid-16298) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 49682 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10098-t16298-kvm-ol8.zip Smoke tests completed. 151 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4690878701 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
Pearl1594 commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4690871798 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4690727778 @Pearl1594 can we run the CI here? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4673339827 @DaanHoogland @weizhouapache @sureshanaparti can we run the CI here one last time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4663427226 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
hsato03 commented on code in PR #10098:
URL: https://github.com/apache/cloudstack/pull/10098#discussion_r3381250229
##
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##
@@ -805,18 +806,49 @@ protected boolean checkVmProfileAndHost(final
VirtualMachineProfile vmProfile, f
return false;
}
}
+
+DetailVO guestOsRule = _hostDetailsDao.findDetail(host.getId(),
HostVO.GUEST_OS_RULE);
+if (guestOsRule != null) {
+return isHostGuestOsCompatible(vmProfile, host, guestOsRule);
+}
+
+DetailVO guestOsCategoryId = _hostDetailsDao.findDetail(host.getId(),
HostVO.GUEST_OS_CATEGORY_ID);
+if (guestOsCategoryId != null) {
+return isHostGuestOsCategoryCompatible(vmProfile, host,
guestOsCategoryId);
+}
+
+return true;
+}
+
+private boolean isHostGuestOsCategoryCompatible(VirtualMachineProfile
vmProfile, HostVO host, DetailVO guestOsCategoryId) {
long guestOSId = vmProfile.getTemplate().getGuestOSId();
GuestOSVO guestOS = _guestOSDao.findById(guestOSId);
-if (guestOS != null) {
-long guestOSCategoryId = guestOS.getCategoryId();
-DetailVO hostDetail = _hostDetailsDao.findDetail(host.getId(),
"guest.os.category.id");
-if (hostDetail != null) {
-String guestOSCategoryIdString = hostDetail.getValue();
-if (String.valueOf(guestOSCategoryId) !=
guestOSCategoryIdString) {
-logger.debug("The last host has different
guest.os.category.id than guest os category of VM, skipping");
-return false;
-}
-}
+
+if (guestOS == null) {
+return true;
+}
+
+long guestOSCategoryId = guestOS.getCategoryId();
+String guestOSCategoryIdString = guestOsCategoryId.getValue();
+if
(!String.valueOf(guestOSCategoryId).equals(guestOSCategoryIdString)) {
+logger.debug("The last host has different `{}` than guest os
category of VM, skipping", Host.GUEST_OS_CATEGORY_ID);
+return false;
+}
+
+return true;
+}
+
+private boolean isHostGuestOsCompatible(VirtualMachineProfile vmProfile,
HostVO host, DetailVO guestOsRule) {
+VMTemplateVO template = (VMTemplateVO) vmProfile.getTemplate();
+String templateGuestOSName =
ApiDBUtils.getTemplateGuestOSName(template);
+
+List incompatibleHosts =
_hostDao.findHostsWithGuestOsRulesThatDidNotMatchOsOfGuestVm(templateGuestOSName);
+
+boolean isIncompatibleHost =
incompatibleHosts.stream().noneMatch(incompatibleHost ->
incompatibleHost.getId() == host.getId());
Review Comment:
The `isIncompatibleHost` variable actually checks if the host is compatible.
It would be good to rename it or change its value.
##
ui/public/locales/pt_BR.json:
##
@@ -1090,6 +1090,8 @@
"label.guestnetwork": "Rede guest",
"label.guestnetworkid": "ID de rede",
"label.guestnetworkname": "Nome da rede",
+"label.guestosasrule": "SO guest como regra JS",
+"label.guestosrule": "Regra SO guest",
Review Comment:
These labels can also be added to the `en.json` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4646239842 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4508287940 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4507854930 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4507835613 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4485601950 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4411829128 [SF] Trillian test result (tid-16057) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 51477 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10098-t16057-kvm-ol8.zip Smoke tests completed. 151 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4407888054 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
sureshanaparti commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4407881575 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4407753948 @sureshanaparti can we run the smoke tests here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4407349734 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4406980269 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4406973896 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4400252016 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4399552264 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
winterhazel commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-4399534584 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
sureshanaparti commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3894951856 Hi @BryanMLima is this PR ready? can you resolve the conflicts (and rebase with 4.22 if this can be targeted for 4.22.1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
rajujith commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3742039277 @BryanMLima Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3125561592 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3112898093 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3073189786 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-3032314751 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
BryanMLima commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2979639808 > @BryanMLima can you look at the conflicts? I will take a look this week, apologies for disappearing :sweat_smile: . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
DaanHoogland commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2965553717 @BryanMLima can you look at the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2965460867 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2963977415 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2943899021 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
sureshanaparti commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2943479130 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
blueorangutan commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2943486106 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2629156887 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
github-actions[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2577663990 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guest OS rules [cloudstack]
codecov[bot] commented on PR #10098: URL: https://github.com/apache/cloudstack/pull/10098#issuecomment-2539049443 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10098?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.01%. Comparing base [(`db2e89a`)](https://app.codecov.io/gh/apache/cloudstack/commit/db2e89a3a2c9e8df2d24ed3e6aeae280bf22f0ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4835d26`)](https://app.codecov.io/gh/apache/cloudstack/commit/4835d263db6d5c388c202b8df4a2e0649485dd4e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 48 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (db2e89a) and HEAD (4835d26). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (db2e89a) | HEAD (4835d26) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10098 +/- ## = - Coverage 15.80%4.01% -11.79% = Files 5627 394 -5233 Lines49235632365 -459991 Branches 59696 5715-53981 = - Hits 77828 1301-76527 + Misses 40600530916 -375089 + Partials 8523 148 -8375 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10098/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.01% <ø> (-0.03%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10098/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10098?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
