Re: [PR] Indirect agent connection improvements [cloudstack]
github-actions[bot] commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-5620310799 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
Copilot commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3913181040
##
agent/src/main/java/com/cloud/agent/AgentShell.java:
##
@@ -410,7 +420,7 @@ public void init(String[] args) throws
ConfigurationException {
if (LOGGER.isDebugEnabled()) {
List properties =
Collections.list((Enumeration)_properties.propertyNames());
for (String property : properties) {
-LOGGER.debug("Found property: {}", property);
+LOGGER.debug("Found property: {}, value: {}", property,
_properties.getProperty(property));
}
Review Comment:
This debug logging prints *all* agent properties including their values.
Agent properties commonly include sensitive data (passwords, keys, tokens), so
emitting them to logs is a security risk and can leak secrets in support
bundles.
Consider logging only the property names (previous behavior), or explicitly
redacting known-sensitive keys before logging values.
##
framework/cluster/src/main/java/com/cloud/cluster/ClusterServiceServletHttpHandler.java:
##
@@ -113,6 +117,14 @@ private void writeResponse(HttpResponse response, int
statusCode, String content
response.setEntity(body);
}
+private void logRequest(HttpRequest request, String requestBody) {
+Optional requestOpt = Optional.ofNullable(request);
+Optional requestLineOpt =
requestOpt.map(HttpRequest::getRequestLine);
+String method =
requestLineOpt.map(RequestLine::getMethod).orElse(null);
+String uri = requestLineOpt.map(RequestLine::getUri).orElse(null);
+logger.debug("{} {} {}", method, uri, requestBody);
+}
Review Comment:
`logRequest` logs the full raw POST body at DEBUG level. Cluster-service
requests can include operational identifiers and potentially sensitive
parameters; logging the entire body at DEBUG makes accidental data exposure
much more likely (and duplicates the per-parameter TRACE logging above).
Suggestion: log only method/URI (or body length / a sanitized subset) unless
TRACE is enabled and the data is explicitly safe to log.
##
utils/src/main/java/com/cloud/utils/backoff/BackoffFactory.java:
##
@@ -0,0 +1,96 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.utils.backoff;
+
+import com.cloud.utils.backoff.impl.ConstantTimeBackoff;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import javax.naming.ConfigurationException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+/**
+ * Backoff implementation factory.
+ *
+ * @author mprokopchuk
+ */
+public interface BackoffFactory {
+Logger logger = LogManager.getLogger(BackoffFactory.class);
+/**
+ * Property name for the implementation class (that extends {@link
BackoffAlgorithm}) to be used either
+ * by {@code agent.properties} file or by configuration key.
+ */
+String BACKOFF_IMPLEMENTATION_KEY = "backoff.implementation";
+
+/**
+ * Default backoff implementation class name ({@link ConstantTimeBackoff}).
+ */
+String DEFAULT_BACKOFF_IMPLEMENTATION =
ConstantTimeBackoff.class.getName();
+
+/**
+ * Creates default {@link BackoffAlgorithm} implementation object ({@link
ConstantTimeBackoff}).
+ *
+ * @param properties configuration properties
+ * @return {@link BackoffAlgorithm} implementation object
+ */
+static BackoffAlgorithm createDefault(Properties properties) {
+Properties newProperties = new Properties(properties);
+newProperties.put(BACKOFF_IMPLEMENTATION_KEY,
DEFAULT_BACKOFF_IMPLEMENTATION);
+return create(newProperties);
+}
Review Comment:
`createDefault` currently uses `new Properties(properties)`, which sets the
passed `properties` as *defaults* rather than copying entries. Since
`create(Properties)` builds params from `properties.entrySet()`, the default
backoff will be created with only `backoff.implementation` set and will
silently drop other backoff-related settings (e.g. `backoff.seconds`,
Re: [PR] Indirect agent connection improvements [cloudstack]
DaanHoogland commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-5454017503 @blueorangutan shutup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
Copilot commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3864133621
##
agent/src/main/java/com/cloud/agent/Agent.java:
##
@@ -623,98 +559,363 @@ public Task create(final Task.Type type, final Link
link, final byte[] data) {
return new ServerHandler(type, link, data);
}
-protected void reconnect(final Link link) {
-reconnect(link, null, false);
+protected void closeAndTerminateLink(Link link) {
+Optional.ofNullable(link)
+.map(Link::attachment)
+.filter(ServerAttache.class::isInstance)
+.map(ServerAttache.class::cast)
+.ifPresentOrElse(ServerAttache::disconnect, () -> {
+if (link != null) {
+link.close();
+link.terminated();
+}
+});
}
-protected void reconnect(final Link link, String preferredMSHost, boolean
forTransfer) {
-if (!(forTransfer || reconnectAllowed)) {
-logger.debug("Reconnect requested but it is not allowed {}", () ->
getLinkLog(link));
+protected void stopAndCleanupConnection() {
+if (connection == null) {
return;
}
-cancelStartupTask();
-closeAndTerminateLink(link);
-closeAndTerminateLink(this.link);
-setLink(null);
-cancelTasks();
-serverResource.disconnected();
-logger.info("Lost connection to host: {}. Attempting reconnection
while we still have {} commands in progress.", shell.getConnectedHost(),
commandsInProgress.get());
-stopAndCleanupConnection(true);
-String host = preferredMSHost;
-if (org.apache.commons.lang3.StringUtils.isBlank(host)) {
-host = shell.getNextHost();
-}
-List avoidMSHostList = shell.getAvoidHosts();
-do {
-if (CollectionUtils.isEmpty(avoidMSHostList) ||
!avoidMSHostList.contains(host)) {
-connection = new NioClient(getAgentName(), host,
shell.getPort(), shell.getWorkers(), shell.getSslHandshakeTimeout(), this);
-logger.info("Reconnecting to host: {}", host);
-try {
-connection.start();
-} catch (final NioConnectionException e) {
-logger.info("Attempted to re-connect to the server, but
received an unexpected exception, trying again...", e);
-stopAndCleanupConnection(false);
-}
+NioConnection connection = this.connection;
+connection.stop();
+try {
+connection.cleanUp();
+} catch (final IOException e) {
+logger.warn("Fail to clean up old connection", e);
+}
+
+try {
+while (connection.isStartup()) {
+logger.debug("Waiting for connection graceful stop");
+shell.getBackoffAlgorithm().waitBeforeRetry();
+connection.stop();
}
-shell.getBackoffAlgorithm().waitBeforeRetry();
-host = shell.getNextHost();
-} while (!connection.isStartup());
-shell.updateConnectedHost(((NioClient)connection).getHost());
-logger.info("Connected to the host: {}", shell.getConnectedHost());
+} catch (Exception e) {
+logger.warn("Failed to gracefully stop connection", e);
+}
+logger.debug("Connection stopped");
+}
+
+/**
+ * Select the host to reconnect to based on priority:
+ * 1. preferredHost if defined and not blank
+ * 2. Link's socket address IP if available and not null
+ * 3. shell.getNextHost() if the above two options are not met
+ *
+ * @param preferredHost the preferred host to connect to
+ * @param link the current link which may contain socket address
information
+ * @return the host to connect to
+ */
+protected String selectReconnectionHost(String preferredHost, Link link) {
+return Optional.ofNullable(preferredHost)
+.filter(org.apache.commons.lang3.StringUtils::isNotBlank)
+.orElseGet(() -> Optional.ofNullable(link)
+.map(Link::getSocketAddress)
+.map(InetSocketAddress::getAddress)
+.map(InetAddress::getHostAddress)
+.orElseGet(shell::getNextHost));
}
-protected void closeAndTerminateLink(final Link link) {
-if (link == null) {
+/**
+ * Reconnect to Management Server.
+ *
+ * @param link - connection holder
+ * @param preferredHost - if defined, reconnect will be performed to this
Host first,
+ * otherwise will be used {@link
IAgentShell#getNextHost()}
+ * @param forceReconnect - expected to be true if called by {@link
MigrateAgentConnectionCommand},
+ * this
Re: [PR] Indirect agent connection improvements [cloudstack]
Damans227 commented on code in PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3624822556 ## agent/src/main/java/com/cloud/agent/ServerAttache.java: ## @@ -0,0 +1,489 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package com.cloud.agent; + +import com.cloud.agent.api.Answer; +import com.cloud.agent.api.Command; +import com.cloud.agent.transport.Request; +import com.cloud.agent.transport.Response; +import com.cloud.exception.AgentUnavailableException; +import com.cloud.exception.CloudException; +import com.cloud.exception.OperationTimedoutException; +import com.cloud.utils.concurrency.NamedThreadFactory; +import com.cloud.utils.nio.Link; +import org.apache.cloudstack.managed.context.ManagedContextRunnable; +import org.apache.cloudstack.utils.reflectiontostringbuilderutils.ReflectionToStringBuilderUtils; +import org.apache.commons.lang3.ArrayUtils; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; +import org.apache.logging.log4j.ThreadContext; + +import java.io.IOException; +import java.nio.channels.ClosedChannelException; +import java.security.SecureRandom; +import java.util.Collections; +import java.util.Comparator; +import java.util.Iterator; +import java.util.LinkedList; +import java.util.Map; +import java.util.Optional; +import java.util.Random; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + +/** + * ServerAttache provides basic server communication commands to be implemented. + * + * @author mprokopchuk Review Comment: Nit: leftover personal `@author mprokopchuk` javadoc tag (recurs in several of the other new files here too: SynchronousListener.java, AgentConnectStatusAnswer.java, AgentConnectStatusCommand.java, ThreadContextUtil.java, ConfigKeyUtil.java, BackoffFactory.java, ExponentialWithJitterBackoff.java). Probably copied over from wherever this was originally authored, worth stripping. ## agent/src/main/java/com/cloud/agent/HostConnectProcess.java: ## @@ -0,0 +1,355 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package com.cloud.agent; + +import com.cloud.agent.api.AgentConnectStatusAnswer; +import com.cloud.agent.api.AgentConnectStatusCommand; +import com.cloud.agent.api.Answer; +import com.cloud.agent.api.Command; +import com.cloud.agent.api.StartupAnswer; +import com.cloud.agent.api.StartupCommand; +import com.cloud.agent.properties.AgentProperties; +import com.cloud.agent.properties.AgentPropertiesFileHandler; +import com.cloud.agent.transport.Request; +import com.cloud.exception.CloudException; +import com.cloud.exception.OperationTimedoutException; +import com.cloud.host.Status; +import com.cloud.resource.ResourceStatusUpdater; +import com.cloud.resource.ServerResource; +import com.cloud.utils.concurrency.NamedThreadFactory; +import com.cloud.utils.nio.Link; +import org.apache.cloudstack.threadcontext.ThreadContextUtil; +import org.apache.commons.lang3.ArrayUtils; +import org.apache.logging.log4j.Logger; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.ThreadContext; + +import java.io.IOException; +import java.nio.channels.ClosedChannelException; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService;
Re: [PR] Indirect agent connection improvements [cloudstack]
weizhouapache commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4912845246 moving to 4.24.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
github-actions[bot] commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4690888245 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4649855176 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4649382230 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4649394804 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3373466837
##
core/src/main/java/com/cloud/agent/api/AgentConnectStatusCommand.java:
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api;
+
+/**
+ * Command to check status of {@link StartupCommand} from the Agent.
+ *
+ * @author mprokopchuk
+ */
Review Comment:
@bernardodemarco I think, it's ok to have it. we've author mentioned in few
other classes as well. (check with '`@author`' in the code base).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3373466837
##
core/src/main/java/com/cloud/agent/api/AgentConnectStatusCommand.java:
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api;
+
+/**
+ * Command to check status of {@link StartupCommand} from the Agent.
+ *
+ * @author mprokopchuk
+ */
Review Comment:
@bernardodemarco I think, it's ok to have it. we've author mentioned in
other classes as well. (check with '`@author`' in the code base).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3373466837
##
core/src/main/java/com/cloud/agent/api/AgentConnectStatusCommand.java:
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api;
+
+/**
+ * Command to check status of {@link StartupCommand} from the Agent.
+ *
+ * @author mprokopchuk
+ */
Review Comment:
@bernardodemarco I think, it's ok to have it. we've author mentioned in
other classes as well. (check with '_@author_' in the code base).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3373466837
##
core/src/main/java/com/cloud/agent/api/AgentConnectStatusCommand.java:
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api;
+
+/**
+ * Command to check status of {@link StartupCommand} from the Agent.
+ *
+ * @author mprokopchuk
+ */
Review Comment:
@bernardodemarco I think, it's ok to have it. we've author mentioned in
other classes as well. (check with '@author' in the code base).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
github-actions[bot] commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4646256003 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
bernardodemarco commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3365636892
##
core/src/main/java/com/cloud/agent/api/AgentConnectStatusCommand.java:
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api;
+
+/**
+ * Command to check status of {@link StartupCommand} from the Agent.
+ *
+ * @author mprokopchuk
+ */
Review Comment:
These `@author` fields are not necessary, right?
```suggestion
/**
* Command to check status of {@link StartupCommand} from the Agent.
*
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4625626090 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4625255628 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4625239434 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4620895411 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
Copilot commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3354649209
##
framework/db/src/main/java/com/cloud/utils/db/GlobalLock.java:
##
@@ -45,127 +43,248 @@
*
*/
public class GlobalLock {
-protected Logger logger = LogManager.getLogger(getClass());
+protected final static Logger logger =
LogManager.getLogger(GlobalLock.class);
private String name;
-private int lockCount = 0;
-private Thread ownerThread = null;
-
-private int referenceCount = 0;
-private long holdingStartTick = 0;
-
-private static Map s_lockMap = new HashMap();
+/**
+ * DB lock count.
+ * Increments on {@link GlobalLock#lock(int)} and decrements on {@link
GlobalLock#unlock()}.
+ * Upon {@link GlobalLock#unlock()}, if {@link GlobalLock#lockCount} is
less than 1, then lock removed from DB
+ */
+private int lockCount;
+
+/**
+ * Internal (in-memory) lock count.
+ * Increments on {@link GlobalLock#addRef()} and indirectly on {@link
GlobalLock#getInternLock(String)} and
+ * decrements on {@link GlobalLock#releaseRef()}, {@link
GlobalLock#unlock()} and on {@link GlobalLock#lock(int)}
+ * if DB lock is unsuccessful
+ */
+private int referenceCount;
+
+/**
+ * Thread that owns lock. If lock called from different thread, it will be
waiting for the owner to unlock it
+ * within requested timeout. If owner thread call {@link
GlobalLock#lock(int)} again, then
+ * {@link GlobalLock#lockCount} will be incremented.
+ * If {@link GlobalLock#unlock()} called by owner thread, or DB lock will
be unsuccessful, then owner thread will be
+ * nullified.
+ */
+private Thread ownerThread;
+
+/**
+ * Variable to hold lock duration in milliseconds. Used for information
only.
+ */
+private long holdingStartTick;
+
+/**
+ * Holds all created locks.
+ */
+private static Map s_lockMap = new HashMap<>();
+
+/**
+ * Create lock.
+ *
+ * @param name lock name
+ */
private GlobalLock(String name) {
this.name = name;
}
+/**
+ * Increment reference count to lock.
+ *
+ * @return reference count
+ */
public int addRef() {
synchronized (this) {
referenceCount++;
return referenceCount;
}
}
+/**
+ * Decrement reference count to lock.
+ *
+ * @return reference count
+ */
public int releaseRef() {
-int refCount;
-
boolean needToRemove = false;
synchronized (this) {
+if (logger.isDebugEnabled()) {
+logger.debug("Releasing reference for internal lock {},
reference count: {}, lock count: {}",
+name, referenceCount, lockCount);
+}
referenceCount--;
-refCount = referenceCount;
-
-if (referenceCount < 0)
-logger.warn("Unmatched Global lock " + name + " reference
usage detected, check your code!");
-if (referenceCount == 0)
+if (referenceCount < 0) {
+logger.warn("Unmatched internal lock {} reference usage
detected (reference count: {}, " +
+"lock count: {}), check your code!", name,
referenceCount, lockCount);
+} else if (referenceCount < 1) {
needToRemove = true;
+}
}
-if (needToRemove)
+if (needToRemove) {
+if (logger.isDebugEnabled()) {
+logger.debug("Need to release internal lock {}", name);
+}
releaseInternLock(name);
+}
+if (logger.isDebugEnabled()) {
+logger.debug("Released reference for lock {}, reference count:
{}", name, referenceCount);
+}
+return referenceCount;
+}
-return refCount;
+public static boolean isLockAvailable(String name) {
+if (logger.isDebugEnabled()) {
+logger.debug("Checking lock present for {}", name);
+}
+boolean result = false;
+try {
+result = DbUtil.isFreeLock(name);
+} finally {
+if (logger.isDebugEnabled()) {
+logger.debug("Result of checking lock present for {}: {}",
name, result);
+}
+}
+return result;
Review Comment:
GlobalLock.isLockAvailable() delegates to DbUtil.isFreeLock(), but the debug
messages say "lock present" which is the opposite of what IS_FREE_LOCK()
reports. This makes troubleshooting lock/availability logic confusing.
##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##
@@ -1544,24 +2009,26 @@ protected void runInContext() {
}
protected void connectAgent(final Link link, final Command[] cmds, final
Request request) {
-// send startupanswer to agent in the very beginning,
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4620394267 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4620383653 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4619916053 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
Copilot commented on code in PR #13345:
URL: https://github.com/apache/cloudstack/pull/13345#discussion_r3354005739
##
engine/orchestration/src/main/java/com/cloud/agent/manager/ClusteredAgentManagerImpl.java:
##
@@ -285,8 +290,9 @@ protected AgentAttache createAttache(final HostVO host) {
_agents.put(host.getId(), attache);
}
if (old != null) {
-logger.debug("Remove stale agent attache from current management
server");
-removeAgent(old, Status.Removed);
+logger.debug("Remove stale agent attache from current management
server {}", _nodeId);
+// just remove agent but do not deinitialize
+removeAgent(old.getId(), attache);
}
Review Comment:
Bug: this call removes the newly created forwarding attache from the _agents
map. At this point the map already contains `attache`, so
`removeAgent(old.getId(), attache)` will `remove(hostId)` and return without
restoring it, leaving no attache registered for the host on this node.
##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##
@@ -1376,62 +1763,129 @@ protected AgentAttache createAttacheForConnect(final
HostVO host, final Link lin
return attache;
}
-private AgentAttache sendReadyAndGetAttache(HostVO host, ReadyCommand
ready, Link link, StartupCommand[] startupCmds) throws ConnectionException {
+private AgentAttache sendReadyAndGetAttache(HostVO host, ReadyCommand
ready, Link link, StartupCommand[] startup) throws ConnectionException {
AgentAttache attache;
GlobalLock joinLock = getHostJoinLock(host.getId());
try {
-if (!joinLock.lock(60)) {
-throw new ConnectionException(true, String.format("Unable to
acquire lock on host %s, to process agent connection", host));
+long processStart = System.currentTimeMillis();
+if (joinLock.lock(getTimeoutSec())) {
+logProcessingStart(host, joinLock);
+try {
+updateReadyCommandWithMSList(host, ready, startup);
+attache = createAndNotifyAttache(host, link, startup);
+} finally {
+logProcessingFinish(host, joinLock, processStart);
+joinLock.unlock();
+}
+} else {
+throw createLockAcquisitionException(host, joinLock,
processStart);
}
-
-logger.debug("Acquired lock on host {}, to process agent
connection", host);
-attache = connectHostAgent(host, ready, link, startupCmds,
joinLock);
} finally {
joinLock.releaseRef();
}
return attache;
}
-private AgentAttache connectHostAgent(HostVO host, ReadyCommand ready,
Link link, StartupCommand[] startupCmds, GlobalLock joinLock) throws
ConnectionException {
-AgentAttache attache;
-try {
-final List agentMSHostList = new ArrayList<>();
-String lbAlgorithm = null;
-if (startupCmds != null && startupCmds.length > 0) {
-final String agentMSHosts = startupCmds[0].getMsHostList();
-if (StringUtils.isNotEmpty(agentMSHosts)) {
-String[] msHosts = agentMSHosts.split("@");
-if (msHosts.length > 1) {
-lbAlgorithm = msHosts[1];
-}
-
agentMSHostList.addAll(Arrays.asList(msHosts[0].split(",")));
+private void logProcessingStart(HostVO host, GlobalLock joinLock) {
+StringBuilder msgBuilder = getSummaryMsgBuilder("Processing Host
connection started",
+EventTypes.EVENT_HOST_RECONNECT, host.getUuid(),
host.getName(), joinLock.getName(), null, null, null);
+logger.info(msgBuilder.toString());
+}
+
+private void logProcessingFinish(HostVO host, GlobalLock joinLock, long
processStart) {
+long processFinish = System.currentTimeMillis() - processStart;
+StringBuilder msgBuilder = getSummaryMsgBuilder("Processing Host
connection finished",
+EventTypes.EVENT_HOST_RECONNECT, host.getUuid(),
host.getName(), joinLock.getName(), null, null,
+processFinish);
+logger.fatal(msgBuilder.toString());
+}
+
+private void updateReadyCommandWithMSList(HostVO host, ReadyCommand ready,
StartupCommand[] startup) {
+List agentMSHostList = new ArrayList<>();
+String lbAlgorithm = null;
+
+if (startup != null) {
+String agentMSHosts = startup[0].getMsHostList();
+if (StringUtils.isNotEmpty(agentMSHosts)) {
+String[] msHosts = agentMSHosts.split("@");
Review Comment:
Potential AIOOBE: `startup[0]` is accessed when `startup != null` but
without checking `startup.length > 0`. An empty startup array would crash the
connect flow.
Re: [PR] Indirect agent connection improvements [cloudstack]
codecov[bot] commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4619614226 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13345?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.51%. Comparing base ([`be51948`](https://app.codecov.io/gh/apache/cloudstack/commit/be5194814616ec8d3bf9410ed6bc533186bd0eed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ad7a8c5`](https://app.codecov.io/gh/apache/cloudstack/commit/ad7a8c576ef10afcf3c8176e2ca3058ca3f6e29d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (be51948) and HEAD (ad7a8c5). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (be51948) | HEAD (ad7a8c5) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13345 +/- ## = - Coverage 18.10%3.51% -14.60% = Files 6037 464 -5573 Lines54279840159 -502639 Branches 66457 7560-58897 = - Hits 98298 1413-96885 + Misses 43345338556 -394897 + Partials 11047 190-10857 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13345/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.51% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/13345?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4619584334 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13345: URL: https://github.com/apache/cloudstack/pull/13345#issuecomment-4619580382 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4619573738 Unable to re-open this PR, continued with a new one here: https://github.com/apache/cloudstack/pull/13345 cc @nvazquez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
nvazquez commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4467268452 @sureshanaparti let's close this PR while we revisiting some issues, we can reopen it once sorted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
nvazquez closed pull request #13028: Indirect agent connection improvements URL: https://github.com/apache/cloudstack/pull/13028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4462338611 [SF] Trillian test result (tid-16100) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 83170 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13028-t16100-kvm-ol8.zip Smoke tests completed. 144 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_vm_backup_create_vm_from_backup | `Failure` | 608.02 | test_backup_recovery_nas.py test_vm_backup_lifecycle | `Error` | 1.12 | test_backup_recovery_nas.py test_uservm_host_control_state | `Failure` | 16.98 | test_host_control_state.py ContextSuite context=TestSharedFSLifecycle>:setup | `Error` | 0.00 | test_sharedfs_lifecycle.py test_10_attachAndDetach_iso | `Failure` | 607.08 | test_vm_life_cycle.py test_01_create_vm_snapshots | `Failure` | 606.87 | test_vm_snapshots.py test_02_revert_vm_snapshots | `Failure` | 600.67 | test_vm_snapshots.py test_03_delete_vm_snapshots | `Failure` | 0.03 | test_vm_snapshots.py test_01_create_volume | `Failure` | 610.42 | test_volumes.py test_01_root_volume_encryption | `Failure` | 707.39 | test_volumes.py test_02_data_volume_encryption | `Failure` | 643.98 | test_volumes.py test_03_root_and_data_volume_encryption | `Failure` | 664.23 | test_volumes.py test_02_attach_volume | `Failure` | 1270.48 | test_volumes.py test_02_attach_volume | `Failure` | 1270.50 | test_volumes.py test_03_download_attached_volume | `Failure` | 666.82 | test_volumes.py test_04_delete_attached_volume | `Failure` | 663.56 | test_volumes.py test_05_detach_volume | `Failure` | 753.78 | test_volumes.py test_06_download_detached_volume | `Failure` | 846.01 | test_volumes.py test_07_resize_fail | `Failure` | 659.56 | test_volumes.py test_08_resize_volume | `Failure` | 673.30 | test_volumes.py test_09_delete_detached_volume | `Failure` | 667.03 | test_volumes.py test_10_list_volumes | `Failure` | 663.72 | test_volumes.py test_11_attach_volume_with_unstarted_vm | `Failure` | 763.48 | test_volumes.py test_12_resize_volume_with_only_size_parameter | `Failure` | 666.79 | test_volumes.py test_13_migrate_volume_and_change_offering | `Failure` | 806.37 | test_volumes.py test_14_delete_volume_delete_protection | `Failure` | 663.90 | test_volumes.py test_hostha_enable_ha_when_host_disabled | `Error` | 0.89 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.13 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4453645908 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4453632851 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4453529909 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4453159675 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4453140693 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4452324001 [SF] Trillian Build Failed (tid-16099) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4452005543 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4451989144 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4438799462 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4438302077 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4438284058 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4419118371 [SF] Trillian Build Failed (tid-16065) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4418864668 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4418849625 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4418050479 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4417849858 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4417847464 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4412577999 [SF] Trillian Build Failed (tid-16062) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4412510400 @borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
borisstoyanov commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4412508075 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4411986046 [SF] Trillian Build Failed (tid-16061) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4411747358 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4411746568 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4408617157 [SF] Trillian Build Failed (tid-16058) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4408337990 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4408325062 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4408203694 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4407873624 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4407869537 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4404938843 [SF] Trillian Build Failed (tid-16049) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4404788184 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4404778894 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396788560 [SF] Trillian Build Failed (tid-16039) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396629456 @borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
borisstoyanov commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396617616 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396534358 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396240317 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396226735 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396128686 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396122411 @borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
borisstoyanov commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4396115600 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
github-actions[bot] commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4391456886 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
github-actions[bot] commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4349493613 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249958089 [SF] Trillian Build Failed (tid-15880) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249832965 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249823948 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249779292 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
codecov[bot] commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249457704 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13028?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 3.53%. Comparing base ([`82bfa9f`](https://app.codecov.io/gh/apache/cloudstack/commit/82bfa9fb3f409253dd43fb9ec90e2bb518fda490?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d032a53`](https://app.codecov.io/gh/apache/cloudstack/commit/d032a53daef77ad7b42c270b3d8617f3a59518c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (82bfa9f) and HEAD (d032a53). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (82bfa9f) | HEAD (d032a53) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13028 +/- ## = - Coverage 17.95%3.53% -14.43% = Files 6022 464 -5558 Lines54138740078 -501309 Branches 66346 7542-58804 = - Hits 97211 1415-95796 + Misses 43321038475 -394735 + Partials 10966 188-10778 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13028/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13028/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.53% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13028/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/13028?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
blueorangutan commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249448405 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249443802 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Indirect agent connection improvements [cloudstack]
sureshanaparti commented on PR #13028: URL: https://github.com/apache/cloudstack/pull/13028#issuecomment-4249426718 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
