Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-09 Thread via GitHub


harikrishna-patnala merged PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-09 Thread via GitHub


harikrishna-patnala commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4667097608

   merging this as it has got needed approvals. cc @weizhouapache 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4647366831

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
18181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4646951172

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


weizhouapache commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4646938338

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4646698740

   > > @vishesh92 could you please fix the conflicts ?
   > > this is ready for merge
   > 
   > Resolved.
   
   I have tested with vmware and it's working as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4646694558

   > @vishesh92 could you please fix the conflicts ?
   > 
   > this is ready for merge
   
   Resolved. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


weizhouapache commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4646546338

   @vishesh92 
   could you please fix the conflicts ?
   
   this is ready for merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-06-08 Thread via GitHub


github-actions[bot] commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4646241022

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-27 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4553517776

   > @weizhouapache @vishesh92 any extra testing needed here?
   
   I need to check if the upgrade works successfully with vmware. We can merge 
after that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-27 Thread via GitHub


DaanHoogland commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4553480555

   @weizhouapache @vishesh92 any extra testing needed here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-26 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4550395563

   [SF] Trillian test result (tid-16176)
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 47190 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t16176-kvm-ol8.zip
   Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-26 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4543793443

   @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-26 Thread via GitHub


DaanHoogland commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4543790986

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-25 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4532918773

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
18011


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-25 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4532642188

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-25 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4532635383

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-21 Thread via GitHub


DaanHoogland commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4509371638

   @vishesh92 can you have a look :( ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-21 Thread via GitHub


github-actions[bot] commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4506076940

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-19 Thread via GitHub


DaanHoogland commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4486899270

   @vishesh92 what test effort needs to be done on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-08 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4410234921

   [SF] Trillian test result (tid-16050)
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 47455 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t16050-kvm-ol8.zip
   Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-08 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4404847399

   @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-08 Thread via GitHub


weizhouapache commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4404838218

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-08 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4404627643

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
17778


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-07 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4404223587

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-05-07 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4404213677

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-31 Thread via GitHub


github-actions[bot] commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4161959961

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4123671186

   [SF] Trillian test result (tid-15721)
   Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 60461 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t15721-vmware-70u3.zip
   Smoke tests completed. 148 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestListIdsParams>:teardown | `Error` | 1.21 | 
test_list_ids_parameter.py
   test_01_snapshot_root_disk | `Error` | 50.70 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 80.21 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 80.22 | 
test_snapshots.py
   ContextSuite context=TestSnapshotStandaloneBackup>:teardown | `Error` | 
47.69 | test_snapshots.py
   test_01_snapshot_usage | `Error` | 110.44 | test_usage.py
   test_01_vpn_usage | `Error` | 1.14 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4122905565

   [SF] Trillian test result (tid-15719)
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 54483 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t15719-kvm-ol8.zip
   Smoke tests completed. 147 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestListIdsParams>:teardown | `Error` | 1.17 | 
test_list_ids_parameter.py
   test_01_deployVMInSharedNetwork | `Failure` | 383.12 | test_network.py
   test_01_snapshot_root_disk | `Error` | 2.99 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 49.07 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 49.07 | 
test_snapshots.py
   ContextSuite context=TestSnapshotStandaloneBackup>:teardown | `Error` | 
35.38 | test_snapshots.py
   test_01_snapshot_usage | `Error` | 22.78 | test_usage.py
   test_01_vpn_usage | `Error` | 1.13 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4118003677

   [SF] Trillian Build Failed (tid-15723)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4117556848

   [SF] Trillian Build Failed (tid-15720)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4117485638

   @vishesh92 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 
mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4117480829

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4117443569

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
17230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4117159171

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled withI have done some testing. The fresh build is working fine.
   
   For upgrades (followed docs) & systemVM patching I followed these steps:
   
   1. Stop MS
   2. Upgrade MS
   3. Stop agents
   4. Upgrade agents
   5. Start MS
   6. Test console proxy by opening console
   7. Patch console proxy. Agent was in Up state after patching. The version 
was also updated.
   8. Test console proxy by opening console SystemVM template(s). I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4117147545

   @blueorangutan package
   
   I have done some testing. The fresh build is working fine.
   
   For upgrades (followed docs) & systemVM patching I followed these steps:
   
   1. Stop MS
   2. Upgrade MS
   3. Stop agents
   4. Upgrade agents
   5. Start MS
   6. Test console proxy by opening console
   7. Patch console proxy. Agent was in Up state after patching. The version 
was also updated.
   8. Test console proxy by opening console


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


vishesh92 commented on code in PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#discussion_r2979958046


##
.pre-commit-config.yaml:
##
@@ -151,7 +151,7 @@ repos:
   ^server/src/test/resources/certs/rsa_self_signed\.key$|
   ^services/console-proxy/rdpconsole/src/test/doc/rdp-key\.pem$|
   ^systemvm/agent/certs/localhost\.key$|
-  ^systemvm/agent/certs/realhostip\.key$|
+  ^systemvm/agent/certs/systemvm\.key$|

Review Comment:
   unrelated to this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-24 Thread via GitHub


vishesh92 commented on code in PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#discussion_r2979956479


##
systemvm/agent/scripts/config_ssl.sh:
##
@@ -52,13 +52,13 @@ cflag=
 cpkflag=
 cpcflag=
 cccflag=
-customPrivKey=$(dirname $0)/certs/realhostip.key
-customPrivCert=$(dirname $0)/certs/realhostip.crt
+customPrivKey=$(dirname $0)/certs/systemvm.key
+customPrivCert=$(dirname $0)/certs/systemvm.crt

Review Comment:
   unrelated to this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-19 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4089526354

   [SF] Trillian test result (tid-15691)
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 51149 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12856-t15691-kvm-ol8.zip
   Smoke tests completed. 148 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestListIdsParams>:teardown | `Error` | 1.19 | 
test_list_ids_parameter.py
   test_01_snapshot_root_disk | `Error` | 5.03 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 49.16 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 49.17 | 
test_snapshots.py
   ContextSuite context=TestSnapshotStandaloneBackup>:teardown | `Error` | 
32.21 | test_snapshots.py
   test_01_snapshot_usage | `Error` | 25.95 | test_usage.py
   test_01_vpn_usage | `Error` | 1.17 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-19 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4088576847

   > overall lgtm
   > 
   > my only concern is, will live-patch of system vms (created before upgrade) 
work ?
   
   Yes. I have made the changes but didn't test them.
   We will probably need to have some additional release notes for this or make 
some changes in the PR for backward compatibility. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-19 Thread via GitHub


weizhouapache commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4088505934

   overall lgtm
   
   my only concern is, will live-patch of system vms (created before upgrade) 
work ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-18 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4085421652

   @vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-18 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4085411226

   @blueorangutan test keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-18 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4085405662

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
17193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-18 Thread via GitHub


blueorangutan commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4085176439

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with no SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Remove realhostip references from the code [cloudstack]

2026-03-18 Thread via GitHub


vishesh92 commented on PR #12856:
URL: https://github.com/apache/cloudstack/pull/12856#issuecomment-4085170136

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]