Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


DaanHoogland merged PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2072286148

   > CLGTM, I don't have an env with security groups, I could deploy one but it 
might take me a while. It would be good if @MejdiB could validate this, 
otherwise, I can try to test it within a few weeks.
   
   ok thnks, I'll merge as I have tested it. @MejdiB can always create a new 
issues if he has additional configurations/requirements


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2072049226

   @JoaoJandre @MejdiB can you test / review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071937866

   @JoaoJandre are you ok with this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


weizhouapache commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071873177

   > verified manually in a test env with security groups; a cluster can be 
seen without error messages.
   
   cool, thanks @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071866768

   reports in 
https://github.com/apache/cloudstack/pull/8489#issuecomment-2069121983 are 
serious but not related to this code (no proper error handling when no zone is 
ready and **enabled**. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-23 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071863125

   verified manually in a test env with security groups; a cluster can be seen 
without error messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069563893

   [SF] Trillian Build Failed (tid-9956)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069198525

   [SF] Trillian Build Failed (tid-9955)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069121983

   @weizhouapache , as admin user I can not register an iso : 
   
![image](https://github.com/apache/cloudstack/assets/2486961/7089e8d9-ff93-458b-b51e-2a6653a2675e)
   not sure if this is related.
   as a normal user I don't even get to the overview : 
   
![image](https://github.com/apache/cloudstack/assets/2486961/18ec869f-ec60-4d2a-8a4b-a7b6e07698d6)
   as shown in the image , the user doesn't even get the button to register the 
iso.
   
   FYI, haven't investigated this yet:
   
   ```
   2024-04-22 11:02:55,541 ERROR [c.c.a.ApiServer] 
(qtp239372207-16:ctx-cc15c2af ctx-2969dc60) (logid:3e39b3ff) unhandled 
exception executing api command: [Ljava.lang.String;@4eefc745
   java.lang.NullPointerException
   at 
com.cloud.kubernetes.version.KubernetesVersionManagerImpl.createKubernetesSupportedVersionResponse(KubernetesVersionManagerImpl.java:107)
   at 
com.cloud.kubernetes.version.KubernetesVersionManagerImpl.createKubernetesSupportedVersionListResponse(KubernetesVersionManagerImpl.java:117)
   at 
com.cloud.kubernetes.version.KubernetesVersionManagerImpl.listKubernetesSupportedVersions(KubernetesVersionManagerImpl.java:278)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
   at com.sun.proxy.$Proxy439.listKubernetesSupportedVersions(Unknown 
Source)
   at 
org.apache.cloudstack.api.command.user.kubernetes.version.ListKubernetesSupportedVersionsCmd.execute(ListKubernetesSupportedVersionsCmd.java:99)
   at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
   at com.cloud.api.ApiServer.queueCommand(ApiServer.java:803)
   at com.cloud.api.ApiServer.handleRequest(ApiServer.java:624)
   at 
com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:342)
   at com.cloud.api.ApiServlet$1.run(ApiServlet.java:149)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
   at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:146)
   at com.cloud.api.ApiServlet.doGet(ApiServlet.java:100)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
   at 
org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
   at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
   at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069046916

   > Smoke tests completed. 56 look OK, 54 have errors, 0 did not run
   
   note that this is a normal rate for security group zones :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-20 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2067731703

   [SF] Trillian test result (tid-9935)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 71400 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8489-t9935-kvm-alma9.zip
   Smoke tests completed. 56 look OK, 54 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 3.22 | test_events_resource.py
   test_DeleteDomain | `Failure` | 98.67 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 103.72 | test_accounts.py
   test_dedicateGuestVlanRange | `Error` | 0.00 | test_guest_vlan_range.py
   ContextSuite context=TestDedicateGuestVlanRange>:teardown | `Error` | 0.00 | 
test_guest_vlan_range.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 2.85 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 2.85 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.78 | 
test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.85 | 
test_internal_lb.py
   test_01_create_ipv6_public_ip_range | `Error` | 0.04 | test_ipv6_infra.py
   test_04_verify_guest_lspci | `Error` | 810.64 | test_deploy_virtio_scsi_vm.py
   test_06_verify_guest_lspci_again | `Error` | 810.67 | 
test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | 
test_loadbalance.py
   test_01_ping_in_vr_success | `Failure` | 0.03 | test_diagnostics.py
   test_02_ping_in_vr_failure | `Failure` | 0.03 | test_diagnostics.py
   test_07_arping_in_vr | `Failure` | 0.02 | test_diagnostics.py
   test_10_traceroute_in_vr | `Failure` | 0.02 | test_diagnostics.py
   test_13_retrieve_vr_default_files | `Failure` | 0.02 | test_diagnostics.py
   test_14_retrieve_vr_one_file | `Failure` | 0.02 | test_diagnostics.py
   test_01_native_to_native_network_migration | `Error` | 4.94 | 
test_migration.py
   test_02_native_to_native_vpc_migration | `Error` | 7.56 | test_migration.py
   test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 4.55 
| test_direct_download.py
   ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 1.09 
| test_direct_download.py
   test_network_acl | `Error` | 2.39 | test_network_acl.py
   test_03_create_network_domain_network_offering | `Error` | 8.26 | 
test_domain_network_offerings.py
   ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | 
test_network_ipv6.py
   test_03_create_vpc_domain_vpc_offering | `Error` | 9.78 | 
test_domain_vpc_offerings.py
   test_10_vpc_tier_kubernetes_cluster | `Error` | 2.57 | 
test_kubernetes_clusters.py
   ContextSuite context=TestNetworkPermissions>:setup | `Error` | 0.00 | 
test_network_permissions.py
   test_delete_account | `Error` | 108.75 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 5.66 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 5.66 | test_network.py
   test_deploy_vm_l2network | `Error` | 6.68 | test_network.py
   test_deploy_vm_l2network | `Error` | 6.68 | test_network.py
   test_l2network_restart | `Error` | 7.76 | test_network.py
   test_l2network_restart | `Error` | 7.76 | test_network.py
   ContextSuite context=TestL2Networks>:teardown | `Error` | 8.90 | 
test_network.py
   test_01_port_fwd_on_src_nat | `Failure` | 0.03 | test_network.py
   test_02_port_fwd_on_non_src_nat | `Error` | 0.03 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 7.71 | test_network.py
   test_reboot_router | `Error` | 160.71 | test_network.py
   test_releaseIP | `Error` | 41.27 | test_network.py
   test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 0.04 | 
test_network.py
   test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 0.04 | 
test_network.py
   test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 0.04 
| test_network.py
   test_01_nic | `Error` | 44.52 | test_nic.py
   test_extendPhysicalNetworkVlan | `Error` | 0.05 | test_non_contigiousvlan.py
   ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | 
test_nonstrict_affinity_group.py
   ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 
0.00 | test_password_server.py
   test_01_isolated_persistent_network | `Error` | 0.05 | 
test_persistent_network.py
   ContextSuite context=TestPortablePublicIPAcquire>:setup | `Error` | 0.00 | 
test_portable_publicip.py
   test_01_create_delete_portforwarding_fornonvpc | `Error` | 3.37 | 
test_portforwardingrules.py
   test_01_vpc_privategw_acl | `Failure` | 5.42 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 5.59 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | 

Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-19 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2066711425

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-19 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2066709115

   @blueorangutan test alma9 kvm-alma9 keepEnv securityGroups


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-18 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2065613357

   [SF] Trillian test result (tid-9903)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 44286 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8489-t9903-kvm-alma9.zip
   Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-18 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063832831

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-18 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063831518

   @blueorangutan test alma9 kvm-alma9 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-18 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063568256

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org