Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel merged PR #12605: URL: https://github.com/apache/cloudstack/pull/12605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4227260322 [SF] Trillian test result (tid-15850) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 50155 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12605-t15850-kvm-ol8.zip Smoke tests completed. 151 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
DaanHoogland commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4222191264 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4222196777 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4219596545 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4219357631 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4219349750 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4219314283 @bernardodemarco see #12523. This change was not appropriately discussed while addressing the vulnerability that prompted the introduction of the setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4219316493 @DaanHoogland could we run the CI here one last time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4179045454 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4178758244 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-4178755404 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3937211739 [SF] Trillian test result (tid-15503) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 52161 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12605-t15503-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_LoginApiDomain | `Error` | 7.20 | test_accounts.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3931853686 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
sureshanaparti commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3931851076 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3929252660 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3928775331 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3928773241 > @winterhazel the mgmt service failed to start , can you check ? the simulator CI tests failed too @weizhouapache should be fixed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3928769984 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on code in PR #12605:
URL: https://github.com/apache/cloudstack/pull/12605#discussion_r2829196385
##
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42020to42030.java:
##
@@ -51,6 +55,44 @@ public InputStream[] getPrepareScripts() {
@Override
public void performDataMigration(Connection conn) {
+unhideJsInterpretationEnabled(conn);
+}
+
+protected void unhideJsInterpretationEnabled(Connection conn) {
+String value = getJsInterpretationEnabled(conn);
+if (value != null) {
+updateJsInterpretationEnabledFields(conn, value);
+}
+}
+
+protected String getJsInterpretationEnabled(Connection conn) {
+String query = "SELECT value FROM cloud.configuration WHERE name =
'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+ResultSet rs = pstmt.executeQuery();
+if (rs.next()) {
+return rs.getString("value");
+}
+logger.debug("Unable to retrieve value of hidden configuration
'js.interpretation.enabled'. The configuration may already be unhidden.");
+return null;
+} catch (SQLException e) {
+throw new CloudRuntimeException("Error while retrieving value of
hidden configuration 'js.interpretation.enabled'.", e);
+}
+}
+
+protected void updateJsInterpretationEnabledFields(Connection conn, String
encryptedValue) {
+String query = "UPDATE cloud.configuration SET value = ?, category =
'System' WHERE name = 'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+String decryptedValue = DBEncryptionUtil.decrypt(encryptedValue);
+logger.info("Updating setting 'js.interpretation.enabled' to
decrypted value [{}], and category 'System'.", decryptedValue);
+pstmt.setString(1, decryptedValue);
+pstmt.executeUpdate();
+} catch (SQLException e) {
+throw new CloudRuntimeException("Error while unhiding
configuration 'js.interpretation.enabled'.", e);
+} catch (CloudRuntimeException e) {
+logger.warn("Error while decrypting configuration
'js.interpretation.enabled'. The configuration may already be decrypted.");
+}
Review Comment:
It doesn't throw a EncryptionOperationNotPossibleException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
weizhouapache commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3908386893 @winterhazel the mgmt service failed to start , can you check ? the simulator CI tests failed too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3908323976 [SF] Trillian Build Failed (tid-15484) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
Copilot commented on code in PR #12605:
URL: https://github.com/apache/cloudstack/pull/12605#discussion_r2812100897
##
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42020to42030.java:
##
@@ -51,6 +55,44 @@ public InputStream[] getPrepareScripts() {
@Override
public void performDataMigration(Connection conn) {
+unhideJsInterpretationEnabled(conn);
+}
+
+protected void unhideJsInterpretationEnabled(Connection conn) {
+String value = getJsInterpretationEnabled(conn);
+if (value != null) {
+updateJsInterpretationEnabledFields(conn, value);
+}
+}
+
+protected String getJsInterpretationEnabled(Connection conn) {
+String query = "SELECT value FROM cloud.configuration WHERE name =
'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+ResultSet rs = pstmt.executeQuery();
+if (rs.next()) {
+return rs.getString("value");
+}
+logger.debug("Unable to retrieve value of hidden configuration
'js.interpretation.enabled'. The configuration may already be unhidden.");
+return null;
+} catch (SQLException e) {
+throw new CloudRuntimeException("Error while retrieving value of
hidden configuration 'js.interpretation.enabled'.", e);
+}
+}
+
+protected void updateJsInterpretationEnabledFields(Connection conn, String
encryptedValue) {
+String query = "UPDATE cloud.configuration SET value = ?, category =
'System' WHERE name = 'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+String decryptedValue = DBEncryptionUtil.decrypt(encryptedValue);
+logger.info("Updating setting 'js.interpretation.enabled' to
decrypted value [{}], and category 'System'.", decryptedValue);
+pstmt.setString(1, decryptedValue);
+pstmt.executeUpdate();
+} catch (SQLException e) {
+throw new CloudRuntimeException("Error while unhiding
configuration 'js.interpretation.enabled'.", e);
+} catch (CloudRuntimeException e) {
+logger.warn("Error while decrypting configuration
'js.interpretation.enabled'. The configuration may already be decrypted.");
+}
Review Comment:
The error handling here catches a generic CloudRuntimeException, but
DBEncryptionUtil.decrypt() throws EncryptionOperationNotPossibleException when
the value is already decrypted. The catch block should specifically catch
EncryptionOperationNotPossibleException to distinguish between an
already-decrypted value and an actual error. Additionally, when catching this
exception, the code should proceed with using the encrypted value (since it's
already decrypted) instead of just logging a warning and not updating the
database.
##
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42020to42030.java:
##
@@ -51,6 +55,44 @@ public InputStream[] getPrepareScripts() {
@Override
public void performDataMigration(Connection conn) {
+unhideJsInterpretationEnabled(conn);
+}
+
+protected void unhideJsInterpretationEnabled(Connection conn) {
+String value = getJsInterpretationEnabled(conn);
+if (value != null) {
+updateJsInterpretationEnabledFields(conn, value);
+}
+}
+
+protected String getJsInterpretationEnabled(Connection conn) {
+String query = "SELECT value FROM cloud.configuration WHERE name =
'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+ResultSet rs = pstmt.executeQuery();
+if (rs.next()) {
+return rs.getString("value");
+}
+logger.debug("Unable to retrieve value of hidden configuration
'js.interpretation.enabled'. The configuration may already be unhidden.");
+return null;
+} catch (SQLException e) {
+throw new CloudRuntimeException("Error while retrieving value of
hidden configuration 'js.interpretation.enabled'.", e);
+}
+}
+
+protected void updateJsInterpretationEnabledFields(Connection conn, String
encryptedValue) {
+String query = "UPDATE cloud.configuration SET value = ?, category =
'System' WHERE name = 'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+String decryptedValue = DBEncryptionUtil.decrypt(encryptedValue);
+logger.info("Updating setting 'js.interpretation.enabled' to
decrypted value [{}], and category 'System'.", decryptedValue);
Review Comment:
The SQL UPDATE statement only updates the 'value' and 'category' fields, but
according to the PR description and the new ConfigKey definition in
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3876509418 [SF] Trillian Build Failed (tid-15426) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3876364525 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
DaanHoogland commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3876360670 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3872766021 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3872320604 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3872165784 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
sureshanaparti commented on code in PR #12605:
URL: https://github.com/apache/cloudstack/pull/12605#discussion_r2781874788
##
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42020to42030.java:
##
@@ -51,6 +55,44 @@ public InputStream[] getPrepareScripts() {
@Override
public void performDataMigration(Connection conn) {
+unhideJsInterpretationEnabled(conn);
+}
+
+protected void unhideJsInterpretationEnabled(Connection conn) {
+String value = getJsInterpretationEnabled(conn);
+if (value != null) {
+updateJsInterpretationEnabledFields(conn, value);
+}
+}
+
+protected String getJsInterpretationEnabled(Connection conn) {
+String query = "SELECT value FROM cloud.configuration WHERE name =
'js.interpretation.enabled' AND category = 'Hidden';";
+
+try (PreparedStatement pstmt = conn.prepareStatement(query)) {
+ResultSet rs = pstmt.executeQuery();
+if (rs.next()) {
+return rs.getString("value");
+}
+logger.debug("Unable to retrieve value of hidden configuration
'js.interpretation.enabled'. The configuration may already be unhidden.");
+return null;
+} catch (SQLException e) {
+throw new CloudRuntimeException("Error while retrieving value of
hidden configuration 'js.interpretation.enabled'.", e);
+}
+}
+
+protected void updateJsInterpretationEnabledFields(Connection conn, String
encryptedValue) {
+String query = "UPDATE cloud.configuration SET value = ?, category =
'System' WHERE name = 'js.interpretation.enabled';";
Review Comment:
```suggestion
String query = "UPDATE cloud.configuration SET value = ?, category =
'System' WHERE name = 'js.interpretation.enabled' AND category = 'Hidden';";
```
to be specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3870273177 [SF] Trillian Build Failed (tid-15416) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3870102069 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
DaanHoogland commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3870091079 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3861104836 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
codecov[bot] commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3860853050 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12605?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 4.15%. Comparing base ([`3d7d412`](https://app.codecov.io/gh/apache/cloudstack/commit/3d7d412d5bedf77c8994553562a1ba2c0c65cfbe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`007be77`](https://app.codecov.io/gh/apache/cloudstack/commit/007be77d5b063f444e108445772d0307d967339c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > :exclamation: There is a different number of reports uploaded between BASE (3d7d412) and HEAD (007be77). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (3d7d412) | HEAD (007be77) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #12605 +/- ## = - Coverage 16.26%4.15% -12.11% = Files 5661 404 -5257 Lines50001032965 -467045 Branches 60715 5893-54822 = - Hits 81331 1370-79961 + Misses 40960631419 -378187 + Partials 9073 176 -8897 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12605/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12605/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.15% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12605/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12605?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting `js.interpretation.enabled` [cloudstack]
blueorangutan commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3860836604 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Unhide setting 'js.interpretation.enabled' [cloudstack]
winterhazel commented on PR #12605: URL: https://github.com/apache/cloudstack/pull/12605#issuecomment-3860830555 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
