Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-18 Thread via GitHub 


weizhouapache commented on code in PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#discussion_r2433573874


##
python/lib/cloudutils/networkConfig.py:
##
@@ -150,10 +153,10 @@ def getDevInfo(dev):
 if line.find("HWaddr") != -1:
 macAddr = line.split("HWaddr ")[1].strip(" ")
 elif line.find("inet ") != -1:
-m = re.search("addr:(.*)\ *Bcast:(.*)\ *Mask:(.*)", line)
+m = 
re.search(r"addr:([^\s]+)\s*Bcast:([^\s]+)\s*Mask:([^\s]+)", line)

Review Comment:
   this does not work on either ubuntu or rocky/ol
   
   the line looks like
   ```
   inet 10.0.34.xxx  netmask 255.255.240.0  broadcast 10.0.47.255
   ```
   
   we can fix it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-18 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-342605

   [SF] Trillian test result (tid-14644)
   Environment: kvm-ubuntu24 (x2), zone: Advanced Networking with Mgmt server 
u24
   Total time taken: 63022 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11318-t14644-kvm-ubuntu24.zip
   Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-18 Thread via GitHub 


DaanHoogland commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3396603396

   @blueorangutan test ubuntu24 kvm-ubuntu24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-18 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3396067958

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-18 Thread via GitHub 


weizhouapache merged PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-18 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3396574390

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
15426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-17 Thread via GitHub 


shwstppr commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3396066838

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-17 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3403794291

   [SF] Trillian Build Failed (tid-14674)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-17 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3403145732

   [SF] Trillian Build Failed (tid-14672)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-15 Thread via GitHub 


Copilot commented on code in PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#discussion_r2433326009


##
python/lib/cloudutils/networkConfig.py:
##
@@ -45,8 +45,11 @@ def getDefaultNetwork():
 if not cmd.isSuccess():
 logging.debug("Failed to get default route")
 raise CloudRuntimeException("Failed to get default route")
-
-result = cmd.getStdout().split(" ")
+output = cmd.getStdout().strip()
+result = output.split(" ")
+if len(result) < 2:
+logging.debug("Output for the default route incomplete: %s. It 
should have been ' '" % output)
+raise CloudRuntimeException("Output for the default route 
incomplete")
 gateway = result[0]
 dev = result[1]
 

Review Comment:
   Splitting by a literal space can yield empty tokens when the output contains 
multiple spaces or tabs (common in shell output), causing dev to become an 
empty string despite len(result) >= 2. Use whitespace splitting to normalize 
tokens, e.g., parts = output.split(), then gateway = parts[0], dev = parts[1], 
or use a regex like m = re.match(r'(\\S+)\\s+(\\S+)', output).



##
python/lib/cloudutils/networkConfig.py:
##
@@ -45,8 +45,11 @@ def getDefaultNetwork():
 if not cmd.isSuccess():
 logging.debug("Failed to get default route")
 raise CloudRuntimeException("Failed to get default route")
-
-result = cmd.getStdout().split(" ")
+output = cmd.getStdout().strip()
+result = output.split(" ")
+if len(result) < 2:
+logging.debug("Output for the default route incomplete: %s. It 
should have been ' '" % output)
+raise CloudRuntimeException("Output for the default route 
incomplete")

Review Comment:
   The raised exception lacks context for troubleshooting. Consider including 
the actual output and the expected format in the exception message, e.g., raise 
CloudRuntimeException(\"Output for the default route incomplete: '%s' (expected 
' ')\" % output).
   ```suggestion
   raise CloudRuntimeException("Output for the default route 
incomplete: '%s' (expected ' ')" % output)
   ```



##
python/lib/cloudutils/configFileOps.py:
##
@@ -68,14 +68,14 @@ def save(self):
 for entry in self.entries:
 if entry.op == "add":
 if entry.separator == "=":
-matchString = "^\ *" + entry.name + ".*"
+matchString = r"^\ *" + entry.name + ".*"
 elif entry.separator == " ":
-matchString = "^\ *" + entry.name + "\ *" + 
entry.value
+matchString = r"^\ *" + entry.name + r"\ *" + 
entry.value
 else:
 if entry.separator == "=":
-matchString = "^\ *" + entry.name + "\ *=\ *" + 
entry.value
+matchString = r"^\ *" + entry.name + r"\ *=\ *" + 
entry.value
 else:
-matchString = "^\ *" + entry.name + "\ *" + 
entry.value
+matchString = r"^\ *" + entry.name + r"\ *" + 
entry.value

Review Comment:
   These regexes should use \\s* (or \\s+) for whitespace and escape dynamic 
components to prevent unintended regex metacharacter interpretation. Example: 
name = re.escape(entry.name); value = re.escape(entry.value); then build 
patterns with r'^\\s*' + name + r'\\s*=\\s*' + value (or r'^\\s*' + name + 
r'\\s+' + value). Also, r'\\ *' is unusual; prefer clear whitespace classes.



##
python/lib/cloudutils/utilities.py:
##
@@ -63,7 +63,7 @@ def getStdout(self):
 return self.stdout.decode('utf-8').strip('\n')
 
 def getLines(self):
-return self.stdout.decode('utf-8').strip('\n')
+return self.stdout.decode('utf-8').strip('\n').split('\n')

Review Comment:
   Use splitlines() to robustly handle different newline conventions and avoid 
edge cases with trailing newlines: return 
self.stdout.decode('utf-8').splitlines().
   ```suggestion
   return self.stdout.decode('utf-8').splitlines()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-15 Thread via GitHub 


weizhouapache commented on code in PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#discussion_r2432799735


##
python/lib/cloudutils/networkConfig.py:
##
@@ -150,10 +153,10 @@ def getDevInfo(dev):
 if line.find("HWaddr") != -1:

Review Comment:
   It seems `cmd.getLines()` has never been worked .
   
   a change might be needed
   ```
   diff --git a/python/lib/cloudutils/utilities.py 
b/python/lib/cloudutils/utilities.py
   index 5f7e34ed61d..31f35ee6d44 100755
   --- a/python/lib/cloudutils/utilities.py
   +++ b/python/lib/cloudutils/utilities.py
   @@ -63,7 +63,7 @@ class bash:
return self.stdout.decode('utf-8').strip('\n')

def getLines(self):
   -return self.stdout.decode('utf-8').strip('\n')
   +return self.stdout.decode('utf-8').strip('\n').split('\n')

def getStderr(self):
return self.stderr.decode('utf-8').strip('\n')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-15 Thread via GitHub 


weizhouapache commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3405040931

   looks good
   
   4.21.0.0
   ```
   Setting up cloudstack-common (4.21.0.0-shapeblue0) ...
   Listing '/usr/lib/python3/dist-packages/cloudutils'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/__init__.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/cloudException.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/configFileOps.py'...
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:71: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + ".*"
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:73: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + "\ *" + entry.value
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:73: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + "\ *" + entry.value
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:76: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + "\ *=\ *" + entry.value
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:76: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + "\ *=\ *" + entry.value
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:78: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + "\ *" + entry.value
   /usr/lib/python3/dist-packages/cloudutils/configFileOps.py:78: 
SyntaxWarning: invalid escape sequence '\ '
 matchString = "^\ *" + entry.name + "\ *" + entry.value
   Compiling '/usr/lib/python3/dist-packages/cloudutils/db.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/globalEnv.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/networkConfig.py'...
   /usr/lib/python3/dist-packages/cloudutils/networkConfig.py:153: 
SyntaxWarning: invalid escape sequence '\ '
 m = re.search("addr:(.*)\ *Bcast:(.*)\ *Mask:(.*)", line)
   Compiling '/usr/lib/python3/dist-packages/cloudutils/serviceConfig.py'...
   Compiling 
'/usr/lib/python3/dist-packages/cloudutils/serviceConfigServer.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/syscfg.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/utilities.py'...
   Scanning processes...
   
   ```
   
   
   with this PR
   ```
   Setting up cloudstack-common (4.20.2.0-shapeblue16348~xenial) ...
   Listing '/usr/lib/python3/dist-packages/cloudutils'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/__init__.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/cloudException.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/configFileOps.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/db.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/globalEnv.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/networkConfig.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/serviceConfig.py'...
   Compiling 
'/usr/lib/python3/dist-packages/cloudutils/serviceConfigServer.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/syscfg.py'...
   Compiling '/usr/lib/python3/dist-packages/cloudutils/utilities.py'...
   Scanning processes...


   Scanning candidates...   


   Scanning linux images...   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-14 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3403108263

   [SF] Trillian Build Failed (tid-14670)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-10-13 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3396607524

   @DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + 
kvm-ubuntu24) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-17 Thread via GitHub 


shwstppr commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3265809221

   @weizhouapache will do


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-17 Thread via GitHub 


weizhouapache commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3267186897

   @blueorangutan test ubuntu24 kvm-ubuntu24 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-09 Thread via GitHub 


weizhouapache commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3270435661

   there is only a warning now
   ```
   Compiling 
'/usr/lib/python3/dist-packages/cloudutils/networkConfig.py'...\r\n/usr/lib/python3/dist-packages/cloudutils/networkConfig.py:156:
 SyntaxWarning: invalid escape sequence '\\ '\r\n  m = re.search(\"addr:(.*)\\ 
*Bcast:(.*)\\ *Mask:(.*)\", line)\r\n
   ```
   
   @shwstppr 
   can you fix it as well ? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3267379357

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + 
kvm-ubuntu24) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


weizhouapache commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3267371796

   
   @blueorangutan test ubuntu24 kvm-ubuntu24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3267308549

   [SF] Trillian Build Failed (tid-14246)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3267194336

   @weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + 
kvm-ubuntu24) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3267154672

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 
14903


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


weizhouapache commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3266839139

   thanks @shwstppr 
   I will test it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


blueorangutan commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3266792770

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


shwstppr commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3266787003

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-08 Thread via GitHub 


weizhouapache commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3265800332

   > should this be targeted towards 4.20?
   
   +1
   
   @shwstppr can you maybe rebase it with 4.20 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-09-03 Thread via GitHub 


Pearl1594 commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3250567428

   should this be targeted towards 4.20? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] cloudutils: fix warning, error during kvm agent installation [cloudstack]

2025-07-28 Thread via GitHub 


codecov[bot] commented on PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#issuecomment-3130678243

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11318?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.82%. Comparing base 
([`cca8b2f`](https://app.codecov.io/gh/apache/cloudstack/commit/cca8b2fef9016bc04cde10f2f2ef4bf6f345155e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`cb7d2ff`](https://app.codecov.io/gh/apache/cloudstack/commit/cb7d2ffe3db9cea787a7c8fafe84172509d0d275?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 6 commits behind head on main.
   > :exclamation:  There is a different number of reports uploaded between 
BASE (cca8b2f) and HEAD (cb7d2ff). Click for more details.
   > 
   > HEAD has 1 upload less than BASE
   >
   >| Flag | BASE (cca8b2f) | HEAD (cb7d2ff) |
   >|--|--|--|
   >|unittests|1|0|
   >
   
   Additional details and impacted files
   
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   main   #11318   +/-   ##
   =
   - Coverage 16.99%3.82%   -13.18% 
   =
 Files  5832  432 -5400 
 Lines51756134897   -482664 
 Branches  62982 6294-56688 
   =
   - Hits  87975 1334-86641 
   + Misses   41965133403   -386248 
   + Partials   9935  160 -9775 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11318/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `3.82% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11318?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]